gitoriaLog in with ident

tracker

All repositories: gitoria

ReadmeCodePull requestsReleasesTicketsSettings
Commitf8ffa4dbf8ffa4dbtracker: report 032 + The Remaining + #39mref8ffa4db/lib/watches.hl

6.3 KB

  1. // lib/watches.hl — PER-USER WATCH STATE (episode/season checks, tracker.worldapi.org#4), reused as-is
  2. // (not copied) by /unwatched and /schedule (tickets #5/#6: "same check icon and watch logic as the
  3. // show page — reuse, don't copy"). storage/mpackdb/watches.db, migrated by tools/migrate.hl
  4. // (tracker.worldapi.org#2): { targetType ('episode'|'season'|'movie'), target, user, at, oldId }. 'movie' (mission 058,
  5. // tracker#24): target = the movie's shows.db id. A season's CHECK on the page is derived from its episodes (components/show.hl).
  6. import { MPackDB } from 'hl:mpackdb'
  7. import { now } from 'hl:time'
  8. import { randomBytes } from 'hl:crypto'
  9. import { storageDir } from './util.hl'
  10. static watchesTable = new MPackDB(file = storageDir + '/watches.db', primaryKey = '@id', indexes = ['!oldId'])
  11. // every watch of this user — a linear scan (11692 rows total across every user, migrated data; cheap
  12. // once per page load) — no declared index on `user`
  13. // mission 062: KEPT per user until that user's next write (setWatched) — one watch click asked for it 3 times (the face, then
  14. // the page's re-mount for the session sync: rows + watchedEpisodes), each a scan + decode of every watch (~25 ms on the real data).
  15. // One process per storage (hybriel#21): every write goes through setWatched below. Flat statics, written key by key (plain data
  16. // deep-copies on assignment)
  17. static watchCache = {}
  18. static watchCacheOk = {}
  19. static watchesOfUser = (&userId) => {
  20. if (userId == null) { return [] }
  21. if (watchCacheOk[userId] == true) { return watchCache[userId] }
  22. out = []
  23. for (w of watchesTable.find(null, null)) { if (w.user == userId) { out.push(w) } }
  24. watchCache[userId] = out
  25. watchCacheOk[userId] = true
  26. return out
  27. }
  28. // '<targetType>:<target>' → true for every watch in `rows`: built ONCE per page load so a list asks
  29. // `watched['episode:' + e.id] == true` instead of `isWatched` scanning all the user's watches per episode
  30. // (/my/unwatched, tracker.worldapi.org#8: 831 rows × 11,692 watches took ~15 s)
  31. static watchedSet = (&rows) => {
  32. m = {}
  33. for (w of rows) { if (w.target != null) { m[w.targetType + ':' + w.target] = true } }
  34. return m
  35. }
  36. // tracker#30 (mission 025): `watchedSet` of a user's watches, KEPT like watchesOfUser until that user's next setWatched — the
  37. // /my/ lists ask for it on every load (11.7k rows → a fresh 11.7k-key map each time). Returned, never `let`-copied (shows.hl
  38. // cardOf).
  39. static watchedSetCache = {}
  40. static watchedSetOk = {}
  41. static watchedSetOf = (&userId) => {
  42. if (userId == null) { return {} }
  43. if (watchedSetOk[userId] == true && watchCacheOk[userId] == true) { return watchedSetCache[userId] }
  44. watchedSetCache[userId] = watchedSet(watchesOfUser(userId))
  45. watchedSetOk[userId] = true
  46. return watchedSetCache[userId]
  47. }
  48. // merge.hl (tracker#31) moved watches of this user to another target: the kept rows/set are read again
  49. static forgetUserWatches = (&userId) => {
  50. if (userId == null) { return null }
  51. watchCacheOk[userId] = false
  52. watchedSetOk[userId] = false
  53. return null
  54. }
  55. // every episode id anyone has watched (project.hl warms shows.hl episodeKeyOf with them at boot, tracker#30)
  56. static allWatchedEpisodeIds = () => {
  57. out = []
  58. for (w of watchesTable.find(null, null)) { if (w.targetType == 'episode' && w.target != null) { out.push(w.target) } }
  59. return out
  60. }
  61. static findWatch = (&rows, &targetType, &targetId) => {
  62. for (w of rows) { if (w.targetType == targetType && w.target == targetId) { return w } }
  63. return null
  64. }
  65. static isWatched = (&rows, &targetType, &targetId) => { return findWatch(rows, targetType, targetId) != null }
  66. // the check's class — "a disc with a check in it", solid once watched, regular while not (the
  67. // SAME icon and class the show page uses, tracker.worldapi.org#4/#5 — /unwatched and /schedule
  68. // reuse this instead of each declaring their own)
  69. static watchClassOf = (&watched) => { return watched ? 'checkicon solid' : 'checkicon regular' }
  70. // a NEW watch's oldId can't be null: the table's `!oldId` UNIQUE index would refuse a second one
  71. // (the migrated rows all carry a real Mongo hex id; a fresh watch gets its own unique marker instead)
  72. static setWatched = (&userId, targetType, &targetId, &rows, &watched) => {
  73. existing = findWatch(rows, targetType, targetId)
  74. watchCacheOk[userId] = false
  75. watchedSetOk[userId] = false
  76. if (watched) {
  77. if (existing != null) { return true }
  78. id = watchesTable.put({ id = randomBytes(8, 'hex') targetType = targetType target = targetId user = userId at = now() oldId = 'app:' + randomBytes(8, 'hex') })
  79. return id != null
  80. }
  81. if (existing == null) { return true }
  82. return watchesTable.delete(existing.id) > 0
  83. }
  84. // a season check toggles the season's OWN watch record AND every one of its episodes (creator: "if
  85. // the season is checked or unchecked all its episodes get checked or unchecked") — `rows` is the
  86. // snapshot from BEFORE this batch; every target below is distinct, so the staleness across the loop
  87. // never matters (no two calls touch the same target)
  88. static setSeasonWatched = (&userId, &seasonId, &episodeIds, &rows, &watched) => {
  89. let ok = setWatched(userId, 'season', seasonId, rows, watched)
  90. for (eid of episodeIds) { ok = setWatched(userId, 'episode', eid, rows, watched) && ok }
  91. return ok
  92. }
  93. // ---- the checks clicked (the show page's faces, components/show.hl — mission 028: out of the faces) ------------------------
  94. // an episode's or a movie's check (#4, #24): watched → not, not → watched; the new state, or null when it could not be saved
  95. static toggleWatched = (&userId, targetType, &targetId) => {
  96. rows = watchesOfUser(userId)
  97. watched = isWatched(rows, targetType, targetId) == false
  98. return setWatched(userId, targetType, targetId, rows, watched) ? watched : null
  99. }
  100. // #23: a season is watched when ALL its episodes are (by the ids it lists); one without episodes keeps its own season watch
  101. static seasonAllWatched = (&s, &watched) => {
  102. if (s.episodes.length == 0) { return watched['season:' + s.id] == true }
  103. for (eid of s.episodes) { if (watched['episode:' + eid] != true) { return false } }
  104. return true
  105. }
  106. // #23: a season's check: not all its episodes watched → watch them all; all watched → unwatch them all. The new state or null
  107. static toggleSeasonWatched = (&userId, &season) => {
  108. rows = watchesOfUser(userId)
  109. watched = !seasonAllWatched(season, watchedSet(rows))
  110. return setSeasonWatched(userId, season.id, season.episodes, rows, watched) ? watched : null
  111. }

Branches

Latest commits

  • f8ffa4dbtracker: report 032 + The Remaining + #39mre
  • 7565a863tracker: LOG timemre
  • b10f00c8tracker#39: double episodes — migrated episodes whose TMDB id TMDB replaced are adopted by their number in the sync (old id -> migratedTmdbId); merge.hl step 3 merges each season's doubles at start (keeper: most watches > synced > first; watches moved/parked; tombstones into mergedEpisodes, nothing deleted); tools/count-duplicate-episodes.hl; gate fixture + paths-m039; live copy 850 -> 0 in 64 s; gates 373/0, 32/0, 52/0mre
  • 8751adb8tracker: report 032mre
  • 9bce1f65tracker mission 032: STATUS gate files + the hour-boundary flakemre
  • 718bfb89tracker#37 (mission 032): /people = everyone, last updated first (updatedAt stamped by the person fill; view built at boot, touched people first at once), photo + name tiles (person colour) with the /movies pagination, /people/<letter> removed; photo = our file, tmdbProfile, a cast/crew entry's profile (in-memory map at boot), else the new 'no photo' placeholder; new cast/crew/created_by people keep tmdbProfile; search people rows with the photo; /settings = the heading only; util.hl sortDesc starts from sorted runs (same result, 105k: 1.6 s -> 0.15 s); gates 369/0, 32/0, 52/0, check-theme 0; README/STATUS/LOGmre
  • 96ba683adeploy.sh: a gate without a 'passed,' line (check-theme) no longer ends the scriptmre
  • eb3b9205tracker: report 031mre
  • 9b5d2e89tracker mission 031: README (What it does, Test: four gates + the #32 checks, Files: theme/, new pages), STATUS (real copy, A/B load, how to repeat, open points), LOGmre
  • 39950e4ctracker#32 (mission 031): the WorldAPI theme (theme/ vendored verbatim from layouts.worldapi.org 85b5654; styles.hl inherits it: accent green-dark, type colours 1-6; own base/header rules, row lines, genre-pill and inverted-button frames removed, the season foldable keeps its line; check-theme 21 -> 0, 4th deploy gate; main actions class primary) and the #32 header (theme AppHeader/MainMenu/UserMenu/Sidebar/ContentFirst: desktop brand, search, Series|Shows|Movies|Genres|People, user icon with Unwatched..Settings, Logout; signed out the ident selector, phone the iD icon dropdown; phone menu in the sidebar overlay; marked entry by :has); /find -> /search/<q>, /genres, /people(/<letter>), /settings; main { ContentFirst { slot } } works around the hl:web one-line slot bug; gates 365/0, 32/0, 52/0, check-theme 0mre
  • a386dc92tracker: reports 029 + 030mre
  • 71e0fd7dtracker missions 029 + 030: README (What it does, Files, gate count), STATUS (real-copy numbers, how to repeat, open points), LOGmre
  • d36ea6eatracker#34 + #35 (mission 030): Follow directly under the poster, as wide as the poster (show.hl, styles.hl); the status pill next to a series' title — TVmaze's status (new tvmazeStatus, stored by the sync's TVmaze merge) else TMDB's, TVmaze Ended + TMDB Canceled = Canceled, inverted (filled, dark text, no border), green running / yellow pending / red canceled / muted ended (shows.hl statusOf); the daily delta asks TVmaze's status of an unfollowed series TVmaze's change list names (dailysync.hl syncRunStep, sync.hl syncTvmazeStatus); the status backfill after the details repair (backfill.hl, jobs.hl statusTick; resumable, 550 ms per TVmaze request); gates 354/0, 32/0, 52/0mre
  • 7d7d4487tracker#33 (mission 029): reduced titles — every title TMDB's details never went through this app (no detailsAt, no tmdbSync) is incomplete (shows.hl isIncomplete; the old tracker's migrated rows passed #26's test: 5,697 non-adult on the live copy, 691 series without seasons); the repair job does the visibly reduced first (shows.hl missingParts), the page completes one on open; a title TMDB has no poster for (The Remaining) shows the placeholder; tools/count-incomplete.hl; gate fixtures stand for synced titles (tmdbSync), tests/seed-reduced.hl + #33 checks; gates 347/0, 32/0, 52/0mre
  • 661c2592tracker: report 028mre
  • 27c916fatracker mission 028: README ("Code order", the new file map), STATUS (counts before/after, tests, how to repeat, open), LOGmre
  • d924f398tracker mission 028: comments name the new files (sync.hl, dailysync.hl, backfill.hl, credits.hl, jobs.hl, images.hl …); tools/ref-params.py + tools/lambda-audit.py also scan lib/ (they globbed the root only), lambda-audit counts a plain `x = p` alias like `let x = p`mre
  • 2e89b968tracker mission 028 (code order) 5/5 let: `let` only where a variable is reassigned — 667 never-reassigned lets became plain declarations (project.hl, lib/, components/, tools/, tests/); kept: 264 in loop bodies (a plain declaration there is 'Cannot reassign' on the 2nd pass), 234 reassigned, 27 whose name is also a member/outer/free name (a plain write would rebind it); tools/let-audit.py decides and fixes (README 'Code order'); tests/realdata-m028.{sh,mjs} = the page-output diff on a real copy; gates 342/0, 32/0, 52/0, real-copy pages identicalmre
  • 54796ff2tracker mission 028 (code order) 4/5 thin faces + last copies: the show page's check/follow faces call lib/watches.hl toggleWatched / toggleSeasonWatched (seasonAllWatched moved there) and lib/follows.hl toggleFollowed; both logins (header selector face, /login/callback) share lib/users.hl userOfCode; todayStr/listOf copies in components and the export readers copied into tools/migrate.hl + tools/old-short-ids.hl now once (lib/util.hl, lib/export.hl); gates 342/0, 32/0, 52/0; old-short-ids output byte-identical, migrate output identicalmre
  • 06b078e3tracker mission 028 (code order) 3/5 project.hl is the map: config, routes, wiring and a feature → file index (914 → 258 lines); the background jobs (daily sync run, backfills, details repair, credits job, merge, short ids, collection seed) moved unchanged into lib/jobs.hl (a class: their state is reassigned every step, a static cannot be; one instance made after the server), the login callback into lib/users.hl, poster/photo serving into lib/images.hl, the /shows/<slug> rule into lib/shows.hl showsMovedPath; route handlers are thin wrappers; gates 342/0, 32/0, 52/0, real-copy pages identicalmre