gitoriaLog in with ident

tracker

All repositories: gitoria

ReadmeCodePull requestsReleasesTicketsSettings
Commiteb3b9205eb3b9205tracker: report 031mreeb3b9205/reports/020-tracker-franchises.md

6.9 KB

  1. # Report 066 — tracker#19: franchises and timelines
  2. **Commit**: `0553b51` on branch `t19` (worktree loreana:/media/STORAGE/projects/tracker-wt19, from fa1f9df). Not pushed, not merged, not deployed. main was not touched.
  3. ## Built
  4. - Tables `franchises.db`, `timelines.db` and `collectionchecks.db` (`franchises.hl`). A title can be in several timelines; an in-memory show → timelines map is built at boot.
  5. - `/franchises` lists the franchises, then the timelines that have no franchise.
  6. - `/franchises/<slug>` is the franchise index. Each timeline in it has its own toggle: Timeline (in-world order) or Release. For a series, Release uses the date of its last released episode.
  7. - `/timelines/<slug>` shows one timeline with its franchise above it.
  8. - Widget `‹ Prequel | Timeline | Sequel ›` on movie and series pages, one per timeline, with the franchise above it linking to the index. An end with no title is greyed out.
  9. - Editor for the creator only (`TRACKER_EDITORS`, default `az5b2`; every editing face checks it again on the server):
  10. - `/franchises/edit`: create a franchise or a timeline, find a timeline.
  11. - `/timelines/<slug>/edit`: franchise chips to attach the timeline, rows with ↑ ↓ ✕, and "Add titles" (search of our DB).
  12. - TMDB collection seed running inside the app:
  13. - Own clock, one movie per step, 260 ms per request.
  14. - Waits while the daily sync or the adult backfill runs.
  15. - Resumes after a restart; adult titles are skipped.
  16. - When a collection is fetched, all its parts that we have are marked checked, so their own details requests are never made.
  17. - Decisions:
  18. - A collection becomes a timeline only if it has at least 2 of our non-adult movies.
  19. - Seeded timelines get no franchise.
  20. - Public pages skip titles whose adult flag is not `false`; the editor shows all titles.
  21. ## Files touched (merge notes)
  22. | File | Change |
  23. |---|---|
  24. | `components/show.hl` | 1 import, 1 static, 1 member, 1 View line before `showSeasons` |
  25. | `project.hl` | 5 imports; 5 routes after `/genre/:genre`; `franchisesReady` at boot; the seed clock block before `on Error` |
  26. | `styles.hl` | one new section before "/ (tracker.worldapi.org#13)" and 2 lines in the media block |
  27. | `tests/browser.mjs` | `TRACKER_COLLECTIONS: '0'` in `startServer` |
  28. | `tests/faketmdb.mjs` | `collections` option, `belongs_to_collection`, `at` on recorded requests |
  29. | `README.md`, `STATUS.md` | new section / entry at the top |
  30. New files:
  31. - `franchises.hl`
  32. - `components/franchises.hl`, `components/franchise.hl`, `components/franchisewidget.hl`, `components/franchiseedit.hl`, `components/timelineedit.hl`
  33. - `tests/franchises.mjs`, `tests/seed-franchises.hl`, `tests/realdata-066.mjs`
  34. - `docs/franchises.md`
  35. ## Gates
  36. ```
  37. TRACKER_GATE_SHOTS=/tmp/w066/shots TRACKER_GATE_PORT=8732 TRACKER_GATE_IDENT_PORT=8733 TRACKER_GATE_CHROME=8734-8736 TRACKER_GATE_TMDB_PORT=8737 node tests/franchises.mjs
  38. 48 passed, 0 failed
  39. TRACKER_GATE_SHOTS=/tmp/w066/main-shots TRACKER_GATE_PORT=8732 TRACKER_GATE_IDENT_PORT=8733 TRACKER_GATE_CHROME=8734-8736 TRACKER_GATE_TMDB_PORT=8737 node tests/browser.mjs
  40. 266 passed, 0 failed
  41. ```
  42. The franchise gate (`tests/franchises.mjs`) covers:
  43. - **Seed from fake collections**: parts come back in release order; parts we don't have and adult parts are left out; a collection with one of our movies gives no timeline; a TMDB 404 and "no collection" are remembered.
  44. - **Resume**: stopped mid-run and restarted, no movie is asked twice and each collection is asked once.
  45. - **Pacing**: any 3 requests in a row span at least 500 ms.
  46. - **Widget**: previous/next links, greyed ends, a client-side Sequel click, the franchise above, two widgets for a title in two timelines.
  47. - **Index**: sorts both ways; a series is placed by its last released episode, not its 2099 episode or its year.
  48. - **Editor access**: signed out and a second user (bob) see the refusal; the creator can create, attach, add, move and remove.
  49. - **Layout**: no sideways scroll at 390 and 1280 px.
  50. ## Real data (copy of Byrodin `storage/`, ~22:47, port 8738, real TMDB)
  51. - **Seed**:
  52. - Checked 4,774 movies in 2,459 s (about 41 min) with 4,957 TMDB requests.
  53. - Result: **110 timelines with 272 titles**.
  54. - Of the rest, 235 collections had fewer than 2 of our movies and 4,143 movies had no collection.
  55. - 124 TMDB 404s, 0 retries; slowest step 860 ms.
  56. - **Page times during the seed** (curl, 40 runs each):
  57. | Page | Average |
  58. |---|---|
  59. | `/` | 0.08 s (one 2.2 s outlier) |
  60. | `/movies` | 0.01 s |
  61. | `/shows/Foundation` | 0.18 s |
  62. | `/franchises` | 0.11 s |
  63. - **Star Wars and Alien could not be used**: our data has no Star Wars or Alien movies, only series. I checked these collections instead:
  64. - Star Trek: The Next Generation (4 titles)
  65. - Harry Potter (7)
  66. - Lord of the Rings (3)
  67. - In all three the order is right and the widget on the middle title is right, e.g. Star Trek: First Contact shows ‹ Generations | TNG Collection | Insurrection ›.
  68. - **Full page loads**:
  69. - `/franchises`: 74–109 ms (83 KB, 110 timelines)
  70. - timeline pages: 49–213 ms
  71. - movie pages with the widget: 403–464 ms. With curl that is 0.38 s against 0.34 s for a movie with no timeline, so the widget adds about 40 ms.
  72. - Signed in as the creator (az5b2), the Edit link and the editor forms are there. 0 console problems.
  73. - Copy, sessions and the `.env` symlink were removed and the server stopped. My ports 8732–8739 are free.
  74. ## Screenshots (all looked at, on Loreana)
  75. - Gate: `/tmp/w066/shots/{franchises,franchise,timeline,widget-aliens,widget-movie,franchise-edit,timeline-edit,timeline-edit-reload}-{390,1280}.png`
  76. - Real data: `/tmp/w066/real/{franchises,timeline-*,widget-*,franchise-edit-creator,timeline-edit-creator}-{390,1280}.png`
  77. ## Open points
  78. 1. **Deploy**: the first start runs the seed for about 40 min, after the adult backfill.
  79. 2. **Not built**: renaming or deleting franchises and timelines, editing a franchise's summary, and the franchise `shortId` (the field stays null).
  80. 3. **Seed gaps**: a later run does not add new parts to a collection that already has a timeline. Titles imported later are not seeded unless their row in `collectionchecks.db` is removed.
  81. 4. **Widget position**: on a phone it comes after the cast; the creator may want it higher.
  82. 5. **Duplicate name**: a timeline page shows its name twice (the page title and the block heading).
  83. 6. **Pattern kill**: early on I ran one `pkill -f 'hybriel project.hl'` on Loreana to stop my smoke server. That pattern could have hit another worker's tracker server if one was running at that moment. When I checked right afterwards none was; after that I only killed by PID.
  84. 7. **`.env` for the real run**: the worktree has no `.env`, so for the real-data run I symlinked `../tracker.worldapi.org/.env` (I never read it) and removed the link afterwards.
  85. ## Hybriel
  86. No new issues. Workarounds used:
  87. - A hand-written `posOf` instead of list `indexOf`.
  88. - One flat row list instead of a nested `for` (hybriel#86).
  89. - No member reads both a route parameter and `session` (#121/#122).

Branches

Latest commits

  • eb3b9205tracker: report 031mre
  • 9b5d2e89tracker mission 031: README (What it does, Test: four gates + the #32 checks, Files: theme/, new pages), STATUS (real copy, A/B load, how to repeat, open points), LOGmre
  • 39950e4ctracker#32 (mission 031): the WorldAPI theme (theme/ vendored verbatim from layouts.worldapi.org 85b5654; styles.hl inherits it: accent green-dark, type colours 1-6; own base/header rules, row lines, genre-pill and inverted-button frames removed, the season foldable keeps its line; check-theme 21 -> 0, 4th deploy gate; main actions class primary) and the #32 header (theme AppHeader/MainMenu/UserMenu/Sidebar/ContentFirst: desktop brand, search, Series|Shows|Movies|Genres|People, user icon with Unwatched..Settings, Logout; signed out the ident selector, phone the iD icon dropdown; phone menu in the sidebar overlay; marked entry by :has); /find -> /search/<q>, /genres, /people(/<letter>), /settings; main { ContentFirst { slot } } works around the hl:web one-line slot bug; gates 365/0, 32/0, 52/0, check-theme 0mre
  • a386dc92tracker: reports 029 + 030mre
  • 71e0fd7dtracker missions 029 + 030: README (What it does, Files, gate count), STATUS (real-copy numbers, how to repeat, open points), LOGmre
  • d36ea6eatracker#34 + #35 (mission 030): Follow directly under the poster, as wide as the poster (show.hl, styles.hl); the status pill next to a series' title — TVmaze's status (new tvmazeStatus, stored by the sync's TVmaze merge) else TMDB's, TVmaze Ended + TMDB Canceled = Canceled, inverted (filled, dark text, no border), green running / yellow pending / red canceled / muted ended (shows.hl statusOf); the daily delta asks TVmaze's status of an unfollowed series TVmaze's change list names (dailysync.hl syncRunStep, sync.hl syncTvmazeStatus); the status backfill after the details repair (backfill.hl, jobs.hl statusTick; resumable, 550 ms per TVmaze request); gates 354/0, 32/0, 52/0mre
  • 7d7d4487tracker#33 (mission 029): reduced titles — every title TMDB's details never went through this app (no detailsAt, no tmdbSync) is incomplete (shows.hl isIncomplete; the old tracker's migrated rows passed #26's test: 5,697 non-adult on the live copy, 691 series without seasons); the repair job does the visibly reduced first (shows.hl missingParts), the page completes one on open; a title TMDB has no poster for (The Remaining) shows the placeholder; tools/count-incomplete.hl; gate fixtures stand for synced titles (tmdbSync), tests/seed-reduced.hl + #33 checks; gates 347/0, 32/0, 52/0mre
  • 661c2592tracker: report 028mre
  • 27c916fatracker mission 028: README ("Code order", the new file map), STATUS (counts before/after, tests, how to repeat, open), LOGmre
  • d924f398tracker mission 028: comments name the new files (sync.hl, dailysync.hl, backfill.hl, credits.hl, jobs.hl, images.hl …); tools/ref-params.py + tools/lambda-audit.py also scan lib/ (they globbed the root only), lambda-audit counts a plain `x = p` alias like `let x = p`mre
  • 2e89b968tracker mission 028 (code order) 5/5 let: `let` only where a variable is reassigned — 667 never-reassigned lets became plain declarations (project.hl, lib/, components/, tools/, tests/); kept: 264 in loop bodies (a plain declaration there is 'Cannot reassign' on the 2nd pass), 234 reassigned, 27 whose name is also a member/outer/free name (a plain write would rebind it); tools/let-audit.py decides and fixes (README 'Code order'); tests/realdata-m028.{sh,mjs} = the page-output diff on a real copy; gates 342/0, 32/0, 52/0, real-copy pages identicalmre
  • 54796ff2tracker mission 028 (code order) 4/5 thin faces + last copies: the show page's check/follow faces call lib/watches.hl toggleWatched / toggleSeasonWatched (seasonAllWatched moved there) and lib/follows.hl toggleFollowed; both logins (header selector face, /login/callback) share lib/users.hl userOfCode; todayStr/listOf copies in components and the export readers copied into tools/migrate.hl + tools/old-short-ids.hl now once (lib/util.hl, lib/export.hl); gates 342/0, 32/0, 52/0; old-short-ids output byte-identical, migrate output identicalmre
  • 06b078e3tracker mission 028 (code order) 3/5 project.hl is the map: config, routes, wiring and a feature → file index (914 → 258 lines); the background jobs (daily sync run, backfills, details repair, credits job, merge, short ids, collection seed) moved unchanged into lib/jobs.hl (a class: their state is reassigned every step, a static cannot be; one instance made after the server), the login callback into lib/users.hl, poster/photo serving into lib/images.hl, the /shows/<slug> rule into lib/shows.hl showsMovedPath; route handlers are thin wrappers; gates 342/0, 32/0, 52/0, real-copy pages identicalmre
  • 94716fd2tracker mission 028 (code order) 2/5 util + topics: lib/util.hl holds envOr, storageDir, postersDir, profilesDir, newId, hexDigits, todayStr, dateOr, textOr, hasId, listOr, firstOf, sortDesc once (were copied into up to 5 files); tmdbsync.hl split into tmdb.hl (TMDB/TVmaze requests), sync.hl (one title's sync), sync-helpers.hl, backfill.hl; details.hl split into details.hl, credits.hl, credits-helpers.hl (isIncomplete to shows.hl); search-helpers.hl (words, query, ranking, slugs); collections.hl (the TMDB collection seed, out of franchises.hl); deltasync.hl renamed dailysync.hl; no behaviour change: gates 342/0, 32/0, 52/0, real-copy pages identicalmre
  • 186079b0tracker mission 028 (code order) 1/5 move: every root .hl except project.hl into lib/ (styles.hl into components/), import paths only; gates 342/0, 32/0, 52/0; real-copy pages identicalmre
  • 4f47f181tracker: report 027mre
  • dc1d4be4tracker mission 027: Hybriel master 06617221 vendored (plugin allocator fixes 3a781359 + 413f60e4); real copy RSS through first-start jobs + 400 loads flat ~2.55 GB (190aa11d 2.3 -> 5.6 GB), page times <= 1.1x; gates 342/0, 32/0, 52/0mre
  • 84e1b3e1tracker: reports 025 + 026mre
  • dc40d859tracker#31 (mission 026): duplicate titles merged — the 68 type+tmdbId pairs held by 157 records were the old tracker's (all migrated); merge.hl repair job (own clock, before the TMDB jobs) keeps one keeper per title (follows/watches > old short id > oldest), moves follows, watches, seasons, cast, credits, timelines, tombstones the rest (mergedInto, never deleted), slugs + short ids 301 to the keeper; stray seasons merged into their listed twin (Reacher S3 watches) or linked when watched; search import re-checks before its put; deploy.sh waits up to 90 s for 200; real copy 68 -> 0 dup ids, az5b2 follows/watches equal; gates 342/0, 32/0, 52/0mre
  • 2667da05tracker#30 (mission 025): /my/ pages from slim cached title cards, episode rows and watch sets (after the jobs /my/series 1.8 s -> 0.06 s, /my/unwatched 4.1 -> 0.18 s); timeline page shows its name once; franchise widget under the poster/title; movies with TV leftovers (First Contact) go through the details repair; tools/count-tmdb-ids.hl; gates 327/0, 52/0, 32/0mre