gitoriaLog in with ident

tracker

All repositories: gitoria

ReadmeCodePull requestsReleasesTicketsSettings
Commiteb3b9205eb3b9205tracker: report 031mreeb3b9205/reports/007-tracker-home-lists.md

5.1 KB

  1. # w050 — tracker.worldapi.org#13: homepage, /movies, /shows, /my/movies
  2. **Files** (loreana:/media/STORAGE/projects/tracker.worldapi.org, no git):
  3. - New: `catalog.hl`, `components/movies.hl`, `components/allshows.hl`, `components/tilelist.hl`, `components/mymovies.hl`, `components/pagination.hl` (copied verbatim from components.hybriel 4b4dabe)
  4. - Changed: `components/home.hl`, `components/myshows.hl` (series only), `follows.hl` (`insertByFollowDesc` moved here), `shows.hl` (`allShows`/`allEpisodes`), `project.hl` (routes + `refreshCatalogShow` in `syncTick`), `styles.hl`, `tests/browser.mjs`, `tests/seed-show.hl`, `tests/realdata-check.mjs`, README.md ("What it does (step 13)", Test, Files), STATUS.md (new top entry)
  5. **Decisions**
  6. - **The page number is in the path (`/movies/page/2`, page 1 = `/movies`), not `?page=2`.** I changed this from the mission. A page component can't read the query string (hybriel#11, the query half is still open). hl:web's Back (`popstate` → `show(location.pathname)`) also drops the query. With `?page=N`, every page change would be a full reload and Back would land on page 1. With the path, paging is client-side (60–75 ms) and Back works.
  7. - **Pagination is copied verbatim and not edited.** It has no data out (hybriel#87), so `tilelist.hl` wraps it in `pager-box { on click }`. That handler reads the clicked button's text and calls `navigate()`. With only one page, no pagination is shown.
  8. - **The lists are built once at server start** (`catalog.hl`: one scan of shows + episodes, about 1 s on real data). A request only slices 24 ids. They are refreshed per synced show in the daily run and on the first read of a new day (upcoming release dates are kept per series).
  9. - **What the lists contain:**
  10. - `/movies` has all movies, including future-dated ones (first) and undated ones (last).
  11. - The homepage row shows only released movies.
  12. - In `/shows`, series with no released episode come last, ordered by their own release date.
  13. - **`/my/shows` is now series only**; movies are on `/my/movies`.
  14. - **Home text:** it says episodes come from TMDB, because TVmaze is only used for ids. The sign-in hint shows only when signed out.
  15. **Gate:** `TRACKER_GATE_SHOTS=/tmp/w050/shots TRACKER_GATE_PORT=8720 TRACKER_GATE_IDENT_PORT=8721 TRACKER_GATE_CHROME=8722-8726 TRACKER_GATE_TMDB_PORT=8727 node tests/browser.mjs` → last line `135 passed, 0 failed` (was 111).
  16. - I changed some existing checks: the three "page stays empty" checks now check the homepage content.
  17. - The in-app run now expects `newEpisodes=2`, because the fake TMDB also adds a released episode. That proves the re-sort happens without a restart.
  18. **Duplicate rows from the session sync** (the team lead's heads-up about hybriel 64527baa):
  19. - I checked every face that takes `session`: `showRows`, `showToggleEpisode`, `showToggleSeason`, `showToggleFollow`, `unwatchedToggle`, `trackerLogin` and `trackerLogOut`.
  20. - None of the client handlers appends a returned row. Each one assigns the whole list (`rows = r.rows`) or a flag. The new #13 pages have no faces.
  21. - I added 4 gate checks that each row appears exactly once. Each waits 400 ms after the action, then checks the exact row count and that the button values are unique. They cover the /my/unwatched click, expanding a season, an episode click and the Follow toggles.
  22. **Real-data load times** (copy, deleted afterwards). Server time is 5–7 ms per page. Each page was loaded in a fresh Chrome (document, modules, socket, posters in view), signed in / signed out:
  23. | page | 390 px in / out | 1280 px in / out |
  24. |---|---|---|
  25. | `/` | 1.11 / 1.34 s | 1.13 / 1.29 s |
  26. | `/movies` | 0.30 / 0.91 s | 0.57 / 0.57 s |
  27. | `/movies/page/2` | 0.53 / 0.63 s | 1.31 / 0.50 s |
  28. | `/shows` | 1.07 / 1.36 s | 1.37 / 1.11 s |
  29. | `/my/movies` | 0.80 / 0.66 s | 0.83 / 0.58 s |
  30. All are under 1.5 s. Server boot to first answer: 1.47 s. Refreshing the lists for all 126 followed shows takes 0.31 s.
  31. **Screenshots** (Loreana; I looked at them):
  32. - `/tmp/w050/shots/{home,movies,movies-page-2,shows-list,my-movies}-{390,1280}.png` (gate)
  33. - `/tmp/w050/real/*-{390,1280}.png` (real data, including `movies-page-4-bottom-*` with the pagination)
  34. - `/tmp/w050/pager-390.png`
  35. **Open points**
  36. 1. **Adult titles.** The migrated movie table holds many porn titles (e.g. "Pervy Doctor 8" on /movies page 1, more on page 4). They now show on the public `/` and `/movies`. No adult flag is stored; the creator or architect has to decide (filter by TMDB `adult`, or list only followed movies, …).
  37. 2. Almost every movie tile shows the placeholder poster, because only followed shows have poster files.
  38. 3. A real-phone check is still needed after deploy.
  39. 4. Seen, not changed: `/my/unwatched` takes 1.5–1.6 s on real data (1,594 rows).
  40. **Hybriel issues**
  41. - **New:** hl:web `client.hl:2795` `popstate` calls `show(location.pathname, false)` and drops `location.search`. Back to a URL with a query loses the query (`arrive()` and `goTo` keep it).
  42. - **Known:** #11 (a component cannot read the query) and #87 (no data out from a composed component) — both worked around as described above.
  43. - A `static` cannot be reassigned ("Cannot reassign immutable variable"), but its fields can be mutated across modules. `catalog.hl` uses field writes; this is probably by design.

Branches

Latest commits

  • eb3b9205tracker: report 031mre
  • 9b5d2e89tracker mission 031: README (What it does, Test: four gates + the #32 checks, Files: theme/, new pages), STATUS (real copy, A/B load, how to repeat, open points), LOGmre
  • 39950e4ctracker#32 (mission 031): the WorldAPI theme (theme/ vendored verbatim from layouts.worldapi.org 85b5654; styles.hl inherits it: accent green-dark, type colours 1-6; own base/header rules, row lines, genre-pill and inverted-button frames removed, the season foldable keeps its line; check-theme 21 -> 0, 4th deploy gate; main actions class primary) and the #32 header (theme AppHeader/MainMenu/UserMenu/Sidebar/ContentFirst: desktop brand, search, Series|Shows|Movies|Genres|People, user icon with Unwatched..Settings, Logout; signed out the ident selector, phone the iD icon dropdown; phone menu in the sidebar overlay; marked entry by :has); /find -> /search/<q>, /genres, /people(/<letter>), /settings; main { ContentFirst { slot } } works around the hl:web one-line slot bug; gates 365/0, 32/0, 52/0, check-theme 0mre
  • a386dc92tracker: reports 029 + 030mre
  • 71e0fd7dtracker missions 029 + 030: README (What it does, Files, gate count), STATUS (real-copy numbers, how to repeat, open points), LOGmre
  • d36ea6eatracker#34 + #35 (mission 030): Follow directly under the poster, as wide as the poster (show.hl, styles.hl); the status pill next to a series' title — TVmaze's status (new tvmazeStatus, stored by the sync's TVmaze merge) else TMDB's, TVmaze Ended + TMDB Canceled = Canceled, inverted (filled, dark text, no border), green running / yellow pending / red canceled / muted ended (shows.hl statusOf); the daily delta asks TVmaze's status of an unfollowed series TVmaze's change list names (dailysync.hl syncRunStep, sync.hl syncTvmazeStatus); the status backfill after the details repair (backfill.hl, jobs.hl statusTick; resumable, 550 ms per TVmaze request); gates 354/0, 32/0, 52/0mre
  • 7d7d4487tracker#33 (mission 029): reduced titles — every title TMDB's details never went through this app (no detailsAt, no tmdbSync) is incomplete (shows.hl isIncomplete; the old tracker's migrated rows passed #26's test: 5,697 non-adult on the live copy, 691 series without seasons); the repair job does the visibly reduced first (shows.hl missingParts), the page completes one on open; a title TMDB has no poster for (The Remaining) shows the placeholder; tools/count-incomplete.hl; gate fixtures stand for synced titles (tmdbSync), tests/seed-reduced.hl + #33 checks; gates 347/0, 32/0, 52/0mre
  • 661c2592tracker: report 028mre
  • 27c916fatracker mission 028: README ("Code order", the new file map), STATUS (counts before/after, tests, how to repeat, open), LOGmre
  • d924f398tracker mission 028: comments name the new files (sync.hl, dailysync.hl, backfill.hl, credits.hl, jobs.hl, images.hl …); tools/ref-params.py + tools/lambda-audit.py also scan lib/ (they globbed the root only), lambda-audit counts a plain `x = p` alias like `let x = p`mre
  • 2e89b968tracker mission 028 (code order) 5/5 let: `let` only where a variable is reassigned — 667 never-reassigned lets became plain declarations (project.hl, lib/, components/, tools/, tests/); kept: 264 in loop bodies (a plain declaration there is 'Cannot reassign' on the 2nd pass), 234 reassigned, 27 whose name is also a member/outer/free name (a plain write would rebind it); tools/let-audit.py decides and fixes (README 'Code order'); tests/realdata-m028.{sh,mjs} = the page-output diff on a real copy; gates 342/0, 32/0, 52/0, real-copy pages identicalmre
  • 54796ff2tracker mission 028 (code order) 4/5 thin faces + last copies: the show page's check/follow faces call lib/watches.hl toggleWatched / toggleSeasonWatched (seasonAllWatched moved there) and lib/follows.hl toggleFollowed; both logins (header selector face, /login/callback) share lib/users.hl userOfCode; todayStr/listOf copies in components and the export readers copied into tools/migrate.hl + tools/old-short-ids.hl now once (lib/util.hl, lib/export.hl); gates 342/0, 32/0, 52/0; old-short-ids output byte-identical, migrate output identicalmre
  • 06b078e3tracker mission 028 (code order) 3/5 project.hl is the map: config, routes, wiring and a feature → file index (914 → 258 lines); the background jobs (daily sync run, backfills, details repair, credits job, merge, short ids, collection seed) moved unchanged into lib/jobs.hl (a class: their state is reassigned every step, a static cannot be; one instance made after the server), the login callback into lib/users.hl, poster/photo serving into lib/images.hl, the /shows/<slug> rule into lib/shows.hl showsMovedPath; route handlers are thin wrappers; gates 342/0, 32/0, 52/0, real-copy pages identicalmre
  • 94716fd2tracker mission 028 (code order) 2/5 util + topics: lib/util.hl holds envOr, storageDir, postersDir, profilesDir, newId, hexDigits, todayStr, dateOr, textOr, hasId, listOr, firstOf, sortDesc once (were copied into up to 5 files); tmdbsync.hl split into tmdb.hl (TMDB/TVmaze requests), sync.hl (one title's sync), sync-helpers.hl, backfill.hl; details.hl split into details.hl, credits.hl, credits-helpers.hl (isIncomplete to shows.hl); search-helpers.hl (words, query, ranking, slugs); collections.hl (the TMDB collection seed, out of franchises.hl); deltasync.hl renamed dailysync.hl; no behaviour change: gates 342/0, 32/0, 52/0, real-copy pages identicalmre
  • 186079b0tracker mission 028 (code order) 1/5 move: every root .hl except project.hl into lib/ (styles.hl into components/), import paths only; gates 342/0, 32/0, 52/0; real-copy pages identicalmre
  • 4f47f181tracker: report 027mre
  • dc1d4be4tracker mission 027: Hybriel master 06617221 vendored (plugin allocator fixes 3a781359 + 413f60e4); real copy RSS through first-start jobs + 400 loads flat ~2.55 GB (190aa11d 2.3 -> 5.6 GB), page times <= 1.1x; gates 342/0, 32/0, 52/0mre
  • 84e1b3e1tracker: reports 025 + 026mre
  • dc40d859tracker#31 (mission 026): duplicate titles merged — the 68 type+tmdbId pairs held by 157 records were the old tracker's (all migrated); merge.hl repair job (own clock, before the TMDB jobs) keeps one keeper per title (follows/watches > old short id > oldest), moves follows, watches, seasons, cast, credits, timelines, tombstones the rest (mergedInto, never deleted), slugs + short ids 301 to the keeper; stray seasons merged into their listed twin (Reacher S3 watches) or linked when watched; search import re-checks before its put; deploy.sh waits up to 90 s for 200; real copy 68 -> 0 dup ids, az5b2 follows/watches equal; gates 342/0, 32/0, 52/0mre
  • 2667da05tracker#30 (mission 025): /my/ pages from slim cached title cards, episode rows and watch sets (after the jobs /my/series 1.8 s -> 0.06 s, /my/unwatched 4.1 -> 0.18 s); timeline page shows its name once; franchise widget under the poster/title; movies with TV leftovers (First Contact) go through the details repair; tools/count-tmdb-ids.hl; gates 327/0, 52/0, 32/0mre