tracker

4.1 KB

1. # Report 028 (w078) — tracker: code order (no behaviour change) — DONE on main
3. **Commits** on main in loreana:/media/STORAGE/projects/tracker.worldapi.org (parent 4f47f18, fast-forward): `186079b` 1/5 move ·
4. `94716fd` 2/5 util + topics · `06b078e` 3/5 project.hl = the map · `54796ff` 4/5 thin faces + last copies · `2e89b96` 5/5 let ·
5. `d924f39` comments + audit tools · `27c916f` README/STATUS/LOG. Not pushed, not deployed. No `.env` read (the real-jobs run linked it for the runtime, as in mission 027; link removed). Every process killed by
6. PID; 8720–8731 free; real-copy data deleted.
8. ## Before → after
9. | | before (4f47f18) | after |
10. |---|---|---|
11. | `.hl` files in the root | 15 | 1 (`project.hl`) |
12. | `project.hl` lines | 914 | 261 |
13. | `let` (code, all .hl) | 1,211; 706 never reassigned (676 convertible + 30 name clashes) | 525 = 264 in loop bodies + 234 reassigned + 27 kept for a name clash; 667 converted |
15. ## File map (README "Files" has every file)
16. - `project.hl` — config, every route, thin function routes, push audiences, boot wiring, `jobs = new Jobs()`, a feature → file index on top.
17. - `lib/`: `util` (envOr, storageDir, postersDir, profilesDir, newId, hexDigits, todayStr, dateOr, textOr, hasId, listOr, firstOf,
18. sortDesc — each once), `users` (+ /login/callback logic, `userOfCode` for both logins), `shows` (+ `isIncomplete`,
19. `showsMovedPath`), `follows` (+ `toggleFollowed`), `watches` (+ `toggleWatched`, `toggleSeasonWatched`), `catalog`,
20. `search` + `search-helpers`, `people`, `credits` + `credits-helpers` (out of details), `details`, `tmdb` (requests, out of
21. tmdbsync), `sync` + `sync-helpers` (one title), `dailysync` (was deltasync), `backfill` (adult + kind), `shortids`,
22. `franchises`, `collections` (the seed, out of franchises), `merge`, `jobs` (all background runners + clocks), `images`
23. (posters/photos), `export` (the tools' mongo-export readers).
24. - `components/styles.hl` (was `styles.hl`); `tools/let-audit.py`; `tests/realdata-m028.{sh,mjs}`.
26. ## Decisions
27. - `lib/jobs.hl` is a CLASS with one instance (`jobs = new Jobs()` after the server): the runners' state is reassigned every step,
28. a static cannot be (measured: "Cannot reassign immutable variable"); the code moved unchanged, log order unchanged.
29. - `let` kept inside loop bodies (a plain declaration there fails on the 2nd pass — measured), and where the name is also a
30. member/import/outer/free name (a plain `x = …` inside a function REBINDS a file member — measured) or used outside its block
31. (the browser target emits a plain declaration as block-scoped JS `let`). Plain declarations copy like `let` (measured).
32. - Faces/routes made thin where the logic was the topic's: show page check/follow toggles, both logins, posters/photos, /shows/<slug>.
34. ## Tests
35. - Gates after every step and on the final tree: `TRACKER_GATE_PORT=8720 … TRACKER_GATE_CHROME=8722-8726 TRACKER_GATE_TMDB_PORT=8727`
36. → browser **342 passed, 0 failed**, kinds **32/0**, franchises **52/0** (outputs `.scratch/w078/gate-*.txt`, shots `/tmp/m028/`, looked at).
37. - Real copy (live storage, signed in as az5b2, all jobs off, no `.env`): 24 pages (/, lists, franchises, 2 series, a show, 2
38. movies, 2 persons, genre, search, all /my/*, not-found pages) + 10 redirects/404s, 2 runs per tree: **normalized HTML and the
39. hydrated page text identical to 4f47f18 (49/49 files)**. Browser full load 2×10 per page: sum 7,358 → 7,258 ms (0.99×), boot
40. 48–51 s and 2,216 MB both; client modules +0.9 %.
41. - Real jobs on the copy (final tree, forced delta run): sync 345 titles errors=0, repair 24/24, collections 17/17, others nothing
42. to do; RSS max 2.49 GB.
43. - Tools old vs new: old-short-ids byte-identical, migrate + verify identical, 7 count tools identical.
45. ## Open
46. - Deploy: rsync has no `--delete` → the 14 old root `.hl` stay on Byrodin (unused); delete them by hand after deploying.
47. - The search import face still stores the credits itself (search.hl → credits.hl would be an import cycle).
48. - Long topic files left as they are: merge.hl 599, sync.hl 446, franchises.hl 445, people.hl 404 lines.
49. - tools/lambda-audit.py now also lists 2 harmless reassignments (`fid = franchiseId`, `inShow = showId`) besides the 13 before.