gitoriaLog in with ident

tracker

All repositories: gitoria

ReadmeCodePull requestsReleasesTicketsSettings
Commitb10f00c8b10f00c8tracker#39: double episodes — migrated episodes whose TMDB id TMDB replaced are adopted by their number in the sync (old id -> migratedTmdbId); merge.hl step 3 merges each season's doubles at start (keeper: most watches > synced > first; watches moved/parked; tombstones into mergedEpisodes, nothing deleted); tools/count-duplicate-episodes.hl; gate fixture + paths-m039; live copy 850 -> 0 in 64 s; gates 373/0, 32/0, 52/0mreb10f00c8/reports/008-tracker-search-tvmaze-search.md

4.6 KB

  1. # w052-search — tracker#14 (search), mission 008 (old 052)
  2. **Branch** `t14-search` in loreana:/media/STORAGE/projects/tracker-wt14 (not pushed, not merged)
  3. - `65c694a` tracker#14: search — header magnifier, /search/<text>, in-memory index, Fetch from web, Add = import via syncShow; gate +25, real-data script
  4. - `b8bd115` tracker#14: README + STATUS
  5. **Built**: `search.hl` (new: index, `queryOfParam`, TMDB `webSearch`, `importTitle`), `components/search.hl` (new page),
  6. `components/main.hl` (magnifier in the header), `project.hl` (route `/search/:q?`, index built at boot), `styles.hl`
  7. (one block), `tests/browser.mjs` + `tests/faketmdb.mjs` (fake `search/multi`, import fixtures), `tests/realdata-search.mjs` (new).
  8. **Decisions**
  9. - Address `/search/<text>`, NOT `/search?q=`: hl:web gives a page route params but no query string. `/search?q=x` opens the empty page.
  10. - Index: every title/name → normalised words (case, apostrophes, punctuation, Latin accents; title year as a word); buckets
  11. keyed by each word's first 2 and 3 letters; a query reads ONE bucket. Min 2 letters; at most 30 titles + 10 people.
  12. - Web: one TMDB `search/multi` per "Fetch from web" click (not per keystroke); people dropped; titles we have (TMDB id + kind) left out.
  13. - Import: one `/tv|movie/<id>` details request → new record (own 16-hex id, `oldId tmdb-tv-<id>`, slug like migrated ones,
  14. genres matched by name) → `syncShow` (seasons, episodes, poster, ids) → index updated → its page opens. Not auto-followed.
  15. - Signed out: search and web work; "Add" opens the sign-in modal and sends nothing.
  16. **Gate**: `TRACKER_GATE_SHOTS=/tmp/w052-t14/shots TRACKER_GATE_PORT=8773 TRACKER_GATE_IDENT_PORT=8774 TRACKER_GATE_CHROME=8776-8778 TRACKER_GATE_TMDB_PORT=8779 node tests/browser.mjs`
  17. → `136 passed, 0 failed` (111 + 25). Includes the hybriel#121/#122 check: a failed import, which is a session face that
  18. stays on the page, leaves the DB list, the web list, the field and the `data-for` unchanged, with no row twice.
  19. **Real data** (copy of the live storage, deleted afterwards; real TMDB; az5b2):
  20. - Index build at boot: 0.60 s (9453 titles, 15157 people, 4180 keys).
  21. - `dbSearch` time: 0–1 ms for typical queries, 38–44 ms for "the"/"th".
  22. - Server render: `/search/doctor%20who` 9 ms, `/search/the` 56 ms.
  23. - Browser, keystroke → results + address: 56–76 ms.
  24. - `/search` page load: 0.85 s cold, 0.04 s warm.
  25. - Fetch from web: 0.12–0.23 s.
  26. - Import of "Pluribus" (tv 225171): 0.77–1.1 s. Season 1 with 9 episodes, poster, 4 id links, genres. Afterwards it is in
  27. the DB results and gone from the web list. 0 console problems.
  28. **Screenshots** (Loreana, looked at): `/tmp/w052-t14/shots/search{,-web}-{390,1280}.png`, `search-signed-out-modal-1280.png`
  29. (+ all existing gate shots); real data `/tmp/w052-t14/real/search-*.png`, `imported-show-1280.png`. Note: the #15 worker
  30. also writes to `/tmp/w052/real/`; my first run's search PNGs landed there too before I moved mine to `/tmp/w052-t14/`.
  31. **Merge notes** (files #13 likely touches too):
  32. - `project.hl`: imports, the `/search/:q?` route, `searchIndexReady = ensureIndex()` before `server`.
  33. - `components/main.hl`: the magnifier inside `userBox`.
  34. - `styles.hl`: one block before the `@media` block.
  35. - `tests/browser.mjs`:
  36. - fixtures at the top;
  37. - a signed-out block before the "#3 borders" checks;
  38. - `search` added to the 390/1280 page list;
  39. - a signed-in block before "#10 THE INSTALLABLE APP".
  40. - `tests/faketmdb.mjs`: search and thumbnail requests are recorded separately, so the existing request-count checks are untouched.
  41. - README: intro, new section, Test block (the count line changed to 136), Files.
  42. - STATUS: a new section on top.
  43. **Open**
  44. - No person page: `/person/<slug>` gives a 404, like the existing cast links.
  45. - Imported titles are not followed, so the daily sync never refreshes them. Architect's call.
  46. - Web search is open to signed-out visitors, with no rate limit of our own.
  47. - Autofocus is proven on a full load only.
  48. - Real-phone test after deploy.
  49. **Hybriel findings** (no blockers; worth adding to the worker guide):
  50. 1. A module `static x = f()` is evaluated lazily: never, if nothing reads `x`. Work around it with an explicit `ensure…()` call from a `project.hl` member.
  51. 2. The server percent-decodes the path before routing: `%2F` gives a 404, and invalid UTF-8 (`%E0%80`) reaches the page as raw bytes. A client-side navigation hands the param still encoded, which is inconsistent. The page therefore writes `/ ? #` into the address as spaces.
  52. 3. A record literal entry `id = …` shadows a local `id` for the later entries (already documented for `show`; I hit it again with `tmdbId = id`).
  53. 4. Pages get no query string (`?q=`), only route params.

Branches

Latest commits

  • b10f00c8tracker#39: double episodes — migrated episodes whose TMDB id TMDB replaced are adopted by their number in the sync (old id -> migratedTmdbId); merge.hl step 3 merges each season's doubles at start (keeper: most watches > synced > first; watches moved/parked; tombstones into mergedEpisodes, nothing deleted); tools/count-duplicate-episodes.hl; gate fixture + paths-m039; live copy 850 -> 0 in 64 s; gates 373/0, 32/0, 52/0mre
  • 8751adb8tracker: report 032mre
  • 9bce1f65tracker mission 032: STATUS gate files + the hour-boundary flakemre
  • 718bfb89tracker#37 (mission 032): /people = everyone, last updated first (updatedAt stamped by the person fill; view built at boot, touched people first at once), photo + name tiles (person colour) with the /movies pagination, /people/<letter> removed; photo = our file, tmdbProfile, a cast/crew entry's profile (in-memory map at boot), else the new 'no photo' placeholder; new cast/crew/created_by people keep tmdbProfile; search people rows with the photo; /settings = the heading only; util.hl sortDesc starts from sorted runs (same result, 105k: 1.6 s -> 0.15 s); gates 369/0, 32/0, 52/0, check-theme 0; README/STATUS/LOGmre
  • 96ba683adeploy.sh: a gate without a 'passed,' line (check-theme) no longer ends the scriptmre
  • eb3b9205tracker: report 031mre
  • 9b5d2e89tracker mission 031: README (What it does, Test: four gates + the #32 checks, Files: theme/, new pages), STATUS (real copy, A/B load, how to repeat, open points), LOGmre
  • 39950e4ctracker#32 (mission 031): the WorldAPI theme (theme/ vendored verbatim from layouts.worldapi.org 85b5654; styles.hl inherits it: accent green-dark, type colours 1-6; own base/header rules, row lines, genre-pill and inverted-button frames removed, the season foldable keeps its line; check-theme 21 -> 0, 4th deploy gate; main actions class primary) and the #32 header (theme AppHeader/MainMenu/UserMenu/Sidebar/ContentFirst: desktop brand, search, Series|Shows|Movies|Genres|People, user icon with Unwatched..Settings, Logout; signed out the ident selector, phone the iD icon dropdown; phone menu in the sidebar overlay; marked entry by :has); /find -> /search/<q>, /genres, /people(/<letter>), /settings; main { ContentFirst { slot } } works around the hl:web one-line slot bug; gates 365/0, 32/0, 52/0, check-theme 0mre
  • a386dc92tracker: reports 029 + 030mre
  • 71e0fd7dtracker missions 029 + 030: README (What it does, Files, gate count), STATUS (real-copy numbers, how to repeat, open points), LOGmre
  • d36ea6eatracker#34 + #35 (mission 030): Follow directly under the poster, as wide as the poster (show.hl, styles.hl); the status pill next to a series' title — TVmaze's status (new tvmazeStatus, stored by the sync's TVmaze merge) else TMDB's, TVmaze Ended + TMDB Canceled = Canceled, inverted (filled, dark text, no border), green running / yellow pending / red canceled / muted ended (shows.hl statusOf); the daily delta asks TVmaze's status of an unfollowed series TVmaze's change list names (dailysync.hl syncRunStep, sync.hl syncTvmazeStatus); the status backfill after the details repair (backfill.hl, jobs.hl statusTick; resumable, 550 ms per TVmaze request); gates 354/0, 32/0, 52/0mre
  • 7d7d4487tracker#33 (mission 029): reduced titles — every title TMDB's details never went through this app (no detailsAt, no tmdbSync) is incomplete (shows.hl isIncomplete; the old tracker's migrated rows passed #26's test: 5,697 non-adult on the live copy, 691 series without seasons); the repair job does the visibly reduced first (shows.hl missingParts), the page completes one on open; a title TMDB has no poster for (The Remaining) shows the placeholder; tools/count-incomplete.hl; gate fixtures stand for synced titles (tmdbSync), tests/seed-reduced.hl + #33 checks; gates 347/0, 32/0, 52/0mre
  • 661c2592tracker: report 028mre
  • 27c916fatracker mission 028: README ("Code order", the new file map), STATUS (counts before/after, tests, how to repeat, open), LOGmre
  • d924f398tracker mission 028: comments name the new files (sync.hl, dailysync.hl, backfill.hl, credits.hl, jobs.hl, images.hl …); tools/ref-params.py + tools/lambda-audit.py also scan lib/ (they globbed the root only), lambda-audit counts a plain `x = p` alias like `let x = p`mre
  • 2e89b968tracker mission 028 (code order) 5/5 let: `let` only where a variable is reassigned — 667 never-reassigned lets became plain declarations (project.hl, lib/, components/, tools/, tests/); kept: 264 in loop bodies (a plain declaration there is 'Cannot reassign' on the 2nd pass), 234 reassigned, 27 whose name is also a member/outer/free name (a plain write would rebind it); tools/let-audit.py decides and fixes (README 'Code order'); tests/realdata-m028.{sh,mjs} = the page-output diff on a real copy; gates 342/0, 32/0, 52/0, real-copy pages identicalmre
  • 54796ff2tracker mission 028 (code order) 4/5 thin faces + last copies: the show page's check/follow faces call lib/watches.hl toggleWatched / toggleSeasonWatched (seasonAllWatched moved there) and lib/follows.hl toggleFollowed; both logins (header selector face, /login/callback) share lib/users.hl userOfCode; todayStr/listOf copies in components and the export readers copied into tools/migrate.hl + tools/old-short-ids.hl now once (lib/util.hl, lib/export.hl); gates 342/0, 32/0, 52/0; old-short-ids output byte-identical, migrate output identicalmre
  • 06b078e3tracker mission 028 (code order) 3/5 project.hl is the map: config, routes, wiring and a feature → file index (914 → 258 lines); the background jobs (daily sync run, backfills, details repair, credits job, merge, short ids, collection seed) moved unchanged into lib/jobs.hl (a class: their state is reassigned every step, a static cannot be; one instance made after the server), the login callback into lib/users.hl, poster/photo serving into lib/images.hl, the /shows/<slug> rule into lib/shows.hl showsMovedPath; route handlers are thin wrappers; gates 342/0, 32/0, 52/0, real-copy pages identicalmre
  • 94716fd2tracker mission 028 (code order) 2/5 util + topics: lib/util.hl holds envOr, storageDir, postersDir, profilesDir, newId, hexDigits, todayStr, dateOr, textOr, hasId, listOr, firstOf, sortDesc once (were copied into up to 5 files); tmdbsync.hl split into tmdb.hl (TMDB/TVmaze requests), sync.hl (one title's sync), sync-helpers.hl, backfill.hl; details.hl split into details.hl, credits.hl, credits-helpers.hl (isIncomplete to shows.hl); search-helpers.hl (words, query, ranking, slugs); collections.hl (the TMDB collection seed, out of franchises.hl); deltasync.hl renamed dailysync.hl; no behaviour change: gates 342/0, 32/0, 52/0, real-copy pages identicalmre
  • 186079b0tracker mission 028 (code order) 1/5 move: every root .hl except project.hl into lib/ (styles.hl into components/), import paths only; gates 342/0, 32/0, 52/0; real-copy pages identicalmre