gitoriaLog in with ident

tracker

All repositories: gitoria

ReadmeCodePull requestsReleasesTicketsSettings
Commitb10f00c8b10f00c8tracker#39: double episodes — migrated episodes whose TMDB id TMDB replaced are adopted by their number in the sync (old id -> migratedTmdbId); merge.hl step 3 merges each season's doubles at start (keeper: most watches > synced > first; watches moved/parked; tombstones into mergedEpisodes, nothing deleted); tools/count-duplicate-episodes.hl; gate fixture + paths-m039; live copy 850 -> 0 in 64 s; gates 373/0, 32/0, 52/0mreb10f00c8/components/modal.hl

7.2 KB

  1. // modal.hl — THE MODAL DIALOG, pure Hybriel (no JavaScript file): a window over the page with a title, a × and any content; the
  2. // page behind is dimmed, blocked (inert) and does not scroll. `Modal { id = "confirm" title = "Delete it?" p { "…" } }`.
  3. // Built on the browser's own `<dialog>` opened with `showModal()`: the browser makes the page behind inert, puts the focus
  4. // inside and gives it back to the opener when it closes. This file adds what the browser leaves open: Tab / Shift+Tab wrap
  5. // inside the window, Esc, a click on the dim background (switchable: `backdropClose = "false"`), footer buttons, no scrolling
  6. // behind, and ONE close signal with the reason: a bubbling `close` event on `<modal-dialog>` (hl:web binds standard DOM event names
  7. // only, ticket #31), `e.detail.reason` =
  8. // "close" (×), "escape", "backdrop", a footer button's `value` (or its text), or what the host passed to `close(reason)`.
  9. // The host opens and closes it by the dialog's id: `document.getElementById('confirm').showModal()` / `.close('saved')`.
  10. // Several modals may stand on one page: every member is assigned a literal per reference, and the handlers read the
  11. // options from the element (a composed component's members are the page's state — never write them in a handler).
  12. String id = 'modal'
  13. String title = ''
  14. String backdropClose = 'true'
  15. String closeLabel = 'Close'
  16. slot = null
  17. // Colours: the semantic WorldAPI tokens as css variables, each with its palette value as fallback, so a copy of this file is styled in an
  18. // app that declares no tokens. Buttons have no border (the creator's rule); the footer's last button is the main one (accent). The
  19. // footer sticks to the bottom of a long content.
  20. Style {
  21. 'html:has(modal-dialog > dialog[open])' { overflow = 'hidden' }
  22. 'modal-dialog' { display = 'contents' }
  23. 'modal-dialog > dialog' { boxSizing = 'border-box' width = 'min(34rem, calc(100vw - 2rem))' maxWidth = 'none' maxHeight = 'calc(100dvh - 2rem)' margin = 'auto' padding = '0' color = 'var(--color-text, rgb(195, 200, 205))' background = 'var(--color-background, rgb(25, 30, 35))' border = '1px solid var(--color-border, rgb(70, 75, 80))' borderRadius = '.6rem' overscrollBehavior = 'contain' }
  24. 'modal-dialog > dialog[open]' { display = 'flex' flexDirection = 'column' }
  25. 'modal-dialog > dialog::backdrop' { background = 'var(--color-background-sunken, rgb(15, 20, 25))' opacity = '.75' }
  26. 'modal-dialog > dialog:focus' { outline = 'none' }
  27. 'modal-dialog header' { display = 'flex' alignItems = 'center' gap = '.5rem' padding = '.6rem .6rem .6rem 1rem' borderBottom = '1px solid var(--color-border, rgb(70, 75, 80))' }
  28. 'modal-dialog h2' { flex = '1' margin = '0' fontSize = '1.1rem' lineHeight = '1.3' color = 'var(--color-text-strong, rgb(245, 250, 255))' overflowWrap = 'anywhere' }
  29. 'modal-dialog button' { font = 'inherit' fontWeight = '600' padding = '.45rem .9rem' color = 'var(--color-text, rgb(195, 200, 205))' background = 'transparent' border = '0' borderRadius = '.4rem' cursor = 'pointer' }
  30. 'modal-dialog button:hover' { background = 'var(--color-surface, rgb(35, 40, 45))' }
  31. 'modal-dialog button:focus-visible' { outline = '2px solid var(--color-accent, #569bd4)' outlineOffset = '1px' }
  32. 'modal-dialog button.modal-x' { flex = 'none' width = '2.4rem' height = '2.4rem' padding = '0' fontSize = '1.5rem' lineHeight = '1' color = 'var(--color-text-muted, rgb(145, 150, 155))' }
  33. 'modal-dialog button.modal-x:hover' { color = 'var(--color-text-strong, rgb(245, 250, 255))' }
  34. 'modal-dialog modal-body' { display = 'block' flex = '1' minHeight = '0' overflow = 'auto' padding = '1rem' overflowWrap = 'anywhere' }
  35. 'modal-dialog modal-body > :first-child' { marginTop = '0' }
  36. 'modal-dialog modal-body > :last-child:not(footer)' { marginBottom = '0' }
  37. 'modal-dialog modal-body footer' { position = 'sticky' bottom = '-1rem' display = 'flex' flexWrap = 'wrap' justifyContent = 'flex-end' gap = '.5rem' margin = '1rem -1rem -1rem' padding = '.75rem 1rem' background = 'var(--color-background-sunken, rgb(15, 20, 25))' borderTop = '1px solid var(--color-border, rgb(70, 75, 80))' }
  38. 'modal-dialog modal-body footer button:last-child' { color = 'var(--color-accent-text, rgb(15, 20, 25))' background = 'var(--color-accent, #569bd4)' }
  39. 'modal-dialog modal-body footer button:last-child:hover' { filter = 'brightness(1.1)' }
  40. }
  41. View {
  42. modalDialog {
  43. dialog { id = id 'aria-label' = title 'data-backdrop' = backdropClose on close(e) { emit modalClosed(e) } on cancel(e) { emit modalCancel(e) } on keydown(e) { emit modalKey(e) } on pointerdown(e) { emit modalDown(e) } on click(e) { emit modalClick(e) }
  44. header {
  45. h2 { title }
  46. button { type = "button" class = "modal-x" title = closeLabel 'aria-label' = closeLabel "×" on click(e) { emit modalX(e) } }
  47. }
  48. modalBody { slot }
  49. }
  50. }
  51. }
  52. dialogOf(node) { return node.closest('modal-dialog').querySelector('dialog') }
  53. // what can take the focus inside the window, in Tab order (enough for forms and buttons; no positive tabindex)
  54. focusables(d) {
  55. all = Array.from(d.querySelectorAll('button, [href], input, select, textarea, summary, [tabindex], [contenteditable="true"]'))
  56. out = []
  57. for (el of all) {
  58. if (!el.disabled && el.getAttribute('tabindex') != '-1' && el.getClientRects().length > 0) { out.push(el) }
  59. }
  60. return out
  61. }
  62. // every way out ends here: the browser's `close` event, with the reason in the dialog's returnValue ('' = the browser closed it by
  63. // itself, which only Esc does); the reason goes out as a bubbling `close` on <modal-dialog> (the dialog's own `close` does not bubble;
  64. // a modal inside this one's content sends its bubbling one past here, so only this dialog's own counts)
  65. on modalClosed(e) {
  66. d = e.target
  67. if (d != e.currentTarget) { return }
  68. reason = d.returnValue != '' ? d.returnValue : 'escape'
  69. d.returnValue = ''
  70. d.parentNode.dispatchEvent(new CustomEvent('close', { bubbles = true detail = { id = d.id reason = reason } }))
  71. }
  72. // Esc: the browser cancels and closes; the reason is set before it does
  73. on modalCancel(e) {
  74. if (e.target.tagName == 'DIALOG') { e.target.returnValue = 'escape' }
  75. }
  76. on modalX(e) { dialogOf(e.target).close('close') }
  77. // Tab / Shift+Tab go round inside the window (without this the focus would leave to the browser's own bar)
  78. on modalKey(e) {
  79. if (e.key != 'Tab') { return }
  80. d = dialogOf(e.target)
  81. f = focusables(d)
  82. if (f.length == 0) { e.preventDefault() d.focus() return }
  83. first = f[0]
  84. last = f[f.length - 1]
  85. at = document.activeElement
  86. if (e.shiftKey && (at == first || at == d || !d.contains(at))) { e.preventDefault() last.focus() }
  87. if (!e.shiftKey && (at == last || !d.contains(at))) { e.preventDefault() first.focus() }
  88. }
  89. // a press on the dim background lands on the dialog element itself (its content covers the rest of it); the press must also start
  90. // there, so a text selection dragged out of the window does not close it
  91. on modalDown(e) {
  92. d = dialogOf(e.target)
  93. d.modalDownOut = e.target == d
  94. }
  95. on modalClick(e) {
  96. d = dialogOf(e.target)
  97. if (e.target == d) {
  98. if (d.modalDownOut && d.getAttribute('data-backdrop') != 'false') { d.close('backdrop') }
  99. return
  100. }
  101. // a button in the content's footer closes it; its value (or its text) is the reason
  102. b = e.target.closest('footer button')
  103. if (b != null && d.contains(b)) {
  104. r = b.value != '' ? b.value : b.textContent.trim()
  105. d.close(r)
  106. }
  107. }

Branches

Latest commits

  • b10f00c8tracker#39: double episodes — migrated episodes whose TMDB id TMDB replaced are adopted by their number in the sync (old id -> migratedTmdbId); merge.hl step 3 merges each season's doubles at start (keeper: most watches > synced > first; watches moved/parked; tombstones into mergedEpisodes, nothing deleted); tools/count-duplicate-episodes.hl; gate fixture + paths-m039; live copy 850 -> 0 in 64 s; gates 373/0, 32/0, 52/0mre
  • 8751adb8tracker: report 032mre
  • 9bce1f65tracker mission 032: STATUS gate files + the hour-boundary flakemre
  • 718bfb89tracker#37 (mission 032): /people = everyone, last updated first (updatedAt stamped by the person fill; view built at boot, touched people first at once), photo + name tiles (person colour) with the /movies pagination, /people/<letter> removed; photo = our file, tmdbProfile, a cast/crew entry's profile (in-memory map at boot), else the new 'no photo' placeholder; new cast/crew/created_by people keep tmdbProfile; search people rows with the photo; /settings = the heading only; util.hl sortDesc starts from sorted runs (same result, 105k: 1.6 s -> 0.15 s); gates 369/0, 32/0, 52/0, check-theme 0; README/STATUS/LOGmre
  • 96ba683adeploy.sh: a gate without a 'passed,' line (check-theme) no longer ends the scriptmre
  • eb3b9205tracker: report 031mre
  • 9b5d2e89tracker mission 031: README (What it does, Test: four gates + the #32 checks, Files: theme/, new pages), STATUS (real copy, A/B load, how to repeat, open points), LOGmre
  • 39950e4ctracker#32 (mission 031): the WorldAPI theme (theme/ vendored verbatim from layouts.worldapi.org 85b5654; styles.hl inherits it: accent green-dark, type colours 1-6; own base/header rules, row lines, genre-pill and inverted-button frames removed, the season foldable keeps its line; check-theme 21 -> 0, 4th deploy gate; main actions class primary) and the #32 header (theme AppHeader/MainMenu/UserMenu/Sidebar/ContentFirst: desktop brand, search, Series|Shows|Movies|Genres|People, user icon with Unwatched..Settings, Logout; signed out the ident selector, phone the iD icon dropdown; phone menu in the sidebar overlay; marked entry by :has); /find -> /search/<q>, /genres, /people(/<letter>), /settings; main { ContentFirst { slot } } works around the hl:web one-line slot bug; gates 365/0, 32/0, 52/0, check-theme 0mre
  • a386dc92tracker: reports 029 + 030mre
  • 71e0fd7dtracker missions 029 + 030: README (What it does, Files, gate count), STATUS (real-copy numbers, how to repeat, open points), LOGmre
  • d36ea6eatracker#34 + #35 (mission 030): Follow directly under the poster, as wide as the poster (show.hl, styles.hl); the status pill next to a series' title — TVmaze's status (new tvmazeStatus, stored by the sync's TVmaze merge) else TMDB's, TVmaze Ended + TMDB Canceled = Canceled, inverted (filled, dark text, no border), green running / yellow pending / red canceled / muted ended (shows.hl statusOf); the daily delta asks TVmaze's status of an unfollowed series TVmaze's change list names (dailysync.hl syncRunStep, sync.hl syncTvmazeStatus); the status backfill after the details repair (backfill.hl, jobs.hl statusTick; resumable, 550 ms per TVmaze request); gates 354/0, 32/0, 52/0mre
  • 7d7d4487tracker#33 (mission 029): reduced titles — every title TMDB's details never went through this app (no detailsAt, no tmdbSync) is incomplete (shows.hl isIncomplete; the old tracker's migrated rows passed #26's test: 5,697 non-adult on the live copy, 691 series without seasons); the repair job does the visibly reduced first (shows.hl missingParts), the page completes one on open; a title TMDB has no poster for (The Remaining) shows the placeholder; tools/count-incomplete.hl; gate fixtures stand for synced titles (tmdbSync), tests/seed-reduced.hl + #33 checks; gates 347/0, 32/0, 52/0mre
  • 661c2592tracker: report 028mre
  • 27c916fatracker mission 028: README ("Code order", the new file map), STATUS (counts before/after, tests, how to repeat, open), LOGmre
  • d924f398tracker mission 028: comments name the new files (sync.hl, dailysync.hl, backfill.hl, credits.hl, jobs.hl, images.hl …); tools/ref-params.py + tools/lambda-audit.py also scan lib/ (they globbed the root only), lambda-audit counts a plain `x = p` alias like `let x = p`mre
  • 2e89b968tracker mission 028 (code order) 5/5 let: `let` only where a variable is reassigned — 667 never-reassigned lets became plain declarations (project.hl, lib/, components/, tools/, tests/); kept: 264 in loop bodies (a plain declaration there is 'Cannot reassign' on the 2nd pass), 234 reassigned, 27 whose name is also a member/outer/free name (a plain write would rebind it); tools/let-audit.py decides and fixes (README 'Code order'); tests/realdata-m028.{sh,mjs} = the page-output diff on a real copy; gates 342/0, 32/0, 52/0, real-copy pages identicalmre
  • 54796ff2tracker mission 028 (code order) 4/5 thin faces + last copies: the show page's check/follow faces call lib/watches.hl toggleWatched / toggleSeasonWatched (seasonAllWatched moved there) and lib/follows.hl toggleFollowed; both logins (header selector face, /login/callback) share lib/users.hl userOfCode; todayStr/listOf copies in components and the export readers copied into tools/migrate.hl + tools/old-short-ids.hl now once (lib/util.hl, lib/export.hl); gates 342/0, 32/0, 52/0; old-short-ids output byte-identical, migrate output identicalmre
  • 06b078e3tracker mission 028 (code order) 3/5 project.hl is the map: config, routes, wiring and a feature → file index (914 → 258 lines); the background jobs (daily sync run, backfills, details repair, credits job, merge, short ids, collection seed) moved unchanged into lib/jobs.hl (a class: their state is reassigned every step, a static cannot be; one instance made after the server), the login callback into lib/users.hl, poster/photo serving into lib/images.hl, the /shows/<slug> rule into lib/shows.hl showsMovedPath; route handlers are thin wrappers; gates 342/0, 32/0, 52/0, real-copy pages identicalmre
  • 94716fd2tracker mission 028 (code order) 2/5 util + topics: lib/util.hl holds envOr, storageDir, postersDir, profilesDir, newId, hexDigits, todayStr, dateOr, textOr, hasId, listOr, firstOf, sortDesc once (were copied into up to 5 files); tmdbsync.hl split into tmdb.hl (TMDB/TVmaze requests), sync.hl (one title's sync), sync-helpers.hl, backfill.hl; details.hl split into details.hl, credits.hl, credits-helpers.hl (isIncomplete to shows.hl); search-helpers.hl (words, query, ranking, slugs); collections.hl (the TMDB collection seed, out of franchises.hl); deltasync.hl renamed dailysync.hl; no behaviour change: gates 342/0, 32/0, 52/0, real-copy pages identicalmre
  • 186079b0tracker mission 028 (code order) 1/5 move: every root .hl except project.hl into lib/ (styles.hl into components/), import paths only; gates 342/0, 32/0, 52/0; real-copy pages identicalmre