gitoriaLog in with ident

tracker

All repositories: gitoria

ReadmeCodePull requestsReleasesTicketsSettings
Commit9bce1f659bce1f65tracker mission 032: STATUS gate files + the hour-boundary flakemre9bce1f65/lib/credits.hl

7.9 KB

  1. // lib/credits.hl — A TITLE'S CAST AND CREW (tracker.worldapi.org#28): linked to our people, stored on the title, and the
  2. // CREDITS JOB that gives every public title its credits once. Mission 028: out of details.hl (the reading of TMDB's answer is in
  3. // credits-helpers.hl).
  4. //
  5. // CAST AND CREW (tracker.worldapi.org#28; creator: "you show quite few people, usually there are more especially at picard, and
  6. // directors and so"). From the SAME details answer (`credits` of a movie, `aggregate_credits` of a series = every season):
  7. // cast [{ person, character, actor, episodes, guest }] — a movie: TMDB's order (billing); a series: TMDB's aggregate order
  8. // (by episode count, most first; `character` = all roles " / "), `episodes` = the person's episodes, `guest` = fewer than
  9. // `mainMinOf` (half the series' episodes, at most 10, at least 1) → the page puts them after "Guest stars". At most
  10. // `castMax` (300: a talk show/soap lists 3,000+ one-episode guests — Grey's Anatomy 3,243, SNL 2,771 — each would be a
  11. // new person); adult people left out; entries we had and TMDB does not list are kept after them.
  12. // GUESTS ARE NOT PERSON RECORDS (mission 062, memory: 160k people = +3.3 GB RSS at boot): a guest entry is
  13. // { person (only when we have them already, else null), tmdbId, actor, character, profile (TMDB's profile_path), episodes,
  14. // guest = true } — the page links it to `/person/tmdb/<tmdbId>?show=<show id>`, which creates the person on the first open
  15. // (people.hl guestPersonId). The main cast and the crew are linked/created at once as before.
  16. // crew [{ person, name, job, episodes, profile }] job = creator (a series' `created_by`) | director (Director) | writer (Writer) |
  17. // screenplay (Screenplay) | story (Story) | composer (Original Music Composer, Composer, Music) — one entry per person and
  18. // job, a series' by that job's episode count (most first), a movie's in TMDB's order; at most `crewMax` per job.
  19. // `creditsAt` (ms) = the credits are stored (by any path); `creditsCheck` = why the credits job gave up (TMDB 404, adult).
  20. // Every person is linked (people.hl castPersonId: the one we have by TMDB id, else a NEW minimal person — slug, search entry,
  21. // this one credit; their page fills on the first visit). WHO STORES THEM: the details step below (incomplete titles), the daily
  22. // sync and the search import (the sync (sync.hl) asks for the credits in the details request it makes anyway → `applyCredits`), and
  23. // the CREDITS JOB (jobs.hl `creditsTick`, `creditsStep` here) for every other public title once — one request per title.
  24. import { now } from 'hl:time'
  25. import { listOr } from './util.hl'
  26. import { showsTable, personsTable, isIncomplete } from './shows.hl'
  27. import { tmdbGet, adultOf } from './tmdb.hl'
  28. import { castPersonId, castPeopleCount, personIdByTmdb } from './people.hl'
  29. import { castOf, mainMinOf, crewOf, crewRoleOf, hasCredits } from './credits-helpers.hl'
  30. // the title's cast: TMDB's (linked to our people, new ones added) first, then the entries we had that TMDB does not list.
  31. // `mainMin` = a series' main-cast episode count (mainMinOf), 0 for a movie (no guests)
  32. static mergedCast = (&show, &tmdbCast, &mainMin) => {
  33. out = []
  34. have = {}
  35. showKey = show.id
  36. seenTmdb = {}
  37. for (c of tmdbCast) {
  38. let guest = c.episodes != null && c.episodes < mainMin
  39. // a guest: linked only when we have them, never created here (mission 062)
  40. let pid = guest ? personIdByTmdb(c.tmdbId) : castPersonId(c, showKey)
  41. if (pid != null && have[pid] != true) {
  42. have[pid] = true
  43. seenTmdb['' + c.tmdbId] = true
  44. out.push({ person = pid tmdbId = c.tmdbId character = c.character actor = c.name profile = c.profile episodes = c.episodes guest = guest })
  45. } else if (pid == null && guest && seenTmdb['' + c.tmdbId] != true) {
  46. seenTmdb['' + c.tmdbId] = true
  47. out.push({ person = null tmdbId = c.tmdbId character = c.character actor = c.name profile = c.profile episodes = c.episodes guest = true })
  48. }
  49. }
  50. for (c of listOr(show.cast)) {
  51. if (c != null && c.person != null && have[c.person] != true && (c.tmdbId == null || seenTmdb['' + c.tmdbId] != true)) {
  52. have[c.person] = true
  53. out.push(c)
  54. }
  55. }
  56. return out
  57. }
  58. // the title's crew: TMDB's, linked to our people (a crew person new to us gets the job as their role) — replaces what we had
  59. static linkedCrew = (&show, &tmdbCrew) => {
  60. out = []
  61. showKey = show.id
  62. for (c of tmdbCrew) {
  63. let pid = castPersonId({ tmdbId = c.tmdbId name = c.name character = crewRoleOf(c.job) gender = c.gender profile = c.profile }, showKey)
  64. if (pid != null) { out.push({ person = pid name = c.name job = c.job episodes = c.episodes profile = c.profile }) }
  65. }
  66. return out
  67. }
  68. // cast + crew of this record from a details answer → { show (the record with cast, crew, creditsAt), cast, crew, people (new) }
  69. static withCredits = (show, &d, &movie) => {
  70. before = castPeopleCount()
  71. tmdbCast = castOf(d, movie)
  72. x = show
  73. x.cast = mergedCast(show, tmdbCast, movie ? 0 : mainMinOf(d))
  74. x.crew = linkedCrew(show, crewOf(d, movie))
  75. x.creditsAt = now()
  76. return { show = x cast = tmdbCast.length crew = x.crew.length people = castPeopleCount() - before }
  77. }
  78. // the search import: its details answer (sync.hl `res.details`) → the title's cast + crew. Nothing
  79. // for an adult title or an answer without credits. Answers { cast, crew, people, ms, error }
  80. static applyCredits = (&showId, &d) => {
  81. out = { cast = 0 crew = 0 people = 0 ms = 0 error = '' }
  82. t0 = now()
  83. show = showsTable.fetch(showId)
  84. if (show == null || show.adult == true || adultOf(d) == true || !hasCredits(d, show.type == 'movie')) { return out }
  85. w = withCredits(show, d, show.type == 'movie')
  86. if (showsTable.update(show.id, w.show) == null) { out.error = show.title + ': credits not stored: ' + showsTable.lastError() return out }
  87. out.cast = w.cast
  88. out.crew = w.crew
  89. out.people = w.people
  90. out.ms = now() - t0
  91. return out
  92. }
  93. // the credits job touches only shows + people: the episodes' index files (~16 MB on the live data) are not rewritten
  94. static persistCredits = () => {
  95. showsTable.persist()
  96. personsTable.persist()
  97. return true
  98. }
  99. // ---- THE CREDITS JOB (tracker#28, jobs.hl `creditsTick`): every public title that has no credits yet, once --------------
  100. // (the incomplete ones get theirs from completeStep; adult and unknown-flag titles are never asked — not public)
  101. static needsCredits = (&s) => { return s != null && s.tmdbId != null && s.adult == false && s.creditsAt == null && s.creditsCheck == null && !isIncomplete(s) && s.mergedInto == null }
  102. // in table order, read once when the job starts (a restart goes on with what is left)
  103. static creditsQueue = () => {
  104. out = []
  105. for (s of showsTable.find(null, null)) { if (needsCredits(s)) { out.push(s.id) } }
  106. return out
  107. }
  108. // ONE title: one request (details + credits / aggregate_credits) → its cast + crew. Answers { skipped, requests, cast, crew,
  109. // people, ms, error, retry (no answer, 429, 5xx: ask again later) }. TMDB 404 / adult → `creditsCheck`, never asked again.
  110. static creditsStep = (&showId) => {
  111. out = { skipped = false requests = 0 cast = 0 crew = 0 people = 0 ms = 0 error = '' retry = false }
  112. t0 = now()
  113. show = showsTable.fetch(showId)
  114. if (!needsCredits(show)) { out.skipped = true return out }
  115. movie = show.type == 'movie'
  116. out.requests = 1
  117. d = tmdbGet((movie ? '/movie/' : '/tv/') + show.tmdbId + '?append_to_response=' + (movie ? 'credits' : 'aggregate_credits'))
  118. if (d.failed != null) {
  119. out.error = show.title + ': ' + d.failed
  120. if (d.status == 404) {
  121. show.creditsCheck = 'TMDB 404'
  122. showsTable.update(show.id, show)
  123. } else { out.retry = true }
  124. return out
  125. }
  126. if (adultOf(d) == true) {
  127. show.creditsCheck = 'adult'
  128. showsTable.update(show.id, show)
  129. return out
  130. }
  131. w = withCredits(show, d, movie)
  132. if (showsTable.update(show.id, w.show) == null) {
  133. out.error = show.title + ': credits not stored: ' + showsTable.lastError()
  134. out.retry = true
  135. return out
  136. }
  137. out.cast = w.cast
  138. out.crew = w.crew
  139. out.people = w.people
  140. out.ms = now() - t0
  141. return out
  142. }

Branches

Latest commits

  • 9bce1f65tracker mission 032: STATUS gate files + the hour-boundary flakemre
  • 718bfb89tracker#37 (mission 032): /people = everyone, last updated first (updatedAt stamped by the person fill; view built at boot, touched people first at once), photo + name tiles (person colour) with the /movies pagination, /people/<letter> removed; photo = our file, tmdbProfile, a cast/crew entry's profile (in-memory map at boot), else the new 'no photo' placeholder; new cast/crew/created_by people keep tmdbProfile; search people rows with the photo; /settings = the heading only; util.hl sortDesc starts from sorted runs (same result, 105k: 1.6 s -> 0.15 s); gates 369/0, 32/0, 52/0, check-theme 0; README/STATUS/LOGmre
  • 96ba683adeploy.sh: a gate without a 'passed,' line (check-theme) no longer ends the scriptmre
  • eb3b9205tracker: report 031mre
  • 9b5d2e89tracker mission 031: README (What it does, Test: four gates + the #32 checks, Files: theme/, new pages), STATUS (real copy, A/B load, how to repeat, open points), LOGmre
  • 39950e4ctracker#32 (mission 031): the WorldAPI theme (theme/ vendored verbatim from layouts.worldapi.org 85b5654; styles.hl inherits it: accent green-dark, type colours 1-6; own base/header rules, row lines, genre-pill and inverted-button frames removed, the season foldable keeps its line; check-theme 21 -> 0, 4th deploy gate; main actions class primary) and the #32 header (theme AppHeader/MainMenu/UserMenu/Sidebar/ContentFirst: desktop brand, search, Series|Shows|Movies|Genres|People, user icon with Unwatched..Settings, Logout; signed out the ident selector, phone the iD icon dropdown; phone menu in the sidebar overlay; marked entry by :has); /find -> /search/<q>, /genres, /people(/<letter>), /settings; main { ContentFirst { slot } } works around the hl:web one-line slot bug; gates 365/0, 32/0, 52/0, check-theme 0mre
  • a386dc92tracker: reports 029 + 030mre
  • 71e0fd7dtracker missions 029 + 030: README (What it does, Files, gate count), STATUS (real-copy numbers, how to repeat, open points), LOGmre
  • d36ea6eatracker#34 + #35 (mission 030): Follow directly under the poster, as wide as the poster (show.hl, styles.hl); the status pill next to a series' title — TVmaze's status (new tvmazeStatus, stored by the sync's TVmaze merge) else TMDB's, TVmaze Ended + TMDB Canceled = Canceled, inverted (filled, dark text, no border), green running / yellow pending / red canceled / muted ended (shows.hl statusOf); the daily delta asks TVmaze's status of an unfollowed series TVmaze's change list names (dailysync.hl syncRunStep, sync.hl syncTvmazeStatus); the status backfill after the details repair (backfill.hl, jobs.hl statusTick; resumable, 550 ms per TVmaze request); gates 354/0, 32/0, 52/0mre
  • 7d7d4487tracker#33 (mission 029): reduced titles — every title TMDB's details never went through this app (no detailsAt, no tmdbSync) is incomplete (shows.hl isIncomplete; the old tracker's migrated rows passed #26's test: 5,697 non-adult on the live copy, 691 series without seasons); the repair job does the visibly reduced first (shows.hl missingParts), the page completes one on open; a title TMDB has no poster for (The Remaining) shows the placeholder; tools/count-incomplete.hl; gate fixtures stand for synced titles (tmdbSync), tests/seed-reduced.hl + #33 checks; gates 347/0, 32/0, 52/0mre
  • 661c2592tracker: report 028mre
  • 27c916fatracker mission 028: README ("Code order", the new file map), STATUS (counts before/after, tests, how to repeat, open), LOGmre
  • d924f398tracker mission 028: comments name the new files (sync.hl, dailysync.hl, backfill.hl, credits.hl, jobs.hl, images.hl …); tools/ref-params.py + tools/lambda-audit.py also scan lib/ (they globbed the root only), lambda-audit counts a plain `x = p` alias like `let x = p`mre
  • 2e89b968tracker mission 028 (code order) 5/5 let: `let` only where a variable is reassigned — 667 never-reassigned lets became plain declarations (project.hl, lib/, components/, tools/, tests/); kept: 264 in loop bodies (a plain declaration there is 'Cannot reassign' on the 2nd pass), 234 reassigned, 27 whose name is also a member/outer/free name (a plain write would rebind it); tools/let-audit.py decides and fixes (README 'Code order'); tests/realdata-m028.{sh,mjs} = the page-output diff on a real copy; gates 342/0, 32/0, 52/0, real-copy pages identicalmre
  • 54796ff2tracker mission 028 (code order) 4/5 thin faces + last copies: the show page's check/follow faces call lib/watches.hl toggleWatched / toggleSeasonWatched (seasonAllWatched moved there) and lib/follows.hl toggleFollowed; both logins (header selector face, /login/callback) share lib/users.hl userOfCode; todayStr/listOf copies in components and the export readers copied into tools/migrate.hl + tools/old-short-ids.hl now once (lib/util.hl, lib/export.hl); gates 342/0, 32/0, 52/0; old-short-ids output byte-identical, migrate output identicalmre
  • 06b078e3tracker mission 028 (code order) 3/5 project.hl is the map: config, routes, wiring and a feature → file index (914 → 258 lines); the background jobs (daily sync run, backfills, details repair, credits job, merge, short ids, collection seed) moved unchanged into lib/jobs.hl (a class: their state is reassigned every step, a static cannot be; one instance made after the server), the login callback into lib/users.hl, poster/photo serving into lib/images.hl, the /shows/<slug> rule into lib/shows.hl showsMovedPath; route handlers are thin wrappers; gates 342/0, 32/0, 52/0, real-copy pages identicalmre
  • 94716fd2tracker mission 028 (code order) 2/5 util + topics: lib/util.hl holds envOr, storageDir, postersDir, profilesDir, newId, hexDigits, todayStr, dateOr, textOr, hasId, listOr, firstOf, sortDesc once (were copied into up to 5 files); tmdbsync.hl split into tmdb.hl (TMDB/TVmaze requests), sync.hl (one title's sync), sync-helpers.hl, backfill.hl; details.hl split into details.hl, credits.hl, credits-helpers.hl (isIncomplete to shows.hl); search-helpers.hl (words, query, ranking, slugs); collections.hl (the TMDB collection seed, out of franchises.hl); deltasync.hl renamed dailysync.hl; no behaviour change: gates 342/0, 32/0, 52/0, real-copy pages identicalmre
  • 186079b0tracker mission 028 (code order) 1/5 move: every root .hl except project.hl into lib/ (styles.hl into components/), import paths only; gates 342/0, 32/0, 52/0; real-copy pages identicalmre
  • 4f47f181tracker: report 027mre
  • dc1d4be4tracker mission 027: Hybriel master 06617221 vendored (plugin allocator fixes 3a781359 + 413f60e4); real copy RSS through first-start jobs + 400 loads flat ~2.55 GB (190aa11d 2.3 -> 5.6 GB), page times <= 1.1x; gates 342/0, 32/0, 52/0mre