gitoriaLog in with ident

tracker

All repositories: gitoria

ReadmeCodePull requestsReleasesTicketsSettings
Commit9bce1f659bce1f65tracker mission 032: STATUS gate files + the hour-boundary flakemre9bce1f65/components/unwatched.hl

5.9 KB

  1. // components/unwatched.hl — `/my/unwatched` (tracker.worldapi.org#5, moved from `/unwatched` in #8): every already-released episode of a
  2. // show the signed-in user follows that they have not watched yet, newest release first. Creator's words:
  3. // "/unwatched lists all unwatched episodes of shows followed in release date desc order"; "check icon is
  4. // a disc with a check in it" — the SAME check icon and watch logic as the show page (step 4), reused
  5. // (not copied) from follows.hl/shows.hl/watches.hl: `watchClassOf`, `watchedSet`, `setWatched` come from
  6. // watches.hl, the check icon markup/CSS is the same `button.checkicon` shape/class styles.hl already has.
  7. //
  8. // A ROW ONLY EVER SHOWS AN UNWATCHED EPISODE, so a click always marks it watched (never toggles back,
  9. // unlike the show page's checks) and the row leaves the list — the ticket's own test: "click an
  10. // episode's check: it disappears from the list."
  11. //
  12. // ONE FLAT LIST, rebuilt whole server-side on every click — the same proven-safe shape components/show.hl
  13. // uses for exactly the same Hybriel reasons (hybriel#86, hybriel#115/#116: a plain member function that
  14. // touches an hl:mpackdb-backed import must be `static` and must only ever be called server-side).
  15. parent './main.hl'
  16. import { appTitle } from '../project.hl'
  17. import { userIdOfSession } from '../lib/users.hl'
  18. import { followedShowIds } from '../lib/follows.hl'
  19. import { cardOf, episodeRowsOf, episodeCode } from '../lib/shows.hl'
  20. import { watchesOfUser, watchedSetOf, setWatched, watchClassOf } from '../lib/watches.hl'
  21. import { todayStr } from '../lib/util.hl'
  22. // ---- pure helpers (static: see the header comment above) ------------------------------------
  23. // newest release first, `release` a plain 'YYYY-MM-DD' string; equal releases: the row found LATER first (as the old insertion
  24. // sort did). Mission 070: one merge sort over all rows (n log n) instead of inserting each row into a new list (n² list copies:
  25. // 1,287 rows on the creator's data = 0.8 M element copies per page, and since Hybriel 8efba065 every copy also feeds the
  26. // byte-triggered GC — /my/unwatched took 5.7 s). No list sort() (hybriel#1), so hand-written; `&`: no copy of the lists (#48).
  27. static mergeByReleaseDesc = (&a, &b) => {
  28. out = []
  29. let i = 0
  30. let j = 0
  31. while (i < a.length && j < b.length) {
  32. if (a[i].release >= b[j].release) { out.push(a[i]) i = i + 1 } else { out.push(b[j]) j = j + 1 }
  33. }
  34. while (i < a.length) { out.push(a[i]) i = i + 1 }
  35. while (j < b.length) { out.push(b[j]) j = j + 1 }
  36. return out
  37. }
  38. static sortByReleaseDesc = (&rows) => {
  39. // runs of one, the found order reversed (ties: later first), merged pairwise until one run is left
  40. let runs = []
  41. let k = rows.length - 1
  42. while (k >= 0) { runs.push([rows[k]]) k = k - 1 }
  43. if (runs.length == 0) { return [] }
  44. while (runs.length > 1) {
  45. let next = []
  46. let r = 0
  47. while (r + 1 < runs.length) { next.push(mergeByReleaseDesc(runs[r], runs[r + 1])) r = r + 2 }
  48. if (r < runs.length) { next.push(runs[r]) }
  49. runs = next
  50. }
  51. return runs[0]
  52. }
  53. // tracker#30 (mission 025): each followed title's slim cached card + episode rows (shows.hl cardOf / episodeRowsOf, in the
  54. // seasonsOfShow/episodesOfSeason order) and the user's cached watched set — no season or episode record is fetched per load
  55. static unwatchedRowsOf = (&userId) => {
  56. if (userId == null) { return [] }
  57. today = todayStr()
  58. watched = watchedSetOf(userId)
  59. out = []
  60. for (sid of followedShowIds(userId)) {
  61. let c = cardOf(sid)
  62. if (c != null) {
  63. for (e of episodeRowsOf(sid)) {
  64. let released = e.release != null && e.release <= today
  65. if (released && watched['episode:' + e.id] != true) {
  66. out.push({
  67. id = e.id showTitle = c.titleYear showHref = c.href
  68. episodeLabel = episodeCode(e.s, e.e) + ' · ' + e.title
  69. release = e.release watchClass = watchClassOf(false)
  70. })
  71. }
  72. }
  73. }
  74. }
  75. return sortByReleaseDesc(out)
  76. }
  77. // ---- reactive members -----------------------------------------------------------------------
  78. session = null
  79. userId = userIdOfSession(session)
  80. signedIn = userId != null
  81. // a plain copy of userId for `rows` (mission 047: session sync, see components/show.hl `me`)
  82. me = userId
  83. rows = signedIn ? unwatchedRowsOf(me) : []
  84. hasRows = rows.length > 0
  85. noRows = !hasRows
  86. emptyText = signedIn ? 'No unwatched episodes.' : 'Sign in to see the shows you follow.'
  87. __title = 'Unwatched — ' + appTitle
  88. View {
  89. unwatchedPage {
  90. h1 { "Unwatched" }
  91. if (noRows) { p { class = "muted" emptyText } }
  92. if (hasRows) {
  93. unwatchedRows {
  94. for (row of rows) {
  95. unwatchedRow {
  96. button { type = "button" class = row.watchClass value = row.id "aria-label" = "mark episode watched"
  97. svg { viewBox = "0 0 24 24" width = "22" height = "22" "aria-hidden" = "true"
  98. circle { cx = "12" cy = "12" r = "10" }
  99. path { d = "M7 12.5 L10.5 16 L17 8.5" }
  100. }
  101. on click(e) { emit toggleEpisode(row.id) }
  102. }
  103. a { class = "unwatched-show" href = row.showHref row.showTitle }
  104. unwatchedEpisode { row.episodeLabel }
  105. unwatchedDate { row.release }
  106. }
  107. }
  108. }
  109. }
  110. }
  111. }
  112. // The client only ever ASSIGNS the `rows` the server already rebuilt — never calls the tainted
  113. // local helper itself (components/show.hl's own `on toggleEpisode` follows the same shape, and
  114. // the same reason: `unwatchedRowsOf` touches mpackdb-backed imports, so it compiles to nothing on
  115. // the client, hybriel#115/#116).
  116. on toggleEpisode(episodeId) {
  117. if (!signedIn) { return null }
  118. r = emit server unwatchedToggle('' + episodeId)
  119. if (r == null || r.error != null) { return null }
  120. rows = r.rows
  121. }
  122. // ---- the face (the trailing `session` is always the server's: hybriel#16) ----
  123. on server unwatchedToggle(episodeId, session) {
  124. uid = userIdOfSession(session)
  125. if (uid == null) { return { error = 'you are not signed in' } }
  126. watchRows = watchesOfUser(uid)
  127. ok = setWatched(uid, 'episode', episodeId, watchRows, true)
  128. if (!ok) { return { error = 'could not save the watch' } }
  129. return { ok = true rows = unwatchedRowsOf(uid) }
  130. }

Branches

Latest commits

  • 9bce1f65tracker mission 032: STATUS gate files + the hour-boundary flakemre
  • 718bfb89tracker#37 (mission 032): /people = everyone, last updated first (updatedAt stamped by the person fill; view built at boot, touched people first at once), photo + name tiles (person colour) with the /movies pagination, /people/<letter> removed; photo = our file, tmdbProfile, a cast/crew entry's profile (in-memory map at boot), else the new 'no photo' placeholder; new cast/crew/created_by people keep tmdbProfile; search people rows with the photo; /settings = the heading only; util.hl sortDesc starts from sorted runs (same result, 105k: 1.6 s -> 0.15 s); gates 369/0, 32/0, 52/0, check-theme 0; README/STATUS/LOGmre
  • 96ba683adeploy.sh: a gate without a 'passed,' line (check-theme) no longer ends the scriptmre
  • eb3b9205tracker: report 031mre
  • 9b5d2e89tracker mission 031: README (What it does, Test: four gates + the #32 checks, Files: theme/, new pages), STATUS (real copy, A/B load, how to repeat, open points), LOGmre
  • 39950e4ctracker#32 (mission 031): the WorldAPI theme (theme/ vendored verbatim from layouts.worldapi.org 85b5654; styles.hl inherits it: accent green-dark, type colours 1-6; own base/header rules, row lines, genre-pill and inverted-button frames removed, the season foldable keeps its line; check-theme 21 -> 0, 4th deploy gate; main actions class primary) and the #32 header (theme AppHeader/MainMenu/UserMenu/Sidebar/ContentFirst: desktop brand, search, Series|Shows|Movies|Genres|People, user icon with Unwatched..Settings, Logout; signed out the ident selector, phone the iD icon dropdown; phone menu in the sidebar overlay; marked entry by :has); /find -> /search/<q>, /genres, /people(/<letter>), /settings; main { ContentFirst { slot } } works around the hl:web one-line slot bug; gates 365/0, 32/0, 52/0, check-theme 0mre
  • a386dc92tracker: reports 029 + 030mre
  • 71e0fd7dtracker missions 029 + 030: README (What it does, Files, gate count), STATUS (real-copy numbers, how to repeat, open points), LOGmre
  • d36ea6eatracker#34 + #35 (mission 030): Follow directly under the poster, as wide as the poster (show.hl, styles.hl); the status pill next to a series' title — TVmaze's status (new tvmazeStatus, stored by the sync's TVmaze merge) else TMDB's, TVmaze Ended + TMDB Canceled = Canceled, inverted (filled, dark text, no border), green running / yellow pending / red canceled / muted ended (shows.hl statusOf); the daily delta asks TVmaze's status of an unfollowed series TVmaze's change list names (dailysync.hl syncRunStep, sync.hl syncTvmazeStatus); the status backfill after the details repair (backfill.hl, jobs.hl statusTick; resumable, 550 ms per TVmaze request); gates 354/0, 32/0, 52/0mre
  • 7d7d4487tracker#33 (mission 029): reduced titles — every title TMDB's details never went through this app (no detailsAt, no tmdbSync) is incomplete (shows.hl isIncomplete; the old tracker's migrated rows passed #26's test: 5,697 non-adult on the live copy, 691 series without seasons); the repair job does the visibly reduced first (shows.hl missingParts), the page completes one on open; a title TMDB has no poster for (The Remaining) shows the placeholder; tools/count-incomplete.hl; gate fixtures stand for synced titles (tmdbSync), tests/seed-reduced.hl + #33 checks; gates 347/0, 32/0, 52/0mre
  • 661c2592tracker: report 028mre
  • 27c916fatracker mission 028: README ("Code order", the new file map), STATUS (counts before/after, tests, how to repeat, open), LOGmre
  • d924f398tracker mission 028: comments name the new files (sync.hl, dailysync.hl, backfill.hl, credits.hl, jobs.hl, images.hl …); tools/ref-params.py + tools/lambda-audit.py also scan lib/ (they globbed the root only), lambda-audit counts a plain `x = p` alias like `let x = p`mre
  • 2e89b968tracker mission 028 (code order) 5/5 let: `let` only where a variable is reassigned — 667 never-reassigned lets became plain declarations (project.hl, lib/, components/, tools/, tests/); kept: 264 in loop bodies (a plain declaration there is 'Cannot reassign' on the 2nd pass), 234 reassigned, 27 whose name is also a member/outer/free name (a plain write would rebind it); tools/let-audit.py decides and fixes (README 'Code order'); tests/realdata-m028.{sh,mjs} = the page-output diff on a real copy; gates 342/0, 32/0, 52/0, real-copy pages identicalmre
  • 54796ff2tracker mission 028 (code order) 4/5 thin faces + last copies: the show page's check/follow faces call lib/watches.hl toggleWatched / toggleSeasonWatched (seasonAllWatched moved there) and lib/follows.hl toggleFollowed; both logins (header selector face, /login/callback) share lib/users.hl userOfCode; todayStr/listOf copies in components and the export readers copied into tools/migrate.hl + tools/old-short-ids.hl now once (lib/util.hl, lib/export.hl); gates 342/0, 32/0, 52/0; old-short-ids output byte-identical, migrate output identicalmre
  • 06b078e3tracker mission 028 (code order) 3/5 project.hl is the map: config, routes, wiring and a feature → file index (914 → 258 lines); the background jobs (daily sync run, backfills, details repair, credits job, merge, short ids, collection seed) moved unchanged into lib/jobs.hl (a class: their state is reassigned every step, a static cannot be; one instance made after the server), the login callback into lib/users.hl, poster/photo serving into lib/images.hl, the /shows/<slug> rule into lib/shows.hl showsMovedPath; route handlers are thin wrappers; gates 342/0, 32/0, 52/0, real-copy pages identicalmre
  • 94716fd2tracker mission 028 (code order) 2/5 util + topics: lib/util.hl holds envOr, storageDir, postersDir, profilesDir, newId, hexDigits, todayStr, dateOr, textOr, hasId, listOr, firstOf, sortDesc once (were copied into up to 5 files); tmdbsync.hl split into tmdb.hl (TMDB/TVmaze requests), sync.hl (one title's sync), sync-helpers.hl, backfill.hl; details.hl split into details.hl, credits.hl, credits-helpers.hl (isIncomplete to shows.hl); search-helpers.hl (words, query, ranking, slugs); collections.hl (the TMDB collection seed, out of franchises.hl); deltasync.hl renamed dailysync.hl; no behaviour change: gates 342/0, 32/0, 52/0, real-copy pages identicalmre
  • 186079b0tracker mission 028 (code order) 1/5 move: every root .hl except project.hl into lib/ (styles.hl into components/), import paths only; gates 342/0, 32/0, 52/0; real-copy pages identicalmre
  • 4f47f181tracker: report 027mre
  • dc1d4be4tracker mission 027: Hybriel master 06617221 vendored (plugin allocator fixes 3a781359 + 413f60e4); real copy RSS through first-start jobs + 400 loads flat ~2.55 GB (190aa11d 2.3 -> 5.6 GB), page times <= 1.1x; gates 342/0, 32/0, 52/0mre