gitoriaLog in with ident

tracker

All repositories: gitoria

ReadmeCodePull requestsReleasesTicketsSettings
Commit9448d6439448d643tracker#35 follow-up (mission 033): TVmaze 'Running' is labelled 'Returning', or 'Airing' while a non-special episode of the two newest seasons is released within today +-7 days (data unchanged); gate fixtures Running/Airing/Aired + a special; browser 366/0, kinds 32/0, franchises 52/0, pager 229/0, check-theme 0mre9448d643/reports/018-tracker-merge-t26.md

5.4 KB

  1. # w062: tracker, t26 (#26 + #28) merged into main + 3 fixes (mission 018 (old 062))
  2. **Commit**: `f2b0067` on main (a merge commit: fa1f9df + t26 10bb3f9), in loreana:/media/STORAGE/projects/tracker.worldapi.org. Not pushed and not deployed.
  3. - The worktree tracker-wt26 and branch t26 are removed. It had nothing uncommitted, only `.scratch` gate files.
  4. - Note: the worktree tracker-wt18 (branch t18) is at 10bb3f9, so it is based on t26.
  5. ## What was done
  6. 1. **Merge**: conflicts were in README, STATUS, `components/show.hl` (header comment; skeleton poster + `#shortid`) and `tests/browser.mjs` (startServer env, import checks, the #27 and #26/#28 blocks). I kept both sides. `buildRows` and `syncMovie`/`syncShowPart` merged without conflict.
  7. 2. **Short ids for every new record**:
  8. - Shows were already covered (import, filmography).
  9. - `people.hl castPersonId` now calls `claimShortId('person', …)`. It is the only place that creates people, so it covers completion, the credits job, the daily sync, `tools/sync-tmdb.hl`, the search import and the guest route.
  10. - `shortids.hl` finds `../data/old-short-ids.json` when it runs from `tools/`.
  11. - Gate:
  12. - `count-short-ids` runs right after the sync tool and after the credits job, both before the next start: no record without a short id, 0 duplicates.
  13. - The #26 person, the import's 2 people and the guest have their short id at once.
  14. - The next start logs "nothing to do".
  15. 3. **Guests are no person records**:
  16. - `details.hl mergedCast` stores a guest on the title as `{ person: null|existing, tmdbId, actor, character, profile, episodes, guest }`.
  17. - The link is `/person/tmdb/<id>?show=<show id>`. `project.hl guestRoute` calls `people.hl guestPersonId`, which creates the person (short id, persisted) and answers 302 to `/person/<slug>`. That page fills from TMDB.
  18. - Without `?show=`, the name comes from TMDB `/person/<id>`. An unknown id answers 404.
  19. - Main cast and crew still get records.
  20. 4. **Watch/follow clicks**: the real payload was `showRow`, the whole show record (300 cast + crew entries). It went out with the page and again with every session sync. Now:
  21. - `showRow` is a small `pageShowOf` object.
  22. - Cast and crew derive from the slug. An adult title shows none; adult titles never get credits.
  23. - `watchesOfUser` is cached per user until `setWatched`. It was a full scan of 11.7k watches, 3× per click.
  24. - The episode/season faces return rows only after the page opened or closed a season (`collapsedChanged`). Otherwise the session sync's rows are the answer.
  25. ## Gate
  26. `TRACKER_GATE_SHOTS=/tmp/w062-shots TRACKER_GATE_PORT=8720 TRACKER_GATE_IDENT_PORT=8721 TRACKER_GATE_CHROME=8722-8726 TRACKER_GATE_TMDB_PORT=8727 node tests/browser.mjs`
  27. → **`311 passed, 0 failed`**
  28. - That is 266 from main, 35 from t26 and 10 new. The sync-tool expectation changed from +27 to +25 people.
  29. - I looked at the screenshots `/tmp/w062-shots/guest-person-{390,1280}`, `credits-series-all-390`.
  30. ## Real data
  31. Copy of Byrodin `storage/`, real TMDB, server on :8730. The copy is deleted and nothing of mine is running.
  32. **Jobs**
  33. - Details repair: 557/557 in 836 s.
  34. - Credits job: 5,867 titles, 0 failed.
  35. - The first process ended silently at ~22:41 after 1,961 titles. I found no cause and no OOM line visible.
  36. - The restart resumed the job and finished it (3,906 titles, 2,028 s).
  37. - The next start found nothing to do. 112,298 records, all with a short id.
  38. **People and RSS after boot**
  39. | | people | RSS |
  40. |---|---|---|
  41. | main fa1f9df, same copy | 15,157 | 4.3–4.5 GB |
  42. | merged, after the jobs, jobs off | 102,424 | 6.4–7.0 GB |
  43. | merged, after the jobs, jobs on (nothing to do) | 102,287 | 8.1–8.8 GB |
  44. | w061 (all guests as people) | 160,084 | — |
  45. - I did not reproduce w061's "4.9 GB with 160k people". Today's main alone already boots at 4.3 GB.
  46. - **RSS curve during the jobs** (sampled every minute, `/tmp/w062/rss.log` on Loreana): 1.2–6.3 GB, swinging. Twice it dropped by GBs around a 5 s pause.
  47. **Pages and clicks**
  48. - Picard: 202 cast (94 of them lazy guests) + 45 crew. Full load 201–342 ms; the first after boot took 2.3 s.
  49. - Superman (movie): 117–173 ms.
  50. - Guest click (Stephanie Czajkowski): created (short id `401md`) and filled from TMDB (18 films) in 0.74–1.3 s. Afterwards 29–66 ms.
  51. - **Watch click** (page clock, click → answer):
  52. - Picard: 159–174 ms (was 184–200).
  53. - The Simpsons: 156–214 ms (was 276–731). Payload 15 kB, was 29 kB.
  54. - Follow: 119–221 ms.
  55. - About 1 click in 6 took 550–970 ms (the runtime pauses).
  56. - Screenshots on Loreana, looked at: `/tmp/w062/real/{Star-Trek-Picard,Superman}{,-credits}-{390,1280}.png`, `guest-person-{390,1280}.png`.
  57. ## Docs
  58. - README: new section "What it does (mission 018 (old 062))", the gate notes, a deploy bullet, the Data section, the Files table.
  59. - STATUS: a new top entry (deploy timing, what to watch, how to repeat).
  60. ## Open points
  61. 1. Deploy. On the first start the repair takes ~14 min, then the credits job ~50 min. Watch `docker stats`: expect about 2× RSS at boot.
  62. 2. There are still 102k people (6.8× before), mostly movie casts. If that is too much memory, the next step is to make a movie's cast after the first N lazy too (not built: the mission said to keep the main cast).
  63. 3. Hybriel issues for the architect:
  64. - RSS swings by GBs.
  65. - Steps of about 5 s that block pages.
  66. - The silent process end in run 1.
  67. - About 120 ms per session face inside hl:web's re-mount and sync. This is the floor for watch clicks.
  68. 4. Adult titles no longer show a migrated cast.

Branches

Latest commits

  • 9448d643tracker#35 follow-up (mission 033): TVmaze 'Running' is labelled 'Returning', or 'Airing' while a non-special episode of the two newest seasons is released within today +-7 days (data unchanged); gate fixtures Running/Airing/Aired + a special; browser 366/0, kinds 32/0, franchises 52/0, pager 229/0, check-theme 0mre
  • 03ec792ftracker#38 (mission 033): pagination goes exactly to the clicked page — tilelist read the clicked button's text after pagination.hl's own handler had rebuilt the buttons (real clicks only); now li.current, else the button's own text; new gate tests/pager.mjs (5 lists x 11 pages, 390/1280, real + script clicks, Back/Forward) 229/0; browser 365/0, kinds 32/0, franchises 52/0, check-theme 0mre
  • 96ba683adeploy.sh: a gate without a 'passed,' line (check-theme) no longer ends the scriptmre
  • eb3b9205tracker: report 031mre
  • 9b5d2e89tracker mission 031: README (What it does, Test: four gates + the #32 checks, Files: theme/, new pages), STATUS (real copy, A/B load, how to repeat, open points), LOGmre
  • 39950e4ctracker#32 (mission 031): the WorldAPI theme (theme/ vendored verbatim from layouts.worldapi.org 85b5654; styles.hl inherits it: accent green-dark, type colours 1-6; own base/header rules, row lines, genre-pill and inverted-button frames removed, the season foldable keeps its line; check-theme 21 -> 0, 4th deploy gate; main actions class primary) and the #32 header (theme AppHeader/MainMenu/UserMenu/Sidebar/ContentFirst: desktop brand, search, Series|Shows|Movies|Genres|People, user icon with Unwatched..Settings, Logout; signed out the ident selector, phone the iD icon dropdown; phone menu in the sidebar overlay; marked entry by :has); /find -> /search/<q>, /genres, /people(/<letter>), /settings; main { ContentFirst { slot } } works around the hl:web one-line slot bug; gates 365/0, 32/0, 52/0, check-theme 0mre
  • a386dc92tracker: reports 029 + 030mre
  • 71e0fd7dtracker missions 029 + 030: README (What it does, Files, gate count), STATUS (real-copy numbers, how to repeat, open points), LOGmre
  • d36ea6eatracker#34 + #35 (mission 030): Follow directly under the poster, as wide as the poster (show.hl, styles.hl); the status pill next to a series' title — TVmaze's status (new tvmazeStatus, stored by the sync's TVmaze merge) else TMDB's, TVmaze Ended + TMDB Canceled = Canceled, inverted (filled, dark text, no border), green running / yellow pending / red canceled / muted ended (shows.hl statusOf); the daily delta asks TVmaze's status of an unfollowed series TVmaze's change list names (dailysync.hl syncRunStep, sync.hl syncTvmazeStatus); the status backfill after the details repair (backfill.hl, jobs.hl statusTick; resumable, 550 ms per TVmaze request); gates 354/0, 32/0, 52/0mre
  • 7d7d4487tracker#33 (mission 029): reduced titles — every title TMDB's details never went through this app (no detailsAt, no tmdbSync) is incomplete (shows.hl isIncomplete; the old tracker's migrated rows passed #26's test: 5,697 non-adult on the live copy, 691 series without seasons); the repair job does the visibly reduced first (shows.hl missingParts), the page completes one on open; a title TMDB has no poster for (The Remaining) shows the placeholder; tools/count-incomplete.hl; gate fixtures stand for synced titles (tmdbSync), tests/seed-reduced.hl + #33 checks; gates 347/0, 32/0, 52/0mre
  • 661c2592tracker: report 028mre
  • 27c916fatracker mission 028: README ("Code order", the new file map), STATUS (counts before/after, tests, how to repeat, open), LOGmre
  • d924f398tracker mission 028: comments name the new files (sync.hl, dailysync.hl, backfill.hl, credits.hl, jobs.hl, images.hl …); tools/ref-params.py + tools/lambda-audit.py also scan lib/ (they globbed the root only), lambda-audit counts a plain `x = p` alias like `let x = p`mre
  • 2e89b968tracker mission 028 (code order) 5/5 let: `let` only where a variable is reassigned — 667 never-reassigned lets became plain declarations (project.hl, lib/, components/, tools/, tests/); kept: 264 in loop bodies (a plain declaration there is 'Cannot reassign' on the 2nd pass), 234 reassigned, 27 whose name is also a member/outer/free name (a plain write would rebind it); tools/let-audit.py decides and fixes (README 'Code order'); tests/realdata-m028.{sh,mjs} = the page-output diff on a real copy; gates 342/0, 32/0, 52/0, real-copy pages identicalmre
  • 54796ff2tracker mission 028 (code order) 4/5 thin faces + last copies: the show page's check/follow faces call lib/watches.hl toggleWatched / toggleSeasonWatched (seasonAllWatched moved there) and lib/follows.hl toggleFollowed; both logins (header selector face, /login/callback) share lib/users.hl userOfCode; todayStr/listOf copies in components and the export readers copied into tools/migrate.hl + tools/old-short-ids.hl now once (lib/util.hl, lib/export.hl); gates 342/0, 32/0, 52/0; old-short-ids output byte-identical, migrate output identicalmre
  • 06b078e3tracker mission 028 (code order) 3/5 project.hl is the map: config, routes, wiring and a feature → file index (914 → 258 lines); the background jobs (daily sync run, backfills, details repair, credits job, merge, short ids, collection seed) moved unchanged into lib/jobs.hl (a class: their state is reassigned every step, a static cannot be; one instance made after the server), the login callback into lib/users.hl, poster/photo serving into lib/images.hl, the /shows/<slug> rule into lib/shows.hl showsMovedPath; route handlers are thin wrappers; gates 342/0, 32/0, 52/0, real-copy pages identicalmre
  • 94716fd2tracker mission 028 (code order) 2/5 util + topics: lib/util.hl holds envOr, storageDir, postersDir, profilesDir, newId, hexDigits, todayStr, dateOr, textOr, hasId, listOr, firstOf, sortDesc once (were copied into up to 5 files); tmdbsync.hl split into tmdb.hl (TMDB/TVmaze requests), sync.hl (one title's sync), sync-helpers.hl, backfill.hl; details.hl split into details.hl, credits.hl, credits-helpers.hl (isIncomplete to shows.hl); search-helpers.hl (words, query, ranking, slugs); collections.hl (the TMDB collection seed, out of franchises.hl); deltasync.hl renamed dailysync.hl; no behaviour change: gates 342/0, 32/0, 52/0, real-copy pages identicalmre
  • 186079b0tracker mission 028 (code order) 1/5 move: every root .hl except project.hl into lib/ (styles.hl into components/), import paths only; gates 342/0, 32/0, 52/0; real-copy pages identicalmre
  • 4f47f181tracker: report 027mre
  • dc1d4be4tracker mission 027: Hybriel master 06617221 vendored (plugin allocator fixes 3a781359 + 413f60e4); real copy RSS through first-start jobs + 400 loads flat ~2.55 GB (190aa11d 2.3 -> 5.6 GB), page times <= 1.1x; gates 342/0, 32/0, 52/0mre