gitoriaLog in with ident

tracker

All repositories: gitoria

ReadmeCodePull requestsReleasesTicketsSettings
Commit9448d6439448d643tracker#35 follow-up (mission 033): TVmaze 'Running' is labelled 'Returning', or 'Airing' while a non-special episode of the two newest seasons is released within today +-7 days (data unchanged); gate fixtures Running/Airing/Aired + a special; browser 366/0, kinds 32/0, franchises 52/0, pager 229/0, check-theme 0mre9448d643/components/timelineedit.hl

6.6 KB

  1. // components/timelineedit.hl — `/timelines/:slug/edit` (tracker.worldapi.org#19, mission 066): the creator's editor of ONE
  2. // timeline — its franchise (a row of chips: None + every franchise; a tap attaches it), its titles in their in-world order
  3. // (↑ / ↓ move one place, ✕ removes), and "Add titles": our database as you type (search.hl's index), "Add" puts the title at
  4. // the end. Mobile first: one column, big tap targets. Only the creator (franchises.hl isEditorSession) sees the controls; every
  5. // face checks it again.
  6. //
  7. // HYBRIEL TRAPS (as components/search.hl, hybriel#121/#122): no member reads both the route param and `session` — the
  8. // timeline's data come from `slug` alone, the editor state from `session` alone; every list is replaced whole with the
  9. // face's answer, never appended to.
  10. parent './main.hl'
  11. import { appTitle } from '../project.hl'
  12. import { isEditorSession, editPageOf, addToTimeline, removeFromTimeline, moveInTimeline, setTimelineFranchise, editSearch } from '../lib/franchises.hl'
  13. static editorOf = (&session) => { return isEditorSession(session) }
  14. static startOf = (&slug) => { return editPageOf(slug) }
  15. slug = null
  16. session = null
  17. isEditor = editorOf(session)
  18. notEditor = isEditor == false
  19. start = startOf(slug)
  20. found = start.found
  21. notFound = start.found == false
  22. timelineId = start.id
  23. name = start.name
  24. viewHref = start.viewHref
  25. rows = start.rows
  26. hasRows = rows.length > 0
  27. noRows = rows.length == 0
  28. countText = rows.length == 1 ? '1 title' : rows.length + ' titles'
  29. chips = start.chips
  30. results = []
  31. hasResults = results.length > 0
  32. searchNote = ''
  33. hasSearchNote = searchNote != ''
  34. message = ''
  35. hasMessage = message != ''
  36. __title = found ? 'Edit ' + name + ' — ' + appTitle : appTitle
  37. View {
  38. timelineEditPage { "data-timeline" = timelineId
  39. if (notFound) {
  40. h1 { "Not found" }
  41. p { "This timeline doesn't exist." }
  42. }
  43. if (found) {
  44. franchisesHead {
  45. h1 { class = "typed" typeWord { class = "type-word type-timeline" "Timeline" } typeSep { "|" } typeName { name } }
  46. a { id = "timeline-view" class = "button" href = viewHref "View" }
  47. }
  48. if (notEditor) { p { id = "edit-refused" class = "muted" "Only the creator can edit franchises and timelines." } }
  49. if (isEditor) {
  50. if (hasMessage) { p { id = "edit-message" class = "message" message } }
  51. editSection {
  52. h2 { class = "film-heading" "Franchise" }
  53. chipRow { id = "franchise-chips"
  54. for (c of chips) { button { type = "button" class = c.cls value = c.id c.name on click(e) { emit pickFranchise(c.id) } } }
  55. }
  56. a { class = "edit-new-franchise" href = "/franchises/edit" "New franchise …" }
  57. }
  58. editSection {
  59. h2 { class = "film-heading" "Titles in timeline order" }
  60. p { class = "muted list-count" countText }
  61. if (noRows) { p { class = "muted" "No titles yet — add some below." } }
  62. if (hasRows) {
  63. editRows { id = "edit-rows"
  64. for (row of rows) {
  65. editRow { "data-show" = row.id
  66. editPos { row.pos }
  67. img { class = "film-poster" src = row.posterUrl alt = "" }
  68. filmText {
  69. filmTitle { row.title }
  70. filmMeta { span { row.typeLabel } }
  71. }
  72. button { type = "button" class = row.upClass value = "up" title = "Move up" "aria-label" = "Move up" "↑" on click(e) { emit moveRow(row.id, -1) } }
  73. button { type = "button" class = row.downClass value = "down" title = "Move down" "aria-label" = "Move down" "↓" on click(e) { emit moveRow(row.id, 1) } }
  74. button { type = "button" class = "quiet mv rm" value = "remove" title = "Remove" "aria-label" = "Remove" "✕" on click(e) { emit removeRow(row.id) } }
  75. }
  76. }
  77. }
  78. }
  79. }
  80. editSection {
  81. h2 { class = "film-heading" "Add titles" }
  82. input { id = "ted-search" type = "search" placeholder = "Search our movies and series" autocomplete = "off" "aria-label" = "Search titles" on input(e) { emit searchTyped(e) } }
  83. if (hasSearchNote) { p { id = "ted-note" class = "muted" searchNote } }
  84. if (hasResults) {
  85. editRows { id = "ted-results"
  86. for (r of results) {
  87. editRow { "data-show" = r.id
  88. img { class = "film-poster" src = r.posterUrl alt = "" }
  89. filmText {
  90. filmTitle { r.title }
  91. filmMeta { span { r.typeLabel } }
  92. }
  93. button { type = "button" class = "inverted add" value = r.id "Add" on click(e) { emit addRow(r.id) } }
  94. }
  95. }
  96. }
  97. }
  98. }
  99. }
  100. }
  101. }
  102. }
  103. on pickFranchise(franchiseId) {
  104. let r = emit server tedSetFranchise(timelineId, '' + franchiseId)
  105. if (r == null || r.error != null) { message = r != null ? r.error : 'Could not save it.' return null }
  106. message = ''
  107. chips = r.chips
  108. }
  109. on moveRow(showId, delta) {
  110. let r = emit server tedMove(timelineId, '' + showId, delta)
  111. if (r == null || r.error != null) { message = r != null ? r.error : 'Could not save it.' return null }
  112. message = ''
  113. rows = r.rows
  114. }
  115. on removeRow(showId) {
  116. let r = emit server tedRemove(timelineId, '' + showId)
  117. if (r == null || r.error != null) { message = r != null ? r.error : 'Could not save it.' return null }
  118. message = ''
  119. rows = r.rows
  120. }
  121. on addRow(showId) {
  122. let r = emit server tedAdd(timelineId, '' + showId)
  123. if (r == null || r.error != null) { message = r != null ? r.error : 'Could not save it.' return null }
  124. message = ''
  125. rows = r.rows
  126. // the added title leaves the results (it is in the timeline now)
  127. left = []
  128. for (x of results) { if (x.id != showId) { left.push(x) } }
  129. results = left
  130. }
  131. on searchTyped(e) {
  132. v = e.target.value
  133. let r = emit server tedSearch(timelineId, v)
  134. if (r == null || document.getElementById('ted-search').value != v) { return null }
  135. results = r.rows
  136. searchNote = v.trim() == '' ? '' : r.note
  137. }
  138. // ---- the faces (unique names; the trailing `session` is the server's) ----
  139. on server tedSetFranchise(timelineId, franchiseId, session) {
  140. if (!isEditorSession(session)) { return { error = 'only the creator can do that' } }
  141. return setTimelineFranchise(timelineId, franchiseId)
  142. }
  143. on server tedMove(timelineId, showId, delta, session) {
  144. if (!isEditorSession(session)) { return { error = 'only the creator can do that' } }
  145. return moveInTimeline(timelineId, showId, delta)
  146. }
  147. on server tedRemove(timelineId, showId, session) {
  148. if (!isEditorSession(session)) { return { error = 'only the creator can do that' } }
  149. return removeFromTimeline(timelineId, showId)
  150. }
  151. on server tedAdd(timelineId, showId, session) {
  152. if (!isEditorSession(session)) { return { error = 'only the creator can do that' } }
  153. return addToTimeline(timelineId, showId)
  154. }
  155. // the search is our public database (like /search) — no session
  156. on server tedSearch(timelineId, text) {
  157. return editSearch(timelineId, text)
  158. }

Branches

Latest commits

  • 9448d643tracker#35 follow-up (mission 033): TVmaze 'Running' is labelled 'Returning', or 'Airing' while a non-special episode of the two newest seasons is released within today +-7 days (data unchanged); gate fixtures Running/Airing/Aired + a special; browser 366/0, kinds 32/0, franchises 52/0, pager 229/0, check-theme 0mre
  • 03ec792ftracker#38 (mission 033): pagination goes exactly to the clicked page — tilelist read the clicked button's text after pagination.hl's own handler had rebuilt the buttons (real clicks only); now li.current, else the button's own text; new gate tests/pager.mjs (5 lists x 11 pages, 390/1280, real + script clicks, Back/Forward) 229/0; browser 365/0, kinds 32/0, franchises 52/0, check-theme 0mre
  • 96ba683adeploy.sh: a gate without a 'passed,' line (check-theme) no longer ends the scriptmre
  • eb3b9205tracker: report 031mre
  • 9b5d2e89tracker mission 031: README (What it does, Test: four gates + the #32 checks, Files: theme/, new pages), STATUS (real copy, A/B load, how to repeat, open points), LOGmre
  • 39950e4ctracker#32 (mission 031): the WorldAPI theme (theme/ vendored verbatim from layouts.worldapi.org 85b5654; styles.hl inherits it: accent green-dark, type colours 1-6; own base/header rules, row lines, genre-pill and inverted-button frames removed, the season foldable keeps its line; check-theme 21 -> 0, 4th deploy gate; main actions class primary) and the #32 header (theme AppHeader/MainMenu/UserMenu/Sidebar/ContentFirst: desktop brand, search, Series|Shows|Movies|Genres|People, user icon with Unwatched..Settings, Logout; signed out the ident selector, phone the iD icon dropdown; phone menu in the sidebar overlay; marked entry by :has); /find -> /search/<q>, /genres, /people(/<letter>), /settings; main { ContentFirst { slot } } works around the hl:web one-line slot bug; gates 365/0, 32/0, 52/0, check-theme 0mre
  • a386dc92tracker: reports 029 + 030mre
  • 71e0fd7dtracker missions 029 + 030: README (What it does, Files, gate count), STATUS (real-copy numbers, how to repeat, open points), LOGmre
  • d36ea6eatracker#34 + #35 (mission 030): Follow directly under the poster, as wide as the poster (show.hl, styles.hl); the status pill next to a series' title — TVmaze's status (new tvmazeStatus, stored by the sync's TVmaze merge) else TMDB's, TVmaze Ended + TMDB Canceled = Canceled, inverted (filled, dark text, no border), green running / yellow pending / red canceled / muted ended (shows.hl statusOf); the daily delta asks TVmaze's status of an unfollowed series TVmaze's change list names (dailysync.hl syncRunStep, sync.hl syncTvmazeStatus); the status backfill after the details repair (backfill.hl, jobs.hl statusTick; resumable, 550 ms per TVmaze request); gates 354/0, 32/0, 52/0mre
  • 7d7d4487tracker#33 (mission 029): reduced titles — every title TMDB's details never went through this app (no detailsAt, no tmdbSync) is incomplete (shows.hl isIncomplete; the old tracker's migrated rows passed #26's test: 5,697 non-adult on the live copy, 691 series without seasons); the repair job does the visibly reduced first (shows.hl missingParts), the page completes one on open; a title TMDB has no poster for (The Remaining) shows the placeholder; tools/count-incomplete.hl; gate fixtures stand for synced titles (tmdbSync), tests/seed-reduced.hl + #33 checks; gates 347/0, 32/0, 52/0mre
  • 661c2592tracker: report 028mre
  • 27c916fatracker mission 028: README ("Code order", the new file map), STATUS (counts before/after, tests, how to repeat, open), LOGmre
  • d924f398tracker mission 028: comments name the new files (sync.hl, dailysync.hl, backfill.hl, credits.hl, jobs.hl, images.hl …); tools/ref-params.py + tools/lambda-audit.py also scan lib/ (they globbed the root only), lambda-audit counts a plain `x = p` alias like `let x = p`mre
  • 2e89b968tracker mission 028 (code order) 5/5 let: `let` only where a variable is reassigned — 667 never-reassigned lets became plain declarations (project.hl, lib/, components/, tools/, tests/); kept: 264 in loop bodies (a plain declaration there is 'Cannot reassign' on the 2nd pass), 234 reassigned, 27 whose name is also a member/outer/free name (a plain write would rebind it); tools/let-audit.py decides and fixes (README 'Code order'); tests/realdata-m028.{sh,mjs} = the page-output diff on a real copy; gates 342/0, 32/0, 52/0, real-copy pages identicalmre
  • 54796ff2tracker mission 028 (code order) 4/5 thin faces + last copies: the show page's check/follow faces call lib/watches.hl toggleWatched / toggleSeasonWatched (seasonAllWatched moved there) and lib/follows.hl toggleFollowed; both logins (header selector face, /login/callback) share lib/users.hl userOfCode; todayStr/listOf copies in components and the export readers copied into tools/migrate.hl + tools/old-short-ids.hl now once (lib/util.hl, lib/export.hl); gates 342/0, 32/0, 52/0; old-short-ids output byte-identical, migrate output identicalmre
  • 06b078e3tracker mission 028 (code order) 3/5 project.hl is the map: config, routes, wiring and a feature → file index (914 → 258 lines); the background jobs (daily sync run, backfills, details repair, credits job, merge, short ids, collection seed) moved unchanged into lib/jobs.hl (a class: their state is reassigned every step, a static cannot be; one instance made after the server), the login callback into lib/users.hl, poster/photo serving into lib/images.hl, the /shows/<slug> rule into lib/shows.hl showsMovedPath; route handlers are thin wrappers; gates 342/0, 32/0, 52/0, real-copy pages identicalmre
  • 94716fd2tracker mission 028 (code order) 2/5 util + topics: lib/util.hl holds envOr, storageDir, postersDir, profilesDir, newId, hexDigits, todayStr, dateOr, textOr, hasId, listOr, firstOf, sortDesc once (were copied into up to 5 files); tmdbsync.hl split into tmdb.hl (TMDB/TVmaze requests), sync.hl (one title's sync), sync-helpers.hl, backfill.hl; details.hl split into details.hl, credits.hl, credits-helpers.hl (isIncomplete to shows.hl); search-helpers.hl (words, query, ranking, slugs); collections.hl (the TMDB collection seed, out of franchises.hl); deltasync.hl renamed dailysync.hl; no behaviour change: gates 342/0, 32/0, 52/0, real-copy pages identicalmre
  • 186079b0tracker mission 028 (code order) 1/5 move: every root .hl except project.hl into lib/ (styles.hl into components/), import paths only; gates 342/0, 32/0, 52/0; real-copy pages identicalmre
  • 4f47f181tracker: report 027mre
  • dc1d4be4tracker mission 027: Hybriel master 06617221 vendored (plugin allocator fixes 3a781359 + 413f60e4); real copy RSS through first-start jobs + 400 loads flat ~2.55 GB (190aa11d 2.3 -> 5.6 GB), page times <= 1.1x; gates 342/0, 32/0, 52/0mre