gitoriaLog in with ident

tracker

All repositories: gitoria

ReadmeCodePull requestsReleasesTicketsSettings
Commit8751adb88751adb8tracker: report 032mre8751adb8/reports/025-my-series-speed-small-fixes.md

6.0 KB

  1. # Report 025 (w074) — tracker#30 /my/series speed + three small fixes
  2. **Commit**: `2667da0` on main in loreana:/media/STORAGE/projects/tracker.worldapi.org (parent 3909810). Not pushed, not deployed. I never read `.env`. Every process was killed by its PID, and nothing of mine is still running.
  3. ## 1. #30: the /my/ pages after the jobs
  4. - **Cause**: the rows were already small. The cost was in reading the data behind them on every load:
  5. - /my/series fetched every followed title's whole record (cast + crew) plus one episode per watch (11,648 fetches).
  6. - /my/unwatched and /my/schedule fetched every season and episode of all 128 followed titles.
  7. - After the jobs the heap is large, so all that allocation drives the byte-triggered GC.
  8. - **Fix**: three slim caches in `shows.hl`, plus a kept watch set in `watches.hl`:
  9. - `cardOf`: a title's card (title, year, kind, link, poster).
  10. - `episodeRowsOf`: a title's episodes as `{ id s e title release }`.
  11. - `episodeKeyOf`: a watched episode's `{ show s e }`.
  12. - `watchedSetOf`: the user's watched set, kept until that user's next watch.
  13. - They are filled at boot (~460 ms) and refreshed in `catalog.hl refreshCatalogShow`, which every writer of a title already calls.
  14. - The poster tiles use them too (`/`, `/movies`, `/series`, genres).
  15. - **Times** on a real copy, signed in as az5b2, 20 loads per page, `server / browser ms` averages:
  16. | page | before, after jobs | after, after jobs | after, fresh |
  17. |---|---|---|---|
  18. | /my/series | 1767 / 1927 | **63 / 123** | 53 / 113 |
  19. | /my/shows | 3539 / 3397 | 39 / 73 | 64 / 73 |
  20. | /my/unwatched | 4063 / 4540 | **176 / 329** | 172 / 336 |
  21. | /my/movies | 114 / 155 | 8 / 38 | 6 / 36 |
  22. | /my/schedule | 4518 / 4543 | 14 / 52 | 13 / 58 |
  23. | RSS during the bench | 4.7 → 21.3 GB peak | 1.36 → 1.68 GB | 1.83 → 2.13 GB |
  24. - The copy was taken while live was in the middle of its seed. Its first start therefore ran a forced delta sync of 316–333 titles plus the remaining 1,802 seed movies, about 20 minutes in total.
  25. - So "before" here is 1.8 s, not the 4.4 s from report 024, because the heap was smaller.
  26. - The before process was benched while the after process was running its jobs. Its RSS growth pushed Loreana into swap, and 3 GB of the after process was swapped out during its own bench.
  27. - **Output is unchanged**: the page text of /my/series, /my/shows, /my/unwatched, /my/movies, /my/schedule, /series and / is identical in three comparisons:
  28. - before vs after, both fresh;
  29. - the after process that ran the jobs vs a fresh process on the same storage, so the cache refresh after 333 synced titles is right.
  30. - **One catch on the way**: my first version of "last watched" went through the title's seasons and showed Reacher S02E08 instead of S03E08. The creator's S03 watches sit on a migrated duplicate season that is not in the title's season list. It now goes by the watched episode's own `show`, as before.
  31. ## 2. The timeline page shows its name once
  32. The name is now only in the h1. The list head keeps the count and the sort toggle.
  33. ## 3. The franchise widget on a phone
  34. - The widget is now inside the show header:
  35. - on a phone, right under the poster and before the genres, plot and cast;
  36. - from 40rem, in the right column under the title and links.
  37. - It is hidden when the title is in no timeline.
  38. ## 4. Star Trek: First Contact
  39. - **The tmdbId is not wrong.** 199 is the movie (`/movie/199`).
  40. - **Cause**: the old #9 sync asked `/tv/199` (the bug fixed in mission 006). It stored that TV show's overview ("Kabuhayang Swak na Swak…"), status `Ended` and seasonsCount/episodesCount 0 on the movie. Neither the migration nor the search import caused it.
  41. - **Fix in the repair path**: `details.hl hasTvLeftovers` treats a movie that has season or episode counts as incomplete.
  42. - The details repair asks `/movie/<id>` again and drops the counts, so it runs only once per record.
  43. - On the copy: `details repair: start, 1 incomplete titles` → `done 1/1 complete=1`. The record now has the movie's text, status Released and counts null.
  44. - It is the only such movie in the real data.
  45. - **Shared TMDB ids**: 0 records share a TMDB id with a different title (`tools/count-tmdb-ids.hl`).
  46. ## 5. Gates
  47. - `TRACKER_GATE_SHOTS=/tmp/w074/shots TRACKER_GATE_PORT=8720 TRACKER_GATE_IDENT_PORT=8721 TRACKER_GATE_CHROME=8722-8726 TRACKER_GATE_TMDB_PORT=8727 node tests/browser.mjs` → `327 passed, 0 failed` (+2: the TV-leftover repair, and the next start has nothing to do).
  48. - The same env with `tests/franchises.mjs` → `52 passed, 0 failed` (+2: widget position at 390 and 1280; the timeline name once).
  49. - The same env with `tests/kinds.mjs` → `32 passed, 0 failed`.
  50. ## Screenshots (on Loreana, I looked at them)
  51. - Gate: `/tmp/w074/{shots,fr,kinds}`.
  52. - Real data: `/tmp/w074/real/`:
  53. - First Contact full page at 390: the widget is under the poster. At 1280 it is under the title.
  54. - The A Kid in… timeline: the name appears once.
  55. - /my/series, /my/shows, /my/unwatched, /my/movies at 390 and 1280: no page scrolls sideways.
  56. ## Docs
  57. - README: new section for mission 025, the gate counts, and the Files table.
  58. - STATUS: new top entry with the table and "How to repeat" (`tests/realdata-074.sh` and `tests/realdata-074-bench.mjs`).
  59. - LOG.md: one line.
  60. ## Open points
  61. 1. **Duplicate title records**: 68 type+tmdbId pairs are each held by 2–6 records of the SAME title.
  62. - Mostly adult filmography titles, but also Archive 81 ×6, Ally McBeal ×2 and The Flight Attendant ×2.
  63. - Some of them share one slug.
  64. - Some import path creates them. This needs its own ticket.
  65. 2. **One process per storage**: the caches assume it, as `watches.hl` already does.
  66. 3. **Deploy**: boot is about 0.5 s longer (the cache warm-up). First Contact gets repaired on the first start after the deploy.
  67. ## Hybriel
  68. No new bugs. Two things the workers' guide should mention:
  69. - `let x = map[k]` deep-copies the value: 3.7 ms per 20k-row list. Returning `map[k]` from a function does not copy.
  70. - Inside an object literal, a key set earlier shadows a variable of the same name: `{ s = e.seasonNumber e = e.episodeNumber title = e.title }` fails because `e` is the number by then.

Branches

Latest commits

  • 8751adb8tracker: report 032mre
  • 9bce1f65tracker mission 032: STATUS gate files + the hour-boundary flakemre
  • 718bfb89tracker#37 (mission 032): /people = everyone, last updated first (updatedAt stamped by the person fill; view built at boot, touched people first at once), photo + name tiles (person colour) with the /movies pagination, /people/<letter> removed; photo = our file, tmdbProfile, a cast/crew entry's profile (in-memory map at boot), else the new 'no photo' placeholder; new cast/crew/created_by people keep tmdbProfile; search people rows with the photo; /settings = the heading only; util.hl sortDesc starts from sorted runs (same result, 105k: 1.6 s -> 0.15 s); gates 369/0, 32/0, 52/0, check-theme 0; README/STATUS/LOGmre
  • 96ba683adeploy.sh: a gate without a 'passed,' line (check-theme) no longer ends the scriptmre
  • eb3b9205tracker: report 031mre
  • 9b5d2e89tracker mission 031: README (What it does, Test: four gates + the #32 checks, Files: theme/, new pages), STATUS (real copy, A/B load, how to repeat, open points), LOGmre
  • 39950e4ctracker#32 (mission 031): the WorldAPI theme (theme/ vendored verbatim from layouts.worldapi.org 85b5654; styles.hl inherits it: accent green-dark, type colours 1-6; own base/header rules, row lines, genre-pill and inverted-button frames removed, the season foldable keeps its line; check-theme 21 -> 0, 4th deploy gate; main actions class primary) and the #32 header (theme AppHeader/MainMenu/UserMenu/Sidebar/ContentFirst: desktop brand, search, Series|Shows|Movies|Genres|People, user icon with Unwatched..Settings, Logout; signed out the ident selector, phone the iD icon dropdown; phone menu in the sidebar overlay; marked entry by :has); /find -> /search/<q>, /genres, /people(/<letter>), /settings; main { ContentFirst { slot } } works around the hl:web one-line slot bug; gates 365/0, 32/0, 52/0, check-theme 0mre
  • a386dc92tracker: reports 029 + 030mre
  • 71e0fd7dtracker missions 029 + 030: README (What it does, Files, gate count), STATUS (real-copy numbers, how to repeat, open points), LOGmre
  • d36ea6eatracker#34 + #35 (mission 030): Follow directly under the poster, as wide as the poster (show.hl, styles.hl); the status pill next to a series' title — TVmaze's status (new tvmazeStatus, stored by the sync's TVmaze merge) else TMDB's, TVmaze Ended + TMDB Canceled = Canceled, inverted (filled, dark text, no border), green running / yellow pending / red canceled / muted ended (shows.hl statusOf); the daily delta asks TVmaze's status of an unfollowed series TVmaze's change list names (dailysync.hl syncRunStep, sync.hl syncTvmazeStatus); the status backfill after the details repair (backfill.hl, jobs.hl statusTick; resumable, 550 ms per TVmaze request); gates 354/0, 32/0, 52/0mre
  • 7d7d4487tracker#33 (mission 029): reduced titles — every title TMDB's details never went through this app (no detailsAt, no tmdbSync) is incomplete (shows.hl isIncomplete; the old tracker's migrated rows passed #26's test: 5,697 non-adult on the live copy, 691 series without seasons); the repair job does the visibly reduced first (shows.hl missingParts), the page completes one on open; a title TMDB has no poster for (The Remaining) shows the placeholder; tools/count-incomplete.hl; gate fixtures stand for synced titles (tmdbSync), tests/seed-reduced.hl + #33 checks; gates 347/0, 32/0, 52/0mre
  • 661c2592tracker: report 028mre
  • 27c916fatracker mission 028: README ("Code order", the new file map), STATUS (counts before/after, tests, how to repeat, open), LOGmre
  • d924f398tracker mission 028: comments name the new files (sync.hl, dailysync.hl, backfill.hl, credits.hl, jobs.hl, images.hl …); tools/ref-params.py + tools/lambda-audit.py also scan lib/ (they globbed the root only), lambda-audit counts a plain `x = p` alias like `let x = p`mre
  • 2e89b968tracker mission 028 (code order) 5/5 let: `let` only where a variable is reassigned — 667 never-reassigned lets became plain declarations (project.hl, lib/, components/, tools/, tests/); kept: 264 in loop bodies (a plain declaration there is 'Cannot reassign' on the 2nd pass), 234 reassigned, 27 whose name is also a member/outer/free name (a plain write would rebind it); tools/let-audit.py decides and fixes (README 'Code order'); tests/realdata-m028.{sh,mjs} = the page-output diff on a real copy; gates 342/0, 32/0, 52/0, real-copy pages identicalmre
  • 54796ff2tracker mission 028 (code order) 4/5 thin faces + last copies: the show page's check/follow faces call lib/watches.hl toggleWatched / toggleSeasonWatched (seasonAllWatched moved there) and lib/follows.hl toggleFollowed; both logins (header selector face, /login/callback) share lib/users.hl userOfCode; todayStr/listOf copies in components and the export readers copied into tools/migrate.hl + tools/old-short-ids.hl now once (lib/util.hl, lib/export.hl); gates 342/0, 32/0, 52/0; old-short-ids output byte-identical, migrate output identicalmre
  • 06b078e3tracker mission 028 (code order) 3/5 project.hl is the map: config, routes, wiring and a feature → file index (914 → 258 lines); the background jobs (daily sync run, backfills, details repair, credits job, merge, short ids, collection seed) moved unchanged into lib/jobs.hl (a class: their state is reassigned every step, a static cannot be; one instance made after the server), the login callback into lib/users.hl, poster/photo serving into lib/images.hl, the /shows/<slug> rule into lib/shows.hl showsMovedPath; route handlers are thin wrappers; gates 342/0, 32/0, 52/0, real-copy pages identicalmre
  • 94716fd2tracker mission 028 (code order) 2/5 util + topics: lib/util.hl holds envOr, storageDir, postersDir, profilesDir, newId, hexDigits, todayStr, dateOr, textOr, hasId, listOr, firstOf, sortDesc once (were copied into up to 5 files); tmdbsync.hl split into tmdb.hl (TMDB/TVmaze requests), sync.hl (one title's sync), sync-helpers.hl, backfill.hl; details.hl split into details.hl, credits.hl, credits-helpers.hl (isIncomplete to shows.hl); search-helpers.hl (words, query, ranking, slugs); collections.hl (the TMDB collection seed, out of franchises.hl); deltasync.hl renamed dailysync.hl; no behaviour change: gates 342/0, 32/0, 52/0, real-copy pages identicalmre
  • 186079b0tracker mission 028 (code order) 1/5 move: every root .hl except project.hl into lib/ (styles.hl into components/), import paths only; gates 342/0, 32/0, 52/0; real-copy pages identicalmre
  • 4f47f181tracker: report 027mre