tracker

3.7 KB

1. # w063 — tracker#29: /my/unwatched checks look "active" (mission 019 (old 063))
3. **Commit**: `fa1f9df` on main in loreana:/media/STORAGE/projects/tracker.worldapi.org. It is not pushed and not deployed. I did not touch tracker-wt26.
5. ## Cause
6. This is **not a code regression** of #23 / f14db67.
7. - **Classes are right**: on the real-data copy, signed in as az5b2, all 1,287 checks on /my/unwatched have the class `checkicon regular`. Their computed fill is transparent, both on a fresh load and after a client-side navigation. The live CSS is the same as HEAD.
8. - **The look was the problem**: the "inverted" unwatched check from #11 (outline circle with an outline check) was drawn in the **accent** colour. A whole page of those reads as ticked.
9. - **Fix** (`styles.hl`): the unwatched circle and check are now **muted grey** (`colorTextMuted`, rgb(145,150,155)). They turn accent only under the pointer.
10. - A watched check is unchanged: a solid accent disc with a dark check.
11. - The #11 shape stays: it is not a bare empty circle, which the creator rejected in #11.
13. ## Pages checked
14. - **Same fix applies** (they share the same CSS): /my/unwatched, the show page's seasons and episodes, and the movie page.
15. - **/my/schedule**: it has no checks.
16. - **/my/movies**: only watched movies get a mark (#24). An unwatched movie has no mark, so there is no empty check on that page.
18. ## Gate
19. `mkdir -p /tmp/w063/shots; TRACKER_GATE_SHOTS=/tmp/w063/shots TRACKER_GATE_PORT=8720 TRACKER_GATE_IDENT_PORT=8721 TRACKER_GATE_CHROME=8722-8726 TRACKER_GATE_TMDB_PORT=8727 node tests/browser.mjs`
20. → `266 passed, 0 failed` (was 259).
21. - **How a check is tested**: the new `checkLook(sel)` measures a real check on the page; the hidden-copy check is removed. It moves the pointer off the check, then reads the circle's computed fill and stroke, the check's stroke, and whether the check is the topmost element. It also takes the screenshot pixel inside the disc. Each check must then pass as `lookEmpty` or `lookSolid`.
22. - **Where**:
23. - /my/unwatched: both rows.
24. - Show page: an unwatched episode and season, a watched episode, and the #23 mixed state.
25. - Movie page: both states.
26. - /my/movies: the watched mark.
27. - **Negative test**: run against the old `styles.hl`, the gate fails exactly 4 of the new checks, all on the accent stroke.
28. - **Pre-existing quirk**: the gate crashes if the `TRACKER_GATE_SHOTS` directory does not exist, so `mkdir` it first.
30. ## Real data
31. - **Copy**: I took Byrodin's `storage/` at about 19:30. The ssh from Loreana to Byrodin was refused, so I piped the tar from Byrodin into Loreana instead.
32. - **Run**: server on :8730, `REAL_OUT=/tmp/w063/real node tests/realdata-063.mjs`.
33. - **/my/unwatched**: 1,287 checks, all regular, muted and unfilled. Full load took 1,913 ms at 390 px and 1,050 ms at 1280 px.
34. - **Other pages**: Foundation has 11 muted and 2 solid checks. The Star Trek: First Contact movie check is muted. /my/movies has no marks, because the creator has no watched movie.
35. - **Click**: one click took the list from 1,287 to 1,286 rows in 1.5 s, and the row stayed gone after a reload. There were 0 console problems.
36. - **Cleanup**: the copy, the sessions and the server are gone, and ports 8720–8731 are free.
38. ## Screenshots (looked at)
39. - **Real data**: Loreana `/tmp/w063/real/my-unwatched-390.png` and `my-unwatched-1280.png`, plus `show-*` and `my-movies-*`. The grey outline checks are clearly different from the solid accent discs on Foundation.
40. - **Gate**: `/tmp/w063/shots/`.
42. ## Open points
43. 1. Deploy.
44. 2. The ticket asks for "empty" checks. I kept #11's outline-with-check shape and made it grey instead of accent. If the creator wants a bare empty circle, that reverses their #11 note. It would be a one-line CSS change plus the `lookEmpty` gate check.
45. 3. There were no Hybriel issues.