gitoriaLog in with ident

tracker

All repositories: gitoria

ReadmeCodePull requestsReleasesTicketsSettings
Commit7d4b293d7d4b293dtracker#40: "Franchises" in the main menu (desktop header after People, phone sidebar) → /franchises, marked on franchise and timeline pages; gates 365/0, 32/0, 53/0, 24/0, check-theme 0mre7d4b293d/lib/backfill.hl

8.9 KB

  1. // lib/backfill.hl — THE BACKFILLS of a title's flags (adult, kind; tracker#35 TVmaze's status), one title per step (run by jobs.hl `backfillTick` / `kindTick`, on the
  2. // app's clock like the daily sync). Mission 028: out of tmdbsync.hl.
  3. //
  4. // ADULT FLAG (mission 054): every details answer carries TMDB's `adult` — the sync, the import (search.hl) and the
  5. // BACKFILL below store it as show.adult (true/false; null = not known yet, hidden from the public lists, shows.hl
  6. // isPublicTitle). THE BACKFILL (`backfillTitle`, run one title per step by jobs.hl `backfillTick`, like the daily sync):
  7. // GET <TMDB_BASE_URL>/movie|tv/<tmdbId>?append_to_response=external_ids ONE request: adult, poster_path, imdb/tvdb id
  8. // GET <TMDB_IMAGE_URL>/w342<poster_path> the poster when its file is missing (not for
  9. // an adult title — never shown, mission 056)
  10. // for every title whose adult flag is unknown (no TVmaze, no seasons — the daily sync does those for followed shows). A
  11. // title TMDB answers 404 for (or one without tmdbId) gets `adultCheck` = why, stays unknown (hidden) and is not asked again.
  12. //
  13. // KIND (tracker.worldapi.org#21, mission 068): a TV details answer carries TMDB's `type` (Scripted, Miniseries, Documentary,
  14. // Reality, Talk Show, News, Video) — the sync, the adult backfill and the import (search.hl) store it as show.tmdbType and the
  15. // title's kind ('series' | 'show', shows.hl kindOfTitle) as show.kind. THE KIND BACKFILL (`kindTitle`, run one title per step by
  16. // jobs.hl `kindTick`, after the adult backfill, on the same clock):
  17. // a title with a show genre (Reality / Talk / News) kind = 'show' from the stored data, NO request
  18. // any other TV title without `kind` GET <TMDB_BASE_URL>/tv/<tmdbId> ONE request → tmdbType + kind
  19. // A 404 (or no tmdbId) stores the genre's answer ('series') with `kindCheck` = why; it is not asked again. Resumes after a
  20. // restart (the queue = every TV title still without `kind`).
  21. //
  22. // TVMAZE STATUS (tracker#35, mission 030): the sync stores TVmaze's status (Running / Ended / To Be Determined / In Development)
  23. // as show.tvmazeStatus whenever it merges TVmaze's episodes (sync.hl, followed series and every completion). THE STATUS BACKFILL
  24. // (`tvmazeStatusTitle`, one series per step by jobs.hl `statusTick`, after the details repair, part of that job):
  25. // every series with a TVmaze id and no tvmazeStatus GET <TVMAZE_BASE_URL>/shows/<tvmzId> ONE TVmaze request, 550 ms pause
  26. // A 404 (or no status in the answer) stores `tvmazeStatusCheck` = why; it is not asked again. Resumes after a restart.
  27. import { showsTable, kindOfTitle, hasShowGenre } from './shows.hl'
  28. import { textOr, hasId } from './util.hl'
  29. import { tmdbGet, externalIdsFor, syncPoster, adultOf, tvmazeShow } from './tmdb.hl'
  30. // ---- the adult backfill (mission 054) ------------------------------------------------------------
  31. // a title still to ask: its adult flag unknown, it has a tmdbId and TMDB never answered "no such title" for it
  32. static needsAdultFlag = (&show) => { return show.adult != true && show.adult != false && show.adultCheck == null && show.tmdbId != null && show.mergedInto == null }
  33. // the ids of every title the backfill still has to ask, in table order (read once when the backfill starts — so after a
  34. // restart it goes on with what is left)
  35. static adultBackfillQueue = () => {
  36. out = []
  37. for (s of showsTable.find(null, null)) { if (needsAdultFlag(s)) { out.push(s.id) } }
  38. return out
  39. }
  40. // ONE title: one TMDB details request (adult, poster_path, external ids) + its poster when the file is missing. Answers
  41. // { requests (TMDB API requests: what the pause counts), posters, adult (true / false / null), ids, errors, error, retry
  42. // (a passing failure: no answer, 429, 5xx — ask again later) }. A 404 marks the title `adultCheck` (never asked again).
  43. static backfillTitle = (&showId) => {
  44. out = { requests = 0 posters = 0 adult = null ids = 0 errors = 0 error = '' retry = false }
  45. show = showsTable.fetch(showId)
  46. if (show == null || !needsAdultFlag(show)) { return out }
  47. movie = show.type == 'movie'
  48. out.requests = 1
  49. details = tmdbGet((movie ? '/movie/' : '/tv/') + show.tmdbId + '?append_to_response=external_ids')
  50. if (details.failed != null) {
  51. out.errors = 1
  52. out.error = show.title + ': ' + details.failed
  53. if (details.status == 404) {
  54. show.adultCheck = 'TMDB 404'
  55. showsTable.update(show.id, show)
  56. } else { out.retry = true }
  57. return out
  58. }
  59. ids = externalIdsFor(show, details.external_ids, !movie, false)
  60. out.ids = ids.filled
  61. out.adult = adultOf(details)
  62. // an ADULT title's poster is never shown publicly → not downloaded (mission 056: ~170 MB of the live data); its flag and
  63. // ids are stored as for any other title
  64. let poster = { saved = 0 failed = null image = show.image tmdbPoster = show.tmdbPoster }
  65. if (out.adult != true) { poster = syncPoster(show, details.poster_path) }
  66. out.posters = poster.saved
  67. if (poster.failed != null) { out.errors = out.errors + 1 out.error = show.title + ': ' + poster.failed }
  68. if (out.adult == null) { show.adultCheck = 'TMDB gave no adult flag' } else { show.adult = out.adult }
  69. if (!movie && textOr(details.type) != null) { show.tmdbType = details.type show.kind = kindOfTitle(details.type, show.genres) }
  70. show.imdbId = ids.imdbId
  71. show.tvdbId = ids.tvdbId
  72. show.image = poster.image
  73. show.tmdbPoster = poster.tmdbPoster
  74. if (showsTable.update(show.id, show) == null) { out.errors = out.errors + 1 out.error = show.title + ': not updated: ' + showsTable.lastError() }
  75. return out
  76. }
  77. // ---- the kind backfill (tracker.worldapi.org#21, mission 068) ----------------------------------------------------
  78. // a TV title whose kind is not stored yet
  79. static needsKind = (&show) => { return show.type == 'series' && show.kind != 'series' && show.kind != 'show' && show.mergedInto == null }
  80. // the ids of every TV title still without a kind, in table order (read once when the backfill starts — it resumes)
  81. static kindBackfillQueue = () => {
  82. out = []
  83. for (s of showsTable.find(null, null)) { if (needsKind(s)) { out.push(s.id) } }
  84. return out
  85. }
  86. // ONE title → { requests (TMDB API requests: what the pause counts), kind ('series' | 'show' | null), fromGenre, errors, error,
  87. // retry (a passing failure: no answer, 429, 5xx) }
  88. static kindTitle = (&showId) => {
  89. out = { requests = 0 kind = null fromGenre = false errors = 0 error = '' retry = false }
  90. show = showsTable.fetch(showId)
  91. if (show == null || !needsKind(show)) { return out }
  92. if (hasShowGenre(show.genres) || show.tmdbId == null) {
  93. out.fromGenre = true
  94. show.kind = kindOfTitle(null, show.genres)
  95. if (!hasShowGenre(show.genres)) { show.kindCheck = 'no tmdbId' }
  96. } else {
  97. out.requests = 1
  98. details = tmdbGet('/tv/' + show.tmdbId)
  99. if (details.failed != null) {
  100. out.errors = 1
  101. out.error = show.title + ': ' + details.failed
  102. if (details.status != 404) { out.retry = true return out }
  103. show.kindCheck = 'TMDB 404'
  104. show.kind = kindOfTitle(null, show.genres)
  105. } else {
  106. if (textOr(details.type) != null) { show.tmdbType = details.type } else { show.kindCheck = 'TMDB gave no type' }
  107. show.kind = kindOfTitle(textOr(details.type), show.genres)
  108. }
  109. }
  110. out.kind = show.kind
  111. if (showsTable.update(show.id, show) == null) { out.errors = out.errors + 1 out.error = show.title + ': not updated: ' + showsTable.lastError() }
  112. return out
  113. }
  114. // ---- the TVmaze status backfill (tracker#35, mission 030) -------------------------------------------------------------
  115. // a live, non-adult series with a TVmaze id whose TVmaze status is not stored and was not given up on
  116. static needsTvmazeStatus = (&show) => {
  117. return show.type == 'series' && hasId(show.tvmzId) && show.tvmazeStatus == null && show.tvmazeStatusCheck == null && show.adult != true && show.mergedInto == null
  118. }
  119. // the ids of every such series, in table order (read once when the backfill starts — it resumes)
  120. static tvmazeStatusQueue = () => {
  121. out = []
  122. for (s of showsTable.find(null, null)) { if (needsTvmazeStatus(s)) { out.push(s.id) } }
  123. return out
  124. }
  125. // ONE series → { tvmazeRequests (what the pause counts), status (or null), errors, error, retry (a passing failure) }
  126. static tvmazeStatusTitle = (&showId) => {
  127. out = { requests = 0 tvmazeRequests = 0 status = null errors = 0 error = '' retry = false }
  128. show = showsTable.fetch(showId)
  129. if (show == null || !needsTvmazeStatus(show)) { return out }
  130. out.tvmazeRequests = 1
  131. got = tvmazeShow(show.tvmzId)
  132. if (got.failed != null) {
  133. out.errors = 1
  134. out.error = show.title + ': ' + got.failed
  135. if (got.notFound != true) { out.retry = true return out }
  136. show.tvmazeStatusCheck = 'TVmaze 404'
  137. } else if (got.status == null) { show.tvmazeStatusCheck = 'TVmaze gave no status' } else {
  138. show.tvmazeStatus = got.status
  139. out.status = got.status
  140. }
  141. if (showsTable.update(show.id, show) == null) { out.errors = out.errors + 1 out.error = show.title + ': not updated: ' + showsTable.lastError() }
  142. return out
  143. }

Branches

Latest commits

  • 7d4b293dtracker#40: "Franchises" in the main menu (desktop header after People, phone sidebar) → /franchises, marked on franchise and timeline pages; gates 365/0, 32/0, 53/0, 24/0, check-theme 0mre
  • 93dfb0batracker#40 (mission 034): the curated franchises — data/franchises.json (17 franchises, 31 timelines, 285 TMDB titles, movies + series, in-universe/release order, 12 TMDB collections attached); lib/franchiseseed.hl + jobs.hl franchiseSeedTick (last start job, imports missing titles via details.hl importWithCredits = the search's Add, one per step paced, then one build; franchiseseed.db: editor changes win, the creator's same-name franchise adopted / timeline left alone, 404 remembered, resumable, idempotent); timeline heads 'N titles · in-universe order' (orderKind) and wrap on a phone; series pages show the widget; new gate tests/franchiseseed.mjs (5th in deploy.sh), the others run with TRACKER_FRANCHISE_SEED=0; gates 365/0, 32/0, 52/0, 24/0, check-theme 0; real copy 196 imported, 0 failed, 7 min, restart unchanged=31mre
  • 96ba683adeploy.sh: a gate without a 'passed,' line (check-theme) no longer ends the scriptmre
  • eb3b9205tracker: report 031mre
  • 9b5d2e89tracker mission 031: README (What it does, Test: four gates + the #32 checks, Files: theme/, new pages), STATUS (real copy, A/B load, how to repeat, open points), LOGmre
  • 39950e4ctracker#32 (mission 031): the WorldAPI theme (theme/ vendored verbatim from layouts.worldapi.org 85b5654; styles.hl inherits it: accent green-dark, type colours 1-6; own base/header rules, row lines, genre-pill and inverted-button frames removed, the season foldable keeps its line; check-theme 21 -> 0, 4th deploy gate; main actions class primary) and the #32 header (theme AppHeader/MainMenu/UserMenu/Sidebar/ContentFirst: desktop brand, search, Series|Shows|Movies|Genres|People, user icon with Unwatched..Settings, Logout; signed out the ident selector, phone the iD icon dropdown; phone menu in the sidebar overlay; marked entry by :has); /find -> /search/<q>, /genres, /people(/<letter>), /settings; main { ContentFirst { slot } } works around the hl:web one-line slot bug; gates 365/0, 32/0, 52/0, check-theme 0mre
  • a386dc92tracker: reports 029 + 030mre
  • 71e0fd7dtracker missions 029 + 030: README (What it does, Files, gate count), STATUS (real-copy numbers, how to repeat, open points), LOGmre
  • d36ea6eatracker#34 + #35 (mission 030): Follow directly under the poster, as wide as the poster (show.hl, styles.hl); the status pill next to a series' title — TVmaze's status (new tvmazeStatus, stored by the sync's TVmaze merge) else TMDB's, TVmaze Ended + TMDB Canceled = Canceled, inverted (filled, dark text, no border), green running / yellow pending / red canceled / muted ended (shows.hl statusOf); the daily delta asks TVmaze's status of an unfollowed series TVmaze's change list names (dailysync.hl syncRunStep, sync.hl syncTvmazeStatus); the status backfill after the details repair (backfill.hl, jobs.hl statusTick; resumable, 550 ms per TVmaze request); gates 354/0, 32/0, 52/0mre
  • 7d7d4487tracker#33 (mission 029): reduced titles — every title TMDB's details never went through this app (no detailsAt, no tmdbSync) is incomplete (shows.hl isIncomplete; the old tracker's migrated rows passed #26's test: 5,697 non-adult on the live copy, 691 series without seasons); the repair job does the visibly reduced first (shows.hl missingParts), the page completes one on open; a title TMDB has no poster for (The Remaining) shows the placeholder; tools/count-incomplete.hl; gate fixtures stand for synced titles (tmdbSync), tests/seed-reduced.hl + #33 checks; gates 347/0, 32/0, 52/0mre
  • 661c2592tracker: report 028mre
  • 27c916fatracker mission 028: README ("Code order", the new file map), STATUS (counts before/after, tests, how to repeat, open), LOGmre
  • d924f398tracker mission 028: comments name the new files (sync.hl, dailysync.hl, backfill.hl, credits.hl, jobs.hl, images.hl …); tools/ref-params.py + tools/lambda-audit.py also scan lib/ (they globbed the root only), lambda-audit counts a plain `x = p` alias like `let x = p`mre
  • 2e89b968tracker mission 028 (code order) 5/5 let: `let` only where a variable is reassigned — 667 never-reassigned lets became plain declarations (project.hl, lib/, components/, tools/, tests/); kept: 264 in loop bodies (a plain declaration there is 'Cannot reassign' on the 2nd pass), 234 reassigned, 27 whose name is also a member/outer/free name (a plain write would rebind it); tools/let-audit.py decides and fixes (README 'Code order'); tests/realdata-m028.{sh,mjs} = the page-output diff on a real copy; gates 342/0, 32/0, 52/0, real-copy pages identicalmre
  • 54796ff2tracker mission 028 (code order) 4/5 thin faces + last copies: the show page's check/follow faces call lib/watches.hl toggleWatched / toggleSeasonWatched (seasonAllWatched moved there) and lib/follows.hl toggleFollowed; both logins (header selector face, /login/callback) share lib/users.hl userOfCode; todayStr/listOf copies in components and the export readers copied into tools/migrate.hl + tools/old-short-ids.hl now once (lib/util.hl, lib/export.hl); gates 342/0, 32/0, 52/0; old-short-ids output byte-identical, migrate output identicalmre
  • 06b078e3tracker mission 028 (code order) 3/5 project.hl is the map: config, routes, wiring and a feature → file index (914 → 258 lines); the background jobs (daily sync run, backfills, details repair, credits job, merge, short ids, collection seed) moved unchanged into lib/jobs.hl (a class: their state is reassigned every step, a static cannot be; one instance made after the server), the login callback into lib/users.hl, poster/photo serving into lib/images.hl, the /shows/<slug> rule into lib/shows.hl showsMovedPath; route handlers are thin wrappers; gates 342/0, 32/0, 52/0, real-copy pages identicalmre
  • 94716fd2tracker mission 028 (code order) 2/5 util + topics: lib/util.hl holds envOr, storageDir, postersDir, profilesDir, newId, hexDigits, todayStr, dateOr, textOr, hasId, listOr, firstOf, sortDesc once (were copied into up to 5 files); tmdbsync.hl split into tmdb.hl (TMDB/TVmaze requests), sync.hl (one title's sync), sync-helpers.hl, backfill.hl; details.hl split into details.hl, credits.hl, credits-helpers.hl (isIncomplete to shows.hl); search-helpers.hl (words, query, ranking, slugs); collections.hl (the TMDB collection seed, out of franchises.hl); deltasync.hl renamed dailysync.hl; no behaviour change: gates 342/0, 32/0, 52/0, real-copy pages identicalmre
  • 186079b0tracker mission 028 (code order) 1/5 move: every root .hl except project.hl into lib/ (styles.hl into components/), import paths only; gates 342/0, 32/0, 52/0; real-copy pages identicalmre
  • 4f47f181tracker: report 027mre
  • dc1d4be4tracker mission 027: Hybriel master 06617221 vendored (plugin allocator fixes 3a781359 + 413f60e4); real copy RSS through first-start jobs + 400 loads flat ~2.55 GB (190aa11d 2.3 -> 5.6 GB), page times <= 1.1x; gates 342/0, 32/0, 52/0mre