gitoriaLog in with ident

tracker

All repositories: gitoria

ReadmeCodePull requestsReleasesTicketsSettings
Commit7565a8637565a863tracker: LOG timemre7565a863/reports/015-tracker-filmography-complete.md

5.1 KB

  1. # w059 — tracker#26: filmography titles complete
  2. **Commit**: `25a50bc` on branch `t26` (worktree loreana:/media/STORAGE/projects/tracker-wt26, based on main 1704ec4). Not pushed, not merged, not deployed. main untouched.
  3. ## What the filmography stored (vs a full import)
  4. - `people.hl addMinimalTitle` (#16) stores title, year/release, overview, type, tmdbId, adult, genres, language, and only that one person as cast.
  5. - It stores no poster, no seasons/episodes, no imdb/tvdb/tvmaze ids, no homepage/tagline/status and no `tmdbSync`. Nothing ever completed these records, so the page stayed that way.
  6. - A search import (`importTitle` + `syncShow`) has all of that, but no cast either.
  7. - The live copy has 321 such titles.
  8. ## Built
  9. - **`details.hl` `completeStep`**:
  10. - Step 1 is one TMDB request: `/movie|tv/<id>?append_to_response=external_ids,credits|aggregate_credits`. It stores the fields and the cast (TMDB's first 20, adult people left out). People we don't have yet get a new person record (slug, search entry); their page fills on the first visit.
  11. - A movie is complete after step 1 (ids + poster).
  12. - A series then continues in steps through `tmdbsync.hl syncShowPart`: one step per ≤ 300 episodes of seasons, then a last step for ids, the TVmaze lookup + merge and the poster.
  13. - `detailsAt` marks a title complete. `detailsCheck` marks TMDB 404 and adult titles, which are never asked again.
  14. - **Show page** (`components/show.hl`): an incomplete title shows what it has plus shimmer skeletons (poster, cast line, 3 season rows for a series). An invisible probe calls the sessionless face `showComplete` step by step until it is done. The last answer replaces the skeletons without a reload.
  15. - **Details repair** (`project.hl repairTick`):
  16. - At start it queues every incomplete title that is not adult and does one step per clock tick.
  17. - It paces itself with `pauseMsAfter` (TMDB ≤ 40 / 10 s, TVmaze ≤ 20 / 10 s) and runs only after the adult backfill and never during the daily sync.
  18. - It resumes after a restart and retries passing failures up to 2 times.
  19. - Env: `TRACKER_REPAIR` (default on), `TRACKER_REPAIR_LOG_EVERY`, `TRACKER_REPAIR_FAST` (gate only).
  20. - New titles from a filmography get `minimal = true`.
  21. - Adult titles are never completed: the public face refuses them and the repair skips them.
  22. ## Gate
  23. ```
  24. TRACKER_GATE_SHOTS=/tmp/w059/shots TRACKER_GATE_PORT=8754 TRACKER_GATE_IDENT_PORT=8755 TRACKER_GATE_CHROME=8756-8758 TRACKER_GATE_TMDB_PORT=8759 node tests/browser.mjs
  25. 231 passed, 0 failed
  26. ```
  27. - 214 → 231 checks. The new ones cover:
  28. - artist page → click a new movie → skeleton → full page without a reload, one TMDB request;
  29. - the series case in 4 steps;
  30. - the new cast person's page and search entry;
  31. - the repair: 82 titles, stopped after 6, resumes, 404s marked, adult title never asked, pages < 1.2 s meanwhile, a 3rd start has nothing to do.
  32. - The offline home check now expects 6 series instead of 5, because Person Series has released episodes once it is completed.
  33. ## Real data (copy of live `storage/`, real TMDB; copy deleted afterwards)
  34. **Opening a title** (ms from the click):
  35. - **Skeleton:** shown after 178–258 ms.
  36. - **Movies:** complete after 642–712 ms.
  37. - **Series:** complete after 1262–1361 ms.
  38. - **Other requests meanwhile:** at most 586 ms.
  39. - **Reload afterwards:** complete at once, 157–205 ms.
  40. - **Biggest titles:** The Late Show (4,252 episodes) took 11.4 s in 23 steps, with other requests waiting at most 1.3 s.
  41. **Repair**: 321/321 complete, 0 failed, +638 seasons, +16,528 episodes, 299 posters, 5,196 cast entries, 787 TMDB + 218 TVmaze requests, 507 s.
  42. - Page latency meanwhile: median 0.13 s, p99 1.03 s, max 2.35 s.
  43. - The next start logs "nothing to do".
  44. - My first version did one title per step; the Late Show then blocked the server for 10.7 s. That is why series are now split into steps.
  45. **Screenshots** (looked at), on Loreana:
  46. - `/tmp/w059/real/`: `{movie,series}-{skeleton,complete,reload}-{390,1280}.png`, `repaired-*-{390,1280}.png`, `direct-*-1280.png`
  47. - gate: `/tmp/w059/shots/{title,series}-skeleton-1280.png`
  48. ## Merge notes for main (mission 014 (old 058) touches `components/show.hl`)
  49. - **`components/show.hl`:** my changes are additive:
  50. - 1 import;
  51. - 2 statics (`completingOf`, `completedPageOf`, which calls `buildRows(show, null, cl)`);
  52. - 4 members after `adultShow`;
  53. - the View blocks (poster skeleton, cast skeleton, `showLoading`);
  54. - the handler `completeTick`;
  55. - the face `showComplete`.
  56. - **`tmdbsync.hl`:** `syncMovie` gained a third parameter `pre`, and `syncShow` now calls `syncShowPart(id, null, null)`.
  57. - **Gate:** new fixtures, startServer defaults (`TRACKER_REPAIR=0`, `TRACKER_DETAILS_PART_EPISODES=1`), and the #16 block's "added title" check is replaced by the #26 block.
  58. - **Deploy:** on live the repair waits for the adult backfill (~80 min), then takes ~9 min.
  59. ## Open points
  60. 1. Merge and deploy.
  61. 2. Search imports still have no cast.
  62. 3. Titles added while the app runs are only completed when opened or at the next start.
  63. 4. After a client-side click, the title page keeps the person page's scroll position (hl:web behaviour, not new).
  64. ## Hybriel issues
  65. None new.

Branches

Latest commits

  • 7565a863tracker: LOG timemre
  • b10f00c8tracker#39: double episodes — migrated episodes whose TMDB id TMDB replaced are adopted by their number in the sync (old id -> migratedTmdbId); merge.hl step 3 merges each season's doubles at start (keeper: most watches > synced > first; watches moved/parked; tombstones into mergedEpisodes, nothing deleted); tools/count-duplicate-episodes.hl; gate fixture + paths-m039; live copy 850 -> 0 in 64 s; gates 373/0, 32/0, 52/0mre
  • 8751adb8tracker: report 032mre
  • 9bce1f65tracker mission 032: STATUS gate files + the hour-boundary flakemre
  • 718bfb89tracker#37 (mission 032): /people = everyone, last updated first (updatedAt stamped by the person fill; view built at boot, touched people first at once), photo + name tiles (person colour) with the /movies pagination, /people/<letter> removed; photo = our file, tmdbProfile, a cast/crew entry's profile (in-memory map at boot), else the new 'no photo' placeholder; new cast/crew/created_by people keep tmdbProfile; search people rows with the photo; /settings = the heading only; util.hl sortDesc starts from sorted runs (same result, 105k: 1.6 s -> 0.15 s); gates 369/0, 32/0, 52/0, check-theme 0; README/STATUS/LOGmre
  • 96ba683adeploy.sh: a gate without a 'passed,' line (check-theme) no longer ends the scriptmre
  • eb3b9205tracker: report 031mre
  • 9b5d2e89tracker mission 031: README (What it does, Test: four gates + the #32 checks, Files: theme/, new pages), STATUS (real copy, A/B load, how to repeat, open points), LOGmre
  • 39950e4ctracker#32 (mission 031): the WorldAPI theme (theme/ vendored verbatim from layouts.worldapi.org 85b5654; styles.hl inherits it: accent green-dark, type colours 1-6; own base/header rules, row lines, genre-pill and inverted-button frames removed, the season foldable keeps its line; check-theme 21 -> 0, 4th deploy gate; main actions class primary) and the #32 header (theme AppHeader/MainMenu/UserMenu/Sidebar/ContentFirst: desktop brand, search, Series|Shows|Movies|Genres|People, user icon with Unwatched..Settings, Logout; signed out the ident selector, phone the iD icon dropdown; phone menu in the sidebar overlay; marked entry by :has); /find -> /search/<q>, /genres, /people(/<letter>), /settings; main { ContentFirst { slot } } works around the hl:web one-line slot bug; gates 365/0, 32/0, 52/0, check-theme 0mre
  • a386dc92tracker: reports 029 + 030mre
  • 71e0fd7dtracker missions 029 + 030: README (What it does, Files, gate count), STATUS (real-copy numbers, how to repeat, open points), LOGmre
  • d36ea6eatracker#34 + #35 (mission 030): Follow directly under the poster, as wide as the poster (show.hl, styles.hl); the status pill next to a series' title — TVmaze's status (new tvmazeStatus, stored by the sync's TVmaze merge) else TMDB's, TVmaze Ended + TMDB Canceled = Canceled, inverted (filled, dark text, no border), green running / yellow pending / red canceled / muted ended (shows.hl statusOf); the daily delta asks TVmaze's status of an unfollowed series TVmaze's change list names (dailysync.hl syncRunStep, sync.hl syncTvmazeStatus); the status backfill after the details repair (backfill.hl, jobs.hl statusTick; resumable, 550 ms per TVmaze request); gates 354/0, 32/0, 52/0mre
  • 7d7d4487tracker#33 (mission 029): reduced titles — every title TMDB's details never went through this app (no detailsAt, no tmdbSync) is incomplete (shows.hl isIncomplete; the old tracker's migrated rows passed #26's test: 5,697 non-adult on the live copy, 691 series without seasons); the repair job does the visibly reduced first (shows.hl missingParts), the page completes one on open; a title TMDB has no poster for (The Remaining) shows the placeholder; tools/count-incomplete.hl; gate fixtures stand for synced titles (tmdbSync), tests/seed-reduced.hl + #33 checks; gates 347/0, 32/0, 52/0mre
  • 661c2592tracker: report 028mre
  • 27c916fatracker mission 028: README ("Code order", the new file map), STATUS (counts before/after, tests, how to repeat, open), LOGmre
  • d924f398tracker mission 028: comments name the new files (sync.hl, dailysync.hl, backfill.hl, credits.hl, jobs.hl, images.hl …); tools/ref-params.py + tools/lambda-audit.py also scan lib/ (they globbed the root only), lambda-audit counts a plain `x = p` alias like `let x = p`mre
  • 2e89b968tracker mission 028 (code order) 5/5 let: `let` only where a variable is reassigned — 667 never-reassigned lets became plain declarations (project.hl, lib/, components/, tools/, tests/); kept: 264 in loop bodies (a plain declaration there is 'Cannot reassign' on the 2nd pass), 234 reassigned, 27 whose name is also a member/outer/free name (a plain write would rebind it); tools/let-audit.py decides and fixes (README 'Code order'); tests/realdata-m028.{sh,mjs} = the page-output diff on a real copy; gates 342/0, 32/0, 52/0, real-copy pages identicalmre
  • 54796ff2tracker mission 028 (code order) 4/5 thin faces + last copies: the show page's check/follow faces call lib/watches.hl toggleWatched / toggleSeasonWatched (seasonAllWatched moved there) and lib/follows.hl toggleFollowed; both logins (header selector face, /login/callback) share lib/users.hl userOfCode; todayStr/listOf copies in components and the export readers copied into tools/migrate.hl + tools/old-short-ids.hl now once (lib/util.hl, lib/export.hl); gates 342/0, 32/0, 52/0; old-short-ids output byte-identical, migrate output identicalmre
  • 06b078e3tracker mission 028 (code order) 3/5 project.hl is the map: config, routes, wiring and a feature → file index (914 → 258 lines); the background jobs (daily sync run, backfills, details repair, credits job, merge, short ids, collection seed) moved unchanged into lib/jobs.hl (a class: their state is reassigned every step, a static cannot be; one instance made after the server), the login callback into lib/users.hl, poster/photo serving into lib/images.hl, the /shows/<slug> rule into lib/shows.hl showsMovedPath; route handlers are thin wrappers; gates 342/0, 32/0, 52/0, real-copy pages identicalmre
  • 94716fd2tracker mission 028 (code order) 2/5 util + topics: lib/util.hl holds envOr, storageDir, postersDir, profilesDir, newId, hexDigits, todayStr, dateOr, textOr, hasId, listOr, firstOf, sortDesc once (were copied into up to 5 files); tmdbsync.hl split into tmdb.hl (TMDB/TVmaze requests), sync.hl (one title's sync), sync-helpers.hl, backfill.hl; details.hl split into details.hl, credits.hl, credits-helpers.hl (isIncomplete to shows.hl); search-helpers.hl (words, query, ranking, slugs); collections.hl (the TMDB collection seed, out of franchises.hl); deltasync.hl renamed dailysync.hl; no behaviour change: gates 342/0, 32/0, 52/0, real-copy pages identicalmre