gitoriaLog in with ident

tracker

All repositories: gitoria

ReadmeCodePull requestsReleasesTicketsSettings
Commit7565a8637565a863tracker: LOG timemre7565a863/lib/credits-helpers.hl

5.7 KB

  1. // lib/credits-helpers.hl — TMDB's credits answer read into ours (tracker.worldapi.org#28): the cast and crew entries of a
  2. // details answer (`credits` of a movie, `aggregate_credits` of a series), roles, episode counts, the crew jobs we show — no table,
  3. // no request. The rules are at the top of credits.hl. Mission 028: out of details.hl.
  4. import { env } from 'hl:proc'
  5. import { textOr, listOr } from './util.hl'
  6. // how many of TMDB's cast a title keeps (see the top; TRACKER_CAST_MAX) and how many people per crew job
  7. static castMax = env('TRACKER_CAST_MAX') != null ? toNumber(env('TRACKER_CAST_MAX')) : 300
  8. static crewMax = 30
  9. // a series' roles ([{ character, episode_count }]) as one text: "Mother / Lamia". tracker#28 (real data): TMDB's characters are
  10. // themselves " / "-joined and repeat across seasons ("Data / Lore", "Data", "Yvette Picard (uncredited)") — split, " (uncredited)"
  11. // dropped, each name once, at most `rolesMax` (a voice actor of The Simpsons has 30+), then " / …"
  12. static rolesMax = 4
  13. static rolesText = (&roles) => {
  14. names = []
  15. let more = false
  16. for (r of listOr(roles)) {
  17. let c = r != null ? textOr(r.character) : null
  18. if (c != null) {
  19. for (part of c.split(' / ')) {
  20. let n = part.replaceAll(' (uncredited)', '').trim()
  21. if (n != '' && !names.includes(n)) { if (names.length < rolesMax) { names.push(n) } else { more = true } }
  22. }
  23. }
  24. }
  25. return names.join(' / ') + (more ? ' / …' : '')
  26. }
  27. // a series' episodes of one person: TMDB's total_episode_count, else the sum of the roles' / jobs' counts
  28. static episodesOf = (&total, &parts) => {
  29. if (total != null && hlTypeName(total) == 'Number') { return total }
  30. let n = 0
  31. for (r of listOr(parts)) { if (r != null && r.episode_count != null && hlTypeName(r.episode_count) == 'Number') { n = n + r.episode_count } }
  32. return n
  33. }
  34. static personOk = (&c) => { return c != null && c.id != null && hlTypeName(c.id) == 'Number' && textOr(c.name) != null && c.adult != true }
  35. // TMDB's cast → [{ tmdbId, name, character, gender, episodes }], TMDB's order, at most castMax, adult people left out
  36. static castOf = (&d, &movie) => {
  37. src = movie ? (d.credits != null ? d.credits.cast : null) : (d.aggregate_credits != null ? d.aggregate_credits.cast : null)
  38. out = []
  39. for (c of listOr(src)) {
  40. if (out.length < castMax && personOk(c)) {
  41. let role = movie ? textOr(c.character) : rolesText(c.roles)
  42. out.push({ tmdbId = c.id name = c.name character = role != null ? role : '' gender = c.gender profile = textOr(c.profile_path) episodes = movie ? null : episodesOf(c.total_episode_count, c.roles) })
  43. }
  44. }
  45. return out
  46. }
  47. // a series' main cast is in at least this many episodes: half of the series' (rounded up), at most 10 (a season), at least 1
  48. static mainMinOf = (&d) => {
  49. n = d.number_of_episodes != null && hlTypeName(d.number_of_episodes) == 'Number' ? d.number_of_episodes : 0
  50. half = (n - n % 2) / 2 + n % 2
  51. if (half > 10) { return 10 }
  52. return half < 1 ? 1 : half
  53. }
  54. // the crew jobs we show: TMDB job → ours (the page's labels: components/show.hl crewLabels)
  55. static crewJobOf = (&job) => {
  56. if (job == 'Director') { return 'director' }
  57. if (job == 'Writer') { return 'writer' }
  58. if (job == 'Screenplay') { return 'screenplay' }
  59. if (job == 'Story') { return 'story' }
  60. if (job == 'Original Music Composer' || job == 'Composer' || job == 'Music') { return 'composer' }
  61. return null
  62. }
  63. static crewJobs = ['creator', 'director', 'writer', 'screenplay', 'story', 'composer']
  64. // keeps a job's list ordered by episodes (most first, equal ones in TMDB's order), at most crewMax (hand-written: no sort())
  65. static insertByEpisodes = (&list, &item) => {
  66. out = []
  67. let inserted = false
  68. for (x of list) {
  69. if (!inserted && item.episodes > x.episodes) { out.push(item) inserted = true }
  70. if (out.length < crewMax) { out.push(x) }
  71. }
  72. if (!inserted && out.length < crewMax) { out.push(item) }
  73. return out
  74. }
  75. // TMDB's crew (+ a series' created_by) → [{ tmdbId, name, job, gender, profile, episodes }], grouped by job in `crewJobs` order, one
  76. // entry per person and job
  77. static crewOf = (&d, &movie) => {
  78. byJob = {}
  79. seen = {}
  80. for (j of crewJobs) { byJob[j] = [] }
  81. if (!movie) {
  82. for (c of listOr(d.created_by)) {
  83. if (personOk(c) && seen['creator:' + c.id] != true && byJob['creator'].length < crewMax) {
  84. seen['creator:' + c.id] = true
  85. let l = byJob['creator']
  86. l.push({ tmdbId = c.id name = c.name job = 'creator' gender = c.gender profile = textOr(c.profile_path) episodes = 0 })
  87. byJob['creator'] = l
  88. }
  89. }
  90. }
  91. src = movie ? (d.credits != null ? d.credits.crew : null) : (d.aggregate_credits != null ? d.aggregate_credits.crew : null)
  92. for (c of listOr(src)) {
  93. if (personOk(c)) {
  94. // a movie's crew entry has one `job`; a series' has `jobs` [{ job, episode_count }]
  95. let jobs = movie ? [{ job = c.job episode_count = 0 }] : listOr(c.jobs)
  96. for (jb of jobs) {
  97. let ours = jb != null ? crewJobOf(jb.job) : null
  98. if (ours != null && seen[ours + ':' + c.id] != true) {
  99. seen[ours + ':' + c.id] = true
  100. let n = movie ? 0 : episodesOf(jb.episode_count, null)
  101. byJob[ours] = insertByEpisodes(byJob[ours], { tmdbId = c.id name = c.name job = ours gender = c.gender profile = textOr(c.profile_path) episodes = n })
  102. }
  103. }
  104. }
  105. }
  106. out = []
  107. for (j of crewJobs) { for (c of byJob[j]) { out.push(c) } }
  108. return out
  109. }
  110. static crewRoleOf = (&job) => {
  111. if (job == 'creator') { return 'Creator' }
  112. if (job == 'director') { return 'Director' }
  113. if (job == 'writer') { return 'Writer' }
  114. if (job == 'screenplay') { return 'Screenplay' }
  115. if (job == 'story') { return 'Story' }
  116. return 'Music'
  117. }
  118. // the answer carries credits (a details request with `credits` / `aggregate_credits` appended)
  119. static hasCredits = (&d, &movie) => { return d != null && (movie ? d.credits != null : d.aggregate_credits != null) }

Branches

Latest commits

  • 7565a863tracker: LOG timemre
  • b10f00c8tracker#39: double episodes — migrated episodes whose TMDB id TMDB replaced are adopted by their number in the sync (old id -> migratedTmdbId); merge.hl step 3 merges each season's doubles at start (keeper: most watches > synced > first; watches moved/parked; tombstones into mergedEpisodes, nothing deleted); tools/count-duplicate-episodes.hl; gate fixture + paths-m039; live copy 850 -> 0 in 64 s; gates 373/0, 32/0, 52/0mre
  • 8751adb8tracker: report 032mre
  • 9bce1f65tracker mission 032: STATUS gate files + the hour-boundary flakemre
  • 718bfb89tracker#37 (mission 032): /people = everyone, last updated first (updatedAt stamped by the person fill; view built at boot, touched people first at once), photo + name tiles (person colour) with the /movies pagination, /people/<letter> removed; photo = our file, tmdbProfile, a cast/crew entry's profile (in-memory map at boot), else the new 'no photo' placeholder; new cast/crew/created_by people keep tmdbProfile; search people rows with the photo; /settings = the heading only; util.hl sortDesc starts from sorted runs (same result, 105k: 1.6 s -> 0.15 s); gates 369/0, 32/0, 52/0, check-theme 0; README/STATUS/LOGmre
  • 96ba683adeploy.sh: a gate without a 'passed,' line (check-theme) no longer ends the scriptmre
  • eb3b9205tracker: report 031mre
  • 9b5d2e89tracker mission 031: README (What it does, Test: four gates + the #32 checks, Files: theme/, new pages), STATUS (real copy, A/B load, how to repeat, open points), LOGmre
  • 39950e4ctracker#32 (mission 031): the WorldAPI theme (theme/ vendored verbatim from layouts.worldapi.org 85b5654; styles.hl inherits it: accent green-dark, type colours 1-6; own base/header rules, row lines, genre-pill and inverted-button frames removed, the season foldable keeps its line; check-theme 21 -> 0, 4th deploy gate; main actions class primary) and the #32 header (theme AppHeader/MainMenu/UserMenu/Sidebar/ContentFirst: desktop brand, search, Series|Shows|Movies|Genres|People, user icon with Unwatched..Settings, Logout; signed out the ident selector, phone the iD icon dropdown; phone menu in the sidebar overlay; marked entry by :has); /find -> /search/<q>, /genres, /people(/<letter>), /settings; main { ContentFirst { slot } } works around the hl:web one-line slot bug; gates 365/0, 32/0, 52/0, check-theme 0mre
  • a386dc92tracker: reports 029 + 030mre
  • 71e0fd7dtracker missions 029 + 030: README (What it does, Files, gate count), STATUS (real-copy numbers, how to repeat, open points), LOGmre
  • d36ea6eatracker#34 + #35 (mission 030): Follow directly under the poster, as wide as the poster (show.hl, styles.hl); the status pill next to a series' title — TVmaze's status (new tvmazeStatus, stored by the sync's TVmaze merge) else TMDB's, TVmaze Ended + TMDB Canceled = Canceled, inverted (filled, dark text, no border), green running / yellow pending / red canceled / muted ended (shows.hl statusOf); the daily delta asks TVmaze's status of an unfollowed series TVmaze's change list names (dailysync.hl syncRunStep, sync.hl syncTvmazeStatus); the status backfill after the details repair (backfill.hl, jobs.hl statusTick; resumable, 550 ms per TVmaze request); gates 354/0, 32/0, 52/0mre
  • 7d7d4487tracker#33 (mission 029): reduced titles — every title TMDB's details never went through this app (no detailsAt, no tmdbSync) is incomplete (shows.hl isIncomplete; the old tracker's migrated rows passed #26's test: 5,697 non-adult on the live copy, 691 series without seasons); the repair job does the visibly reduced first (shows.hl missingParts), the page completes one on open; a title TMDB has no poster for (The Remaining) shows the placeholder; tools/count-incomplete.hl; gate fixtures stand for synced titles (tmdbSync), tests/seed-reduced.hl + #33 checks; gates 347/0, 32/0, 52/0mre
  • 661c2592tracker: report 028mre
  • 27c916fatracker mission 028: README ("Code order", the new file map), STATUS (counts before/after, tests, how to repeat, open), LOGmre
  • d924f398tracker mission 028: comments name the new files (sync.hl, dailysync.hl, backfill.hl, credits.hl, jobs.hl, images.hl …); tools/ref-params.py + tools/lambda-audit.py also scan lib/ (they globbed the root only), lambda-audit counts a plain `x = p` alias like `let x = p`mre
  • 2e89b968tracker mission 028 (code order) 5/5 let: `let` only where a variable is reassigned — 667 never-reassigned lets became plain declarations (project.hl, lib/, components/, tools/, tests/); kept: 264 in loop bodies (a plain declaration there is 'Cannot reassign' on the 2nd pass), 234 reassigned, 27 whose name is also a member/outer/free name (a plain write would rebind it); tools/let-audit.py decides and fixes (README 'Code order'); tests/realdata-m028.{sh,mjs} = the page-output diff on a real copy; gates 342/0, 32/0, 52/0, real-copy pages identicalmre
  • 54796ff2tracker mission 028 (code order) 4/5 thin faces + last copies: the show page's check/follow faces call lib/watches.hl toggleWatched / toggleSeasonWatched (seasonAllWatched moved there) and lib/follows.hl toggleFollowed; both logins (header selector face, /login/callback) share lib/users.hl userOfCode; todayStr/listOf copies in components and the export readers copied into tools/migrate.hl + tools/old-short-ids.hl now once (lib/util.hl, lib/export.hl); gates 342/0, 32/0, 52/0; old-short-ids output byte-identical, migrate output identicalmre
  • 06b078e3tracker mission 028 (code order) 3/5 project.hl is the map: config, routes, wiring and a feature → file index (914 → 258 lines); the background jobs (daily sync run, backfills, details repair, credits job, merge, short ids, collection seed) moved unchanged into lib/jobs.hl (a class: their state is reassigned every step, a static cannot be; one instance made after the server), the login callback into lib/users.hl, poster/photo serving into lib/images.hl, the /shows/<slug> rule into lib/shows.hl showsMovedPath; route handlers are thin wrappers; gates 342/0, 32/0, 52/0, real-copy pages identicalmre
  • 94716fd2tracker mission 028 (code order) 2/5 util + topics: lib/util.hl holds envOr, storageDir, postersDir, profilesDir, newId, hexDigits, todayStr, dateOr, textOr, hasId, listOr, firstOf, sortDesc once (were copied into up to 5 files); tmdbsync.hl split into tmdb.hl (TMDB/TVmaze requests), sync.hl (one title's sync), sync-helpers.hl, backfill.hl; details.hl split into details.hl, credits.hl, credits-helpers.hl (isIncomplete to shows.hl); search-helpers.hl (words, query, ranking, slugs); collections.hl (the TMDB collection seed, out of franchises.hl); deltasync.hl renamed dailysync.hl; no behaviour change: gates 342/0, 32/0, 52/0, real-copy pages identicalmre