gitoriaLog in with ident

tracker

All repositories: gitoria

ReadmeCodePull requestsReleasesTicketsSettings
Commit718bfb89718bfb89tracker#37 (mission 032): /people = everyone, last updated first (updatedAt stamped by the person fill; view built at boot, touched people first at once), photo + name tiles (person colour) with the /movies pagination, /people/<letter> removed; photo = our file, tmdbProfile, a cast/crew entry's profile (in-memory map at boot), else the new 'no photo' placeholder; new cast/crew/created_by people keep tmdbProfile; search people rows with the photo; /settings = the heading only; util.hl sortDesc starts from sorted runs (same result, 105k: 1.6 s -> 0.15 s); gates 369/0, 32/0, 52/0, check-theme 0; README/STATUS/LOGmre718bfb89/components/person.hl

6.2 KB

  1. // components/person.hl — `/person/<slug>` (tracker.worldapi.org#16): a person's page — name, photo, born/died, bio, then
  2. // the filmography (poster, title, year, role; series and movies, newest first, each → its page: /series/, /shows/ or /movies/<slug>).
  3. // The show page's cast and the search's people link here. tracker.worldapi.org#20: the heading is "Person | <name>" (the type word
  4. // in the person colour, styles.hl `type-*`), each row's kind word in its type's colour.
  5. //
  6. // FIRST VISIT of a person we don't have complete yet (people.hl `needsFill`): the page shows what we have plus "Loading
  7. // filmography…" and fills in WITHOUT a reload — the face `personFill` does ONE step per call (1st: TMDB person + credits,
  8. // then 40 titles per call, the last marks the person complete) and the handler calls it until it says `done`; between two
  9. // calls hl:web serves every other request. hl:web gives a page no "mounted" hook, so the first call comes from a tick like
  10. // the shell's offline probe (components/main.hl): the invisible `personProbe` runs an endless short CSS animation
  11. // (styles.hl) and its `animationiteration` starts the fill (once — `busy`). A failed fill shows why; the next visit tries again.
  12. //
  13. // mission 060 (tracker.worldapi.org#27): the person's short id (shortids.hl) under the photo (no photo: under the facts).
  14. //
  15. // HYBRIEL TRAPS: no session here at all (the fill needs no sign-in — one TMDB request per person, ever), so hybriel#121/#122
  16. // can't bite; every list is replaced whole. Helpers are LOCAL statics (an imported mpackdb helper straight in a member's
  17. // initializer came back wrong after a client-side navigation — components/show.hl `followingOf`).
  18. parent './main.hl'
  19. import { appTitle } from '../project.hl'
  20. import { personBySlug, personInfoOf, filmographyOf, needsFill, personFillStep } from '../lib/people.hl'
  21. // everything the page shows for one slug
  22. static pageOf = (&slug) => {
  23. let p = personBySlug(slug)
  24. if (p == null) { return { found = false name = '' photoUrl = '' born = '' died = '' bio = '' rows = [] loading = false shortId = '' } }
  25. info = personInfoOf(p)
  26. return { found = true name = info.name photoUrl = info.photoUrl born = info.born died = info.died bio = info.bio
  27. rows = filmographyOf(p) loading = needsFill(p) shortId = p.shortId != null ? '' + p.shortId : '' }
  28. }
  29. // one fill step for the person of this slug; the last answers the whole page again
  30. static fillOf = (&slug) => {
  31. let p = personBySlug(slug)
  32. if (p == null) { return { error = 'no such person' } }
  33. r = personFillStep(p.id)
  34. if (r.error != null) { return { error = r.error } }
  35. if (r.done != true) { return { done = false pos = r.pos total = r.total } }
  36. out = pageOf(slug)
  37. out.done = true
  38. out.added = r.added
  39. return out
  40. }
  41. // ---- reactive members -----------------------------------------------------------------------
  42. slug = null
  43. start = pageOf(slug)
  44. found = start.found
  45. notFound = !start.found
  46. name = start.name
  47. photoUrl = start.photoUrl
  48. hasPhoto = photoUrl != ''
  49. // mission 060 (tracker.worldapi.org#27): the short id under the photo — no photo: under the name and facts
  50. shortId = start.shortId
  51. hasShortId = shortId != ''
  52. shortIdInMeta = hasShortId && !hasPhoto
  53. born = start.born
  54. hasBorn = born != ''
  55. died = start.died
  56. hasDied = died != ''
  57. bio = start.bio
  58. hasBio = bio != ''
  59. bioClass = 'short'
  60. rows = start.rows
  61. hasRows = rows.length > 0
  62. loading = start.loading
  63. loadText = 'Loading filmography…'
  64. busy = false
  65. fillError = ''
  66. hasFillError = fillError != ''
  67. noRows = found && !loading && rows.length == 0 && fillError == ''
  68. __title = found ? name + ' — ' + appTitle : appTitle
  69. View {
  70. personPage { "data-loading" = loading
  71. if (notFound) {
  72. article { class = "main"
  73. h1 { "Not found" }
  74. p { "This person doesn't exist." }
  75. }
  76. }
  77. if (found) {
  78. personHeader {
  79. if (hasPhoto) {
  80. personPhoto {
  81. img { src = photoUrl alt = name }
  82. if (hasShortId) { shortIdLabel { id = "shortid" title = "Short id" shortId } }
  83. }
  84. }
  85. personMeta {
  86. h1 { class = "typed" typeWord { class = "type-word type-person" "Person" } typeSep { "|" } typeName { name } }
  87. if (hasBorn) { personFact { class = "born" born } }
  88. if (hasDied) { personFact { class = "died" died } }
  89. if (shortIdInMeta) { shortIdLabel { id = "shortid" title = "Short id" shortId } }
  90. }
  91. }
  92. // a SHORT bio: four lines (styles.hl), a click shows all of it
  93. if (hasBio) { personBio { class = bioClass title = "Show all" bio on click(e) { emit toggleBio(e) } } }
  94. h2 { class = "film-heading" "Filmography" }
  95. if (loading) {
  96. personLoading { id = "personloading" loadText
  97. personProbe { "aria-hidden" = "true" on animationiteration(e) { emit fillTick(e) } }
  98. }
  99. }
  100. if (hasFillError) { p { id = "fillerror" class = "message" fillError } }
  101. if (noRows) { p { id = "nofilms" class = "muted" "No shows or movies known." } }
  102. if (hasRows) {
  103. filmRows {
  104. for (row of rows) {
  105. a { class = "film-row" href = row.href
  106. img { class = "film-poster" src = row.posterUrl alt = "" loading = "lazy" }
  107. filmText {
  108. filmTitle { row.title }
  109. filmMeta {
  110. filmYear { row.year }
  111. filmType { class = row.typeClass row.typeLabel }
  112. }
  113. filmRole { row.role }
  114. }
  115. }
  116. }
  117. }
  118. }
  119. }
  120. }
  121. }
  122. // the probe's tick: the fill, step by step, until done (once per page — `busy`); a lost answer (null) just waits for the
  123. // next tick and goes on where the server is
  124. on fillTick(e) {
  125. if (busy || !loading) { return null }
  126. busy = true
  127. s = slug
  128. let r = emit server personFill(s)
  129. while (r != null && r.error == null && r.done != true && slug == s) {
  130. loadText = 'Loading filmography… ' + r.pos + ' of ' + r.total + ' titles'
  131. r = emit server personFill(s)
  132. }
  133. busy = false
  134. if (r == null || slug != s) { return null }
  135. if (r.error != null) {
  136. loading = false
  137. fillError = 'Could not load the filmography: ' + r.error
  138. return null
  139. }
  140. photoUrl = r.photoUrl
  141. born = r.born
  142. died = r.died
  143. bio = r.bio
  144. rows = r.rows
  145. loading = false
  146. }
  147. on toggleBio(e) {
  148. bioClass = bioClass == 'short' ? 'full' : 'short'
  149. }
  150. // ---- the face (a unique name: hl:web dispatches faces by name across all files) ----
  151. on server personFill(slug) {
  152. return fillOf(slug != null ? '' + slug : '')
  153. }

Branches

Latest commits

  • 718bfb89tracker#37 (mission 032): /people = everyone, last updated first (updatedAt stamped by the person fill; view built at boot, touched people first at once), photo + name tiles (person colour) with the /movies pagination, /people/<letter> removed; photo = our file, tmdbProfile, a cast/crew entry's profile (in-memory map at boot), else the new 'no photo' placeholder; new cast/crew/created_by people keep tmdbProfile; search people rows with the photo; /settings = the heading only; util.hl sortDesc starts from sorted runs (same result, 105k: 1.6 s -> 0.15 s); gates 369/0, 32/0, 52/0, check-theme 0; README/STATUS/LOGmre
  • 96ba683adeploy.sh: a gate without a 'passed,' line (check-theme) no longer ends the scriptmre
  • eb3b9205tracker: report 031mre
  • 9b5d2e89tracker mission 031: README (What it does, Test: four gates + the #32 checks, Files: theme/, new pages), STATUS (real copy, A/B load, how to repeat, open points), LOGmre
  • 39950e4ctracker#32 (mission 031): the WorldAPI theme (theme/ vendored verbatim from layouts.worldapi.org 85b5654; styles.hl inherits it: accent green-dark, type colours 1-6; own base/header rules, row lines, genre-pill and inverted-button frames removed, the season foldable keeps its line; check-theme 21 -> 0, 4th deploy gate; main actions class primary) and the #32 header (theme AppHeader/MainMenu/UserMenu/Sidebar/ContentFirst: desktop brand, search, Series|Shows|Movies|Genres|People, user icon with Unwatched..Settings, Logout; signed out the ident selector, phone the iD icon dropdown; phone menu in the sidebar overlay; marked entry by :has); /find -> /search/<q>, /genres, /people(/<letter>), /settings; main { ContentFirst { slot } } works around the hl:web one-line slot bug; gates 365/0, 32/0, 52/0, check-theme 0mre
  • a386dc92tracker: reports 029 + 030mre
  • 71e0fd7dtracker missions 029 + 030: README (What it does, Files, gate count), STATUS (real-copy numbers, how to repeat, open points), LOGmre
  • d36ea6eatracker#34 + #35 (mission 030): Follow directly under the poster, as wide as the poster (show.hl, styles.hl); the status pill next to a series' title — TVmaze's status (new tvmazeStatus, stored by the sync's TVmaze merge) else TMDB's, TVmaze Ended + TMDB Canceled = Canceled, inverted (filled, dark text, no border), green running / yellow pending / red canceled / muted ended (shows.hl statusOf); the daily delta asks TVmaze's status of an unfollowed series TVmaze's change list names (dailysync.hl syncRunStep, sync.hl syncTvmazeStatus); the status backfill after the details repair (backfill.hl, jobs.hl statusTick; resumable, 550 ms per TVmaze request); gates 354/0, 32/0, 52/0mre
  • 7d7d4487tracker#33 (mission 029): reduced titles — every title TMDB's details never went through this app (no detailsAt, no tmdbSync) is incomplete (shows.hl isIncomplete; the old tracker's migrated rows passed #26's test: 5,697 non-adult on the live copy, 691 series without seasons); the repair job does the visibly reduced first (shows.hl missingParts), the page completes one on open; a title TMDB has no poster for (The Remaining) shows the placeholder; tools/count-incomplete.hl; gate fixtures stand for synced titles (tmdbSync), tests/seed-reduced.hl + #33 checks; gates 347/0, 32/0, 52/0mre
  • 661c2592tracker: report 028mre
  • 27c916fatracker mission 028: README ("Code order", the new file map), STATUS (counts before/after, tests, how to repeat, open), LOGmre
  • d924f398tracker mission 028: comments name the new files (sync.hl, dailysync.hl, backfill.hl, credits.hl, jobs.hl, images.hl …); tools/ref-params.py + tools/lambda-audit.py also scan lib/ (they globbed the root only), lambda-audit counts a plain `x = p` alias like `let x = p`mre
  • 2e89b968tracker mission 028 (code order) 5/5 let: `let` only where a variable is reassigned — 667 never-reassigned lets became plain declarations (project.hl, lib/, components/, tools/, tests/); kept: 264 in loop bodies (a plain declaration there is 'Cannot reassign' on the 2nd pass), 234 reassigned, 27 whose name is also a member/outer/free name (a plain write would rebind it); tools/let-audit.py decides and fixes (README 'Code order'); tests/realdata-m028.{sh,mjs} = the page-output diff on a real copy; gates 342/0, 32/0, 52/0, real-copy pages identicalmre
  • 54796ff2tracker mission 028 (code order) 4/5 thin faces + last copies: the show page's check/follow faces call lib/watches.hl toggleWatched / toggleSeasonWatched (seasonAllWatched moved there) and lib/follows.hl toggleFollowed; both logins (header selector face, /login/callback) share lib/users.hl userOfCode; todayStr/listOf copies in components and the export readers copied into tools/migrate.hl + tools/old-short-ids.hl now once (lib/util.hl, lib/export.hl); gates 342/0, 32/0, 52/0; old-short-ids output byte-identical, migrate output identicalmre
  • 06b078e3tracker mission 028 (code order) 3/5 project.hl is the map: config, routes, wiring and a feature → file index (914 → 258 lines); the background jobs (daily sync run, backfills, details repair, credits job, merge, short ids, collection seed) moved unchanged into lib/jobs.hl (a class: their state is reassigned every step, a static cannot be; one instance made after the server), the login callback into lib/users.hl, poster/photo serving into lib/images.hl, the /shows/<slug> rule into lib/shows.hl showsMovedPath; route handlers are thin wrappers; gates 342/0, 32/0, 52/0, real-copy pages identicalmre
  • 94716fd2tracker mission 028 (code order) 2/5 util + topics: lib/util.hl holds envOr, storageDir, postersDir, profilesDir, newId, hexDigits, todayStr, dateOr, textOr, hasId, listOr, firstOf, sortDesc once (were copied into up to 5 files); tmdbsync.hl split into tmdb.hl (TMDB/TVmaze requests), sync.hl (one title's sync), sync-helpers.hl, backfill.hl; details.hl split into details.hl, credits.hl, credits-helpers.hl (isIncomplete to shows.hl); search-helpers.hl (words, query, ranking, slugs); collections.hl (the TMDB collection seed, out of franchises.hl); deltasync.hl renamed dailysync.hl; no behaviour change: gates 342/0, 32/0, 52/0, real-copy pages identicalmre
  • 186079b0tracker mission 028 (code order) 1/5 move: every root .hl except project.hl into lib/ (styles.hl into components/), import paths only; gates 342/0, 32/0, 52/0; real-copy pages identicalmre
  • 4f47f181tracker: report 027mre
  • dc1d4be4tracker mission 027: Hybriel master 06617221 vendored (plugin allocator fixes 3a781359 + 413f60e4); real copy RSS through first-start jobs + 400 loads flat ~2.55 GB (190aa11d 2.3 -> 5.6 GB), page times <= 1.1x; gates 342/0, 32/0, 52/0mre
  • 84e1b3e1tracker: reports 025 + 026mre