gitoriaLog in with ident

tracker

All repositories: gitoria

ReadmeCodePull requestsReleasesTicketsSettingsCommit661c2592661c2592tracker: report 028mre661c2592/reports/028-code-order.md

4.1 KB

  1. # Report 028 (w078) — tracker: code order (no behaviour change) — DONE on main
  3. **Commits** on main in loreana:/media/STORAGE/projects/tracker.worldapi.org (parent 4f47f18, fast-forward): `186079b` 1/5 move ·
  4. `94716fd` 2/5 util + topics · `06b078e` 3/5 project.hl = the map · `54796ff` 4/5 thin faces + last copies · `2e89b96` 5/5 let ·
  5. `d924f39` comments + audit tools · `27c916f` README/STATUS/LOG. Not pushed, not deployed. No `.env` read (the real-jobs run linked it for the runtime, as in mission 027; link removed). Every process killed by
  6. PID; 8720–8731 free; real-copy data deleted.
  8. ## Before → after
  9. | | before (4f47f18) | after |
  10. |---|---|---|
  11. | `.hl` files in the root | 15 | 1 (`project.hl`) |
  12. | `project.hl` lines | 914 | 261 |
  13. | `let` (code, all .hl) | 1,211; 706 never reassigned (676 convertible + 30 name clashes) | 525 = 264 in loop bodies + 234 reassigned + 27 kept for a name clash; 667 converted |
  15. ## File map (README "Files" has every file)
  16. - `project.hl` — config, every route, thin function routes, push audiences, boot wiring, `jobs = new Jobs()`, a feature → file index on top.
  17. - `lib/`: `util` (envOr, storageDir, postersDir, profilesDir, newId, hexDigits, todayStr, dateOr, textOr, hasId, listOr, firstOf,
  18. sortDesc — each once), `users` (+ /login/callback logic, `userOfCode` for both logins), `shows` (+ `isIncomplete`,
  19. `showsMovedPath`), `follows` (+ `toggleFollowed`), `watches` (+ `toggleWatched`, `toggleSeasonWatched`), `catalog`,
  20. `search` + `search-helpers`, `people`, `credits` + `credits-helpers` (out of details), `details`, `tmdb` (requests, out of
  21. tmdbsync), `sync` + `sync-helpers` (one title), `dailysync` (was deltasync), `backfill` (adult + kind), `shortids`,
  22. `franchises`, `collections` (the seed, out of franchises), `merge`, `jobs` (all background runners + clocks), `images`
  23. (posters/photos), `export` (the tools' mongo-export readers).
  24. - `components/styles.hl` (was `styles.hl`); `tools/let-audit.py`; `tests/realdata-m028.{sh,mjs}`.
  26. ## Decisions
  27. - `lib/jobs.hl` is a CLASS with one instance (`jobs = new Jobs()` after the server): the runners' state is reassigned every step,
  28. a static cannot be (measured: "Cannot reassign immutable variable"); the code moved unchanged, log order unchanged.
  29. - `let` kept inside loop bodies (a plain declaration there fails on the 2nd pass — measured), and where the name is also a
  30. member/import/outer/free name (a plain `x = …` inside a function REBINDS a file member — measured) or used outside its block
  31. (the browser target emits a plain declaration as block-scoped JS `let`). Plain declarations copy like `let` (measured).
  32. - Faces/routes made thin where the logic was the topic's: show page check/follow toggles, both logins, posters/photos, /shows/<slug>.
  34. ## Tests
  35. - Gates after every step and on the final tree: `TRACKER_GATE_PORT=8720 … TRACKER_GATE_CHROME=8722-8726 TRACKER_GATE_TMDB_PORT=8727`
  36. → browser **342 passed, 0 failed**, kinds **32/0**, franchises **52/0** (outputs `.scratch/w078/gate-*.txt`, shots `/tmp/m028/`, looked at).
  37. - Real copy (live storage, signed in as az5b2, all jobs off, no `.env`): 24 pages (/, lists, franchises, 2 series, a show, 2
  38. movies, 2 persons, genre, search, all /my/*, not-found pages) + 10 redirects/404s, 2 runs per tree: **normalized HTML and the
  39. hydrated page text identical to 4f47f18 (49/49 files)**. Browser full load 2×10 per page: sum 7,358 → 7,258 ms (0.99×), boot
  40. 48–51 s and 2,216 MB both; client modules +0.9 %.
  41. - Real jobs on the copy (final tree, forced delta run): sync 345 titles errors=0, repair 24/24, collections 17/17, others nothing
  42. to do; RSS max 2.49 GB.
  43. - Tools old vs new: old-short-ids byte-identical, migrate + verify identical, 7 count tools identical.
  45. ## Open
  46. - Deploy: rsync has no `--delete` → the 14 old root `.hl` stay on Byrodin (unused); delete them by hand after deploying.
  47. - The search import face still stores the credits itself (search.hl → credits.hl would be an import cycle).
  48. - Long topic files left as they are: merge.hl 599, sync.hl 446, franchises.hl 445, people.hl 404 lines.
  49. - tools/lambda-audit.py now also lists 2 harmless reassignments (`fid = franchiseId`, `inShow = showId`) besides the 13 before.

Branches

Latest commits

  • 661c2592tracker: report 028mre
  • 27c916fatracker mission 028: README ("Code order", the new file map), STATUS (counts before/after, tests, how to repeat, open), LOGmre
  • d924f398tracker mission 028: comments name the new files (sync.hl, dailysync.hl, backfill.hl, credits.hl, jobs.hl, images.hl …); tools/ref-params.py + tools/lambda-audit.py also scan lib/ (they globbed the root only), lambda-audit counts a plain `x = p` alias like `let x = p`mre
  • 2e89b968tracker mission 028 (code order) 5/5 let: `let` only where a variable is reassigned — 667 never-reassigned lets became plain declarations (project.hl, lib/, components/, tools/, tests/); kept: 264 in loop bodies (a plain declaration there is 'Cannot reassign' on the 2nd pass), 234 reassigned, 27 whose name is also a member/outer/free name (a plain write would rebind it); tools/let-audit.py decides and fixes (README 'Code order'); tests/realdata-m028.{sh,mjs} = the page-output diff on a real copy; gates 342/0, 32/0, 52/0, real-copy pages identicalmre
  • 54796ff2tracker mission 028 (code order) 4/5 thin faces + last copies: the show page's check/follow faces call lib/watches.hl toggleWatched / toggleSeasonWatched (seasonAllWatched moved there) and lib/follows.hl toggleFollowed; both logins (header selector face, /login/callback) share lib/users.hl userOfCode; todayStr/listOf copies in components and the export readers copied into tools/migrate.hl + tools/old-short-ids.hl now once (lib/util.hl, lib/export.hl); gates 342/0, 32/0, 52/0; old-short-ids output byte-identical, migrate output identicalmre
  • 06b078e3tracker mission 028 (code order) 3/5 project.hl is the map: config, routes, wiring and a feature → file index (914 → 258 lines); the background jobs (daily sync run, backfills, details repair, credits job, merge, short ids, collection seed) moved unchanged into lib/jobs.hl (a class: their state is reassigned every step, a static cannot be; one instance made after the server), the login callback into lib/users.hl, poster/photo serving into lib/images.hl, the /shows/<slug> rule into lib/shows.hl showsMovedPath; route handlers are thin wrappers; gates 342/0, 32/0, 52/0, real-copy pages identicalmre
  • 94716fd2tracker mission 028 (code order) 2/5 util + topics: lib/util.hl holds envOr, storageDir, postersDir, profilesDir, newId, hexDigits, todayStr, dateOr, textOr, hasId, listOr, firstOf, sortDesc once (were copied into up to 5 files); tmdbsync.hl split into tmdb.hl (TMDB/TVmaze requests), sync.hl (one title's sync), sync-helpers.hl, backfill.hl; details.hl split into details.hl, credits.hl, credits-helpers.hl (isIncomplete to shows.hl); search-helpers.hl (words, query, ranking, slugs); collections.hl (the TMDB collection seed, out of franchises.hl); deltasync.hl renamed dailysync.hl; no behaviour change: gates 342/0, 32/0, 52/0, real-copy pages identicalmre
  • 186079b0tracker mission 028 (code order) 1/5 move: every root .hl except project.hl into lib/ (styles.hl into components/), import paths only; gates 342/0, 32/0, 52/0; real-copy pages identicalmre
  • 4f47f181tracker: report 027mre
  • dc1d4be4tracker mission 027: Hybriel master 06617221 vendored (plugin allocator fixes 3a781359 + 413f60e4); real copy RSS through first-start jobs + 400 loads flat ~2.55 GB (190aa11d 2.3 -> 5.6 GB), page times <= 1.1x; gates 342/0, 32/0, 52/0mre
  • 84e1b3e1tracker: reports 025 + 026mre
  • dc40d859tracker#31 (mission 026): duplicate titles merged — the 68 type+tmdbId pairs held by 157 records were the old tracker's (all migrated); merge.hl repair job (own clock, before the TMDB jobs) keeps one keeper per title (follows/watches > old short id > oldest), moves follows, watches, seasons, cast, credits, timelines, tombstones the rest (mergedInto, never deleted), slugs + short ids 301 to the keeper; stray seasons merged into their listed twin (Reacher S3 watches) or linked when watched; search import re-checks before its put; deploy.sh waits up to 90 s for 200; real copy 68 -> 0 dup ids, az5b2 follows/watches equal; gates 342/0, 32/0, 52/0mre
  • 2667da05tracker#30 (mission 025): /my/ pages from slim cached title cards, episode rows and watch sets (after the jobs /my/series 1.8 s -> 0.06 s, /my/unwatched 4.1 -> 0.18 s); timeline page shows its name once; franchise widget under the poster/title; movies with TV leftovers (First Contact) go through the details repair; tools/count-tmdb-ids.hl; gates 327/0, 52/0, 32/0mre
  • 3909810dantcolony#40: mission references in README/STATUS/docs point to the moved missionsmre
  • e63b1d28antcolony#40: history (LOG.md), worker briefs (missions/) and reports moved here from antcolony, numbered per project; old numbers in antcolony docs/mission-map.mdmre
  • 1cda451dtracker: Hybriel master 190aa11d (#127 both shapes, GC correctness fc838894) — conductor adopts despite /my/series 2.4x after jobs (memory 8.0 → 1.7 GB boot); see reports/071mre
  • c1fa2f2etracker (mission 071): Hybriel master 190aa11d measured on the real copy vs the live binary 8590df63 — NOT adopted (after the first-start jobs /my/series 2.4x slower, /series 1.6x, RSS swings 7.4-12.2 GB; fresh it is flat at 1.7-2.2 GB and /my/unwatched faster), vendor stays 8efba065, candidate kept in .scratch/w071/vendor-190aa11d; tests/kinds.mjs: collection seed off (its TMDB request broke check 1 in 1 of 4 runs); tests/realdata-071.sh + realdata-071-bench.mjs + tools/realdata-071-table.py; README + STATUS (numbers, how to repeat); gates 325/0, 32/0, 50/0mre
  • 8081350atracker docs (mission 070): README (summary, Config HL_GC_BYTES — kept at Hybriel's default, the 256 MiB setting is taken out of docker-compose.yml again: the jobs grew to 12+ GB with it too, see STATUS), Test (three gates), Deploy (first start ~50 min: kinds then seed, restart once after collections done, memory numbers), Vendored Hybriel 8efba065 + #48 audit, Files; STATUS mission 070 entry (merges, migrated counts, lambda audit, gates, RSS old vs new, how to repeat, open points); docs/kinds.md + docs/franchises.md job order; tests/realdata-070-*.sh, tools/count-migrated.hl, tools/ref-params.py, tools/lambda-audit.pymre
  • 1ad19c8ctracker: re-vendor Hybriel master 8efba065 (#126 GC by bytes, #48 lambda parameters copy) (mission 070): bin/hybriel sha256 50361e95…, plugins core crypto data fetch fs http http1 mpackdb proc smtp time web; lambda audit: 13 lambdas change a passed record/list (11 through a local alias), no caller relies on it — unchanged; 319 read-only lambda parameters get & (no copy per call: /my/schedule 2.35 → 0.46 s, /my/unwatched 13.7 → 5.7 s on the real copy); /my/unwatched one merge sort instead of n² inserts; docker-compose HL_GC_BYTES=268435456; deploy.sh runs kinds.mjs + franchises.mjs too (default ports 8700–8710); tests/realdata-070.mjs; gates browser 325/0, kinds 32/0, franchises 50/0mre
  • 46b21389tracker (mission 070, conductor): the sync never destroys migrated data — the one-time summary step MOVES a copied summary to migratedSummary (marker summaries-moved.txt) instead of clearing it; a migrated record's first title/genres/homepage/tagline TMDB replaces → migratedTitle/migratedGenres/migratedHomepage/migratedTagline, a migrated season's/episode's title/summary → migratedTitle/migratedSummary (set once); tests/peek-shows.hl prints them; gate 325/0mre