gitoriaLog in with ident

tracker

All repositories: gitoria

ReadmeCodePull requestsReleasesTicketsSettings
Commit27c916fa27c916fatracker mission 028: README ("Code order", the new file map), STATUS (counts before/after, tests, how to repeat, open), LOGmre27c916fa/tools/verify.hl

7.6 KB

  1. // tools/verify.hl — ONE-OFF PROOF for tracker.worldapi.org#2, run AFTER tools/migrate.hl.
  2. // Never opens the live storage/mpackdb/ a second time (hl:mpackdb rewrites a file's data on
  3. // open) — it works on a plain filesystem COPY the caller already made, given as
  4. // TRACKER_VERIFY_COPY. Checks, independently of migrate.hl's own "skipped" counters:
  5. // 1. every table's live count() equals the expected count (the old export's line count).
  6. // 2. zero DANGLING references: every non-null reference field (Show.genres/cast/seasons,
  7. // Season.show/episodes, Episode.show/season, Person.shows, Follow.show/user, Watch.target/
  8. // user) points at an id that really exists in the target table — a pre-existing null (the
  9. // old export already had no target) is not a dangling reference and is not counted here.
  10. // 3. one show followed end to end: show -> its seasons -> their episodes -> a follow and a
  11. // watch that reference it, printed so a human can spot-check them.
  12. //
  13. // Run (absolute paths; after migrate.hl, against a COPY, e.g.:
  14. // rm -rf .scratch/verify-copy && cp -r storage/mpackdb .scratch/verify-copy
  15. // TRACKER_VERIFY_COPY=$PWD/.scratch/verify-copy ./bin/hybriel tools/verify.hl
  16. import { MPackDB } from 'hl:mpackdb'
  17. import { env } from 'hl:proc'
  18. dir = env('TRACKER_VERIFY_COPY')
  19. if (dir == null || !dir.startsWith('/')) { hlError('set TRACKER_VERIFY_COPY (an absolute path to a COPY of storage/mpackdb — never the live one)') }
  20. genresTable = new MPackDB(file = dir + '/genres.db', primaryKey = '@id', indexes = ['!oldId'])
  21. personsTable = new MPackDB(file = dir + '/persons.db', primaryKey = '@id', indexes = ['!oldId'])
  22. showsTable = new MPackDB(file = dir + '/shows.db', primaryKey = '@id', indexes = ['!oldId'])
  23. seasonsTable = new MPackDB(file = dir + '/seasons.db', primaryKey = '@id', indexes = ['!oldId'])
  24. episodesTable = new MPackDB(file = dir + '/episodes.db', primaryKey = '@id', indexes = ['!oldId'])
  25. followsTable = new MPackDB(file = dir + '/follows.db', primaryKey = '@id', indexes = ['!oldId'])
  26. watchesTable = new MPackDB(file = dir + '/watches.db', primaryKey = '@id', indexes = ['!oldId'])
  27. usersTable = new MPackDB(file = dir + '/users.db', primaryKey = '@id', indexes = ['!identity'])
  28. // expected counts: the old export's own document counts (old-tracker/README-RECONSTRUCTED.md)
  29. expected = { genres = 27 persons = 15157 shows = 9453 seasons = 6430 episodes = 231584 follows = 128 watches = 11692 }
  30. genres = genresTable.find(null, null)
  31. persons = personsTable.find(null, null)
  32. shows = showsTable.find(null, null)
  33. seasons = seasonsTable.find(null, null)
  34. episodes = episodesTable.find(null, null)
  35. follows = followsTable.find(null, null)
  36. watches = watchesTable.find(null, null)
  37. users = usersTable.find(null, null)
  38. countsOk = true
  39. static checkCount = (&name, &got, &want) => {
  40. line = name + ': ' + got + ' (expected ' + want + ')'
  41. if (got != want) { console.log('COUNT MISMATCH ' + line) return false }
  42. console.log('count ok ' + line)
  43. return true
  44. }
  45. countsOk = checkCount('genres', genres.length, expected.genres) && countsOk
  46. countsOk = checkCount('persons', persons.length, expected.persons) && countsOk
  47. countsOk = checkCount('shows', shows.length, expected.shows) && countsOk
  48. countsOk = checkCount('seasons', seasons.length, expected.seasons) && countsOk
  49. countsOk = checkCount('episodes', episodes.length, expected.episodes) && countsOk
  50. countsOk = checkCount('follows', follows.length, expected.follows) && countsOk
  51. countsOk = checkCount('watches', watches.length, expected.watches) && countsOk
  52. console.log('users: ' + users.length + ' (expected 1, the creator)')
  53. // ---- id sets (existence maps) ---------------------------------------------------------
  54. static idSetOf = (&rows) => {
  55. m = {}
  56. for (r of rows) { m[r.id] = true }
  57. return m
  58. }
  59. genreIds = idSetOf(genres)
  60. personIds = idSetOf(persons)
  61. showIds = idSetOf(shows)
  62. seasonIds = idSetOf(seasons)
  63. episodeIds = idSetOf(episodes)
  64. userIds = idSetOf(users)
  65. dangling = 0
  66. static bad = (&msg) => { console.log('DANGLING ' + msg) }
  67. for (p of persons) {
  68. for (s of p.shows) { if (s.show != null && showIds[s.show] == null) { bad('person ' + p.id + ' -> show ' + s.show) dangling = dangling + 1 } }
  69. }
  70. for (s of shows) {
  71. for (g of s.genres) { if (g != null && genreIds[g] == null) { bad('show ' + s.id + ' -> genre ' + g) dangling = dangling + 1 } }
  72. for (c of s.cast) { if (c.person != null && personIds[c.person] == null) { bad('show ' + s.id + ' -> person ' + c.person) dangling = dangling + 1 } }
  73. for (sid of s.seasons) { if (sid != null && seasonIds[sid] == null) { bad('show ' + s.id + ' -> season ' + sid) dangling = dangling + 1 } }
  74. }
  75. for (s of seasons) {
  76. if (s.show != null && showIds[s.show] == null) { bad('season ' + s.id + ' -> show ' + s.show) dangling = dangling + 1 }
  77. for (eid of s.episodes) { if (eid != null && episodeIds[eid] == null) { bad('season ' + s.id + ' -> episode ' + eid) dangling = dangling + 1 } }
  78. }
  79. episodesWithNullSeason = 0
  80. for (e of episodes) {
  81. if (e.show != null && showIds[e.show] == null) { bad('episode ' + e.id + ' -> show ' + e.show) dangling = dangling + 1 }
  82. if (e.season == null) { episodesWithNullSeason = episodesWithNullSeason + 1 } else { if (seasonIds[e.season] == null) { bad('episode ' + e.id + ' -> season ' + e.season) dangling = dangling + 1 } }
  83. }
  84. for (f of follows) {
  85. if (f.show != null && showIds[f.show] == null) { bad('follow ' + f.id + ' -> show ' + f.show) dangling = dangling + 1 }
  86. if (f.user != null && userIds[f.user] == null) { bad('follow ' + f.id + ' -> user ' + f.user) dangling = dangling + 1 }
  87. }
  88. watchesWithNullTarget = 0
  89. for (w of watches) {
  90. if (w.target == null) {
  91. watchesWithNullTarget = watchesWithNullTarget + 1
  92. } else {
  93. let ok = w.targetType == 'episode' ? episodeIds[w.target] != null : (w.targetType == 'movie' ? showIds[w.target] != null : seasonIds[w.target] != null)
  94. if (!ok) { bad('watch ' + w.id + ' -> ' + w.targetType + ' ' + w.target) dangling = dangling + 1 }
  95. }
  96. if (w.user != null && userIds[w.user] == null) { bad('watch ' + w.id + ' -> user ' + w.user) dangling = dangling + 1 }
  97. }
  98. console.log('dangling references: ' + dangling + ' (episodes with a pre-existing null season: ' + episodesWithNullSeason + ', watches with a pre-existing null target: ' + watchesWithNullTarget + ' — not dangling, the export already had no target)')
  99. // ---- one show, followed end to end -----------------------------------------------------
  100. static findByOldId = (&rows, &oldId) => {
  101. for (r of rows) { if (r.oldId == oldId) { return r } }
  102. return null
  103. }
  104. sample = findByOldId(shows, '60f2a92b45fc8011c774392e') // "Raised by Wolves", old Mongo _id
  105. if (sample == null) {
  106. console.log('END-TO-END: sample show not found by oldId')
  107. } else {
  108. console.log('END-TO-END show ' + sample.id + ' "' + sample.title + '" seasons=' + sample.seasons.length)
  109. let totalEpisodes = 0
  110. for (sid of sample.seasons) {
  111. let se = null
  112. for (s of seasons) { if (s.id == sid) { se = s break } }
  113. if (se == null) { console.log(' MISSING season ' + sid) } else {
  114. console.log(' season ' + se.seasonNumber + ' (' + se.id + ') episodes=' + se.episodes.length + ' show-back-ref-ok=' + (se.show == sample.id))
  115. totalEpisodes = totalEpisodes + se.episodes.length
  116. }
  117. }
  118. console.log(' total episodes across seasons: ' + totalEpisodes)
  119. let followCount = 0
  120. for (f of follows) { if (f.show == sample.id) { followCount = followCount + 1 } }
  121. let watchCount = 0
  122. for (w of watches) {
  123. if (w.targetType == 'season') { for (sid of sample.seasons) { if (w.target == sid) { watchCount = watchCount + 1 } } }
  124. }
  125. console.log(' follows on this show: ' + followCount + ', season-level watches touching it: ' + watchCount)
  126. }
  127. console.log('VERIFY ' + (countsOk && dangling == 0 ? 'PASS' : 'FAIL'))

Branches

Latest commits

  • 27c916fatracker mission 028: README ("Code order", the new file map), STATUS (counts before/after, tests, how to repeat, open), LOGmre
  • d924f398tracker mission 028: comments name the new files (sync.hl, dailysync.hl, backfill.hl, credits.hl, jobs.hl, images.hl …); tools/ref-params.py + tools/lambda-audit.py also scan lib/ (they globbed the root only), lambda-audit counts a plain `x = p` alias like `let x = p`mre
  • 2e89b968tracker mission 028 (code order) 5/5 let: `let` only where a variable is reassigned — 667 never-reassigned lets became plain declarations (project.hl, lib/, components/, tools/, tests/); kept: 264 in loop bodies (a plain declaration there is 'Cannot reassign' on the 2nd pass), 234 reassigned, 27 whose name is also a member/outer/free name (a plain write would rebind it); tools/let-audit.py decides and fixes (README 'Code order'); tests/realdata-m028.{sh,mjs} = the page-output diff on a real copy; gates 342/0, 32/0, 52/0, real-copy pages identicalmre
  • 54796ff2tracker mission 028 (code order) 4/5 thin faces + last copies: the show page's check/follow faces call lib/watches.hl toggleWatched / toggleSeasonWatched (seasonAllWatched moved there) and lib/follows.hl toggleFollowed; both logins (header selector face, /login/callback) share lib/users.hl userOfCode; todayStr/listOf copies in components and the export readers copied into tools/migrate.hl + tools/old-short-ids.hl now once (lib/util.hl, lib/export.hl); gates 342/0, 32/0, 52/0; old-short-ids output byte-identical, migrate output identicalmre
  • 06b078e3tracker mission 028 (code order) 3/5 project.hl is the map: config, routes, wiring and a feature → file index (914 → 258 lines); the background jobs (daily sync run, backfills, details repair, credits job, merge, short ids, collection seed) moved unchanged into lib/jobs.hl (a class: their state is reassigned every step, a static cannot be; one instance made after the server), the login callback into lib/users.hl, poster/photo serving into lib/images.hl, the /shows/<slug> rule into lib/shows.hl showsMovedPath; route handlers are thin wrappers; gates 342/0, 32/0, 52/0, real-copy pages identicalmre
  • 94716fd2tracker mission 028 (code order) 2/5 util + topics: lib/util.hl holds envOr, storageDir, postersDir, profilesDir, newId, hexDigits, todayStr, dateOr, textOr, hasId, listOr, firstOf, sortDesc once (were copied into up to 5 files); tmdbsync.hl split into tmdb.hl (TMDB/TVmaze requests), sync.hl (one title's sync), sync-helpers.hl, backfill.hl; details.hl split into details.hl, credits.hl, credits-helpers.hl (isIncomplete to shows.hl); search-helpers.hl (words, query, ranking, slugs); collections.hl (the TMDB collection seed, out of franchises.hl); deltasync.hl renamed dailysync.hl; no behaviour change: gates 342/0, 32/0, 52/0, real-copy pages identicalmre
  • 186079b0tracker mission 028 (code order) 1/5 move: every root .hl except project.hl into lib/ (styles.hl into components/), import paths only; gates 342/0, 32/0, 52/0; real-copy pages identicalmre
  • 4f47f181tracker: report 027mre
  • dc1d4be4tracker mission 027: Hybriel master 06617221 vendored (plugin allocator fixes 3a781359 + 413f60e4); real copy RSS through first-start jobs + 400 loads flat ~2.55 GB (190aa11d 2.3 -> 5.6 GB), page times <= 1.1x; gates 342/0, 32/0, 52/0mre
  • 84e1b3e1tracker: reports 025 + 026mre
  • dc40d859tracker#31 (mission 026): duplicate titles merged — the 68 type+tmdbId pairs held by 157 records were the old tracker's (all migrated); merge.hl repair job (own clock, before the TMDB jobs) keeps one keeper per title (follows/watches > old short id > oldest), moves follows, watches, seasons, cast, credits, timelines, tombstones the rest (mergedInto, never deleted), slugs + short ids 301 to the keeper; stray seasons merged into their listed twin (Reacher S3 watches) or linked when watched; search import re-checks before its put; deploy.sh waits up to 90 s for 200; real copy 68 -> 0 dup ids, az5b2 follows/watches equal; gates 342/0, 32/0, 52/0mre
  • 2667da05tracker#30 (mission 025): /my/ pages from slim cached title cards, episode rows and watch sets (after the jobs /my/series 1.8 s -> 0.06 s, /my/unwatched 4.1 -> 0.18 s); timeline page shows its name once; franchise widget under the poster/title; movies with TV leftovers (First Contact) go through the details repair; tools/count-tmdb-ids.hl; gates 327/0, 52/0, 32/0mre
  • 3909810dantcolony#40: mission references in README/STATUS/docs point to the moved missionsmre
  • e63b1d28antcolony#40: history (LOG.md), worker briefs (missions/) and reports moved here from antcolony, numbered per project; old numbers in antcolony docs/mission-map.mdmre
  • 1cda451dtracker: Hybriel master 190aa11d (#127 both shapes, GC correctness fc838894) — conductor adopts despite /my/series 2.4x after jobs (memory 8.0 → 1.7 GB boot); see reports/071mre
  • c1fa2f2etracker (mission 071): Hybriel master 190aa11d measured on the real copy vs the live binary 8590df63 — NOT adopted (after the first-start jobs /my/series 2.4x slower, /series 1.6x, RSS swings 7.4-12.2 GB; fresh it is flat at 1.7-2.2 GB and /my/unwatched faster), vendor stays 8efba065, candidate kept in .scratch/w071/vendor-190aa11d; tests/kinds.mjs: collection seed off (its TMDB request broke check 1 in 1 of 4 runs); tests/realdata-071.sh + realdata-071-bench.mjs + tools/realdata-071-table.py; README + STATUS (numbers, how to repeat); gates 325/0, 32/0, 50/0mre
  • 8081350atracker docs (mission 070): README (summary, Config HL_GC_BYTES — kept at Hybriel's default, the 256 MiB setting is taken out of docker-compose.yml again: the jobs grew to 12+ GB with it too, see STATUS), Test (three gates), Deploy (first start ~50 min: kinds then seed, restart once after collections done, memory numbers), Vendored Hybriel 8efba065 + #48 audit, Files; STATUS mission 070 entry (merges, migrated counts, lambda audit, gates, RSS old vs new, how to repeat, open points); docs/kinds.md + docs/franchises.md job order; tests/realdata-070-*.sh, tools/count-migrated.hl, tools/ref-params.py, tools/lambda-audit.pymre
  • 1ad19c8ctracker: re-vendor Hybriel master 8efba065 (#126 GC by bytes, #48 lambda parameters copy) (mission 070): bin/hybriel sha256 50361e95…, plugins core crypto data fetch fs http http1 mpackdb proc smtp time web; lambda audit: 13 lambdas change a passed record/list (11 through a local alias), no caller relies on it — unchanged; 319 read-only lambda parameters get & (no copy per call: /my/schedule 2.35 → 0.46 s, /my/unwatched 13.7 → 5.7 s on the real copy); /my/unwatched one merge sort instead of n² inserts; docker-compose HL_GC_BYTES=268435456; deploy.sh runs kinds.mjs + franchises.mjs too (default ports 8700–8710); tests/realdata-070.mjs; gates browser 325/0, kinds 32/0, franchises 50/0mre
  • 46b21389tracker (mission 070, conductor): the sync never destroys migrated data — the one-time summary step MOVES a copied summary to migratedSummary (marker summaries-moved.txt) instead of clearing it; a migrated record's first title/genres/homepage/tagline TMDB replaces → migratedTitle/migratedGenres/migratedHomepage/migratedTagline, a migrated season's/episode's title/summary → migratedTitle/migratedSummary (set once); tests/peek-shows.hl prints them; gate 325/0mre
  • 749019b0Merge t19 (tracker#19 franchises + timelines) into main (mission 070): conflicts README/STATUS/show.hl/project.hl/browser.mjs/faketmdb.mjs, both sides kept; franchise/timeline pages get #20's typed heading (Franchise | …, Timeline | …), their title links via titlePath (/movies|/series|/shows); the collection seed waits for repair, kinds and credits too; franchises.mjs URLs + 2 new checks; gates browser 323/0, kinds 32/0, franchises 50/0mre