gitoriaLog in with ident

tracker

All repositories: gitoria

ReadmeCodePull requestsReleasesTicketsSettings
Commit27c916fa27c916fatracker mission 028: README ("Code order", the new file map), STATUS (counts before/after, tests, how to repeat, open), LOGmre27c916fa/reports/011-tracker-person.md

3.9 KB

  1. # w055 — tracker#16 person pages (mission 011 (old 055))
  2. **Branch** t16-person (worktree loreana:/media/STORAGE/projects/tracker-wt16, from main 47a3cae), not pushed/merged:
  3. - 93be947 tracker#16: person pages /person/<slug> with the filmography fetched from TMDB on the first visit (step by step), gate
  4. - 139fafd tracker#16: short bio (4 lines, click = all), real-data check script, README + STATUS
  5. **Built**: `people.hl` (new), `components/person.hl` (new), `project.hl` (route `/person/:slug`, `/profiles/:name` photo route),
  6. `search.hl` (+`titleIdByTmdb`), `styles.hl` (one block). The page shows the name, a photo (TMDB w185 saved in storage/mpackdb/profiles),
  7. born/died, a short bio (four lines, click shows all) and the filmography: poster, title, year, type and role, newest first, each linking to /shows/<slug>.
  8. Adult titles are hidden (`show.adult === true` or the credit's TMDB flag). If the person is not complete yet, the page shows "Loading filmography…"
  9. and fills in without a reload. An invisible CSS-animation tick (hl:web has no mount hook) starts the client handler, which calls the face
  10. `personFill` until it says done. Step 1 is ONE TMDB request (`/person/<id>?append_to_response=combined_credits`) plus the photo.
  11. Each later step stores 40 titles, so other requests are served between steps. Missing titles get a minimal record (TMDB `adult`, overview,
  12. genres, language; no seasons or poster). They are indexed for search and added to catalog.hl. When the fill is done, the person gets
  13. `filmographyAt` and is never fetched again. No sign-in is needed.
  14. **Gate**: `TRACKER_GATE_SHOTS=/tmp/w055/shots TRACKER_GATE_PORT=8770 TRACKER_GATE_IDENT_PORT=8771 TRACKER_GATE_CHROME=8772-8775 TRACKER_GATE_TMDB_PORT=8776 node tests/browser.mjs`
  15. → `186 passed, 0 failed` (was 167). Covered:
  16. - a complete person renders at once, with no TMDB request
  17. - client-side cast link → loading state → filled without a reload (86 rows of 87 titles, the adult one hidden)
  18. - order and roles are right, and cast + crew of one title are merged into one role
  19. - one person request + the photo; the fill took 4 steps and added 85 titles
  20. - a row opens its show page and Back works; a title the fill added has its own page
  21. - a second visit adds nothing and asks TMDB nothing
  22. - a second person is only linked (added=0); a title marked adult in our records stays hidden even when TMDB's credit says not adult
  23. - search finds an added title once
  24. - 390/1280 layout
  25. **Real data** (copy of live storage/, real TMDB, :8777; copy deleted). Cast click → page shown / filled:
  26. - Tyler Hoechlin: 131 / 643 ms, 36 credits, 7 added
  27. - Grant Gustin: 68 / 593 ms, 33 credits, 21 added
  28. - Jared Harris: 85 / 869 ms, 97 credits, 80 added, 4 steps
  29. - Niamh Algar: 76 / 584 ms, 39 credits, 20 added
  30. - The TMDB request took 242–287 ms. Other requests waited at most 678 ms (median 13–32 ms).
  31. - Stress test with Eric Roberts: 758 credits, 712 added, 20 steps, 3.8 s; other requests waited at most 612 ms.
  32. - Second visit, full load: 41–120 ms. 0 console problems.
  33. **Screenshots** (looked at): gate `/tmp/w055/shots/person{,-complete}-{390,1280}.png`, real data `/tmp/w055/real/*.png` on Loreana.
  34. **Merge notes**: all shared-file changes are additive (details in STATUS #16 "Merge notes"). Fixture changes: Test Actor gets `tmdbId 3002`, genre
  35. Drama gets `tmdbId 18`, plus 2 persons. 54's `adult` field is read and written by people.hl under the same name `adult` (boolean).
  36. If 054 hides adult titles in public lists, the gate's "Hidden Adult Film" disappears from /movies; no check depends on that.
  37. **Open points**:
  38. - The TMDB step blocks the server for that one request (hl:fetch is blocking).
  39. - People are never refreshed after they are complete.
  40. - Adult people are not hidden, only titles.
  41. - Added titles have no poster file and no seasons until they are synced.
  42. - Not caused by #16: the signed-out header at 390 px wraps "choose ident" / "Log in with ident" onto two lines.
  43. **Hybriel**: no new issue. A `while` loop with `emit server` inside a client handler works.

Branches

Latest commits

  • 27c916fatracker mission 028: README ("Code order", the new file map), STATUS (counts before/after, tests, how to repeat, open), LOGmre
  • d924f398tracker mission 028: comments name the new files (sync.hl, dailysync.hl, backfill.hl, credits.hl, jobs.hl, images.hl …); tools/ref-params.py + tools/lambda-audit.py also scan lib/ (they globbed the root only), lambda-audit counts a plain `x = p` alias like `let x = p`mre
  • 2e89b968tracker mission 028 (code order) 5/5 let: `let` only where a variable is reassigned — 667 never-reassigned lets became plain declarations (project.hl, lib/, components/, tools/, tests/); kept: 264 in loop bodies (a plain declaration there is 'Cannot reassign' on the 2nd pass), 234 reassigned, 27 whose name is also a member/outer/free name (a plain write would rebind it); tools/let-audit.py decides and fixes (README 'Code order'); tests/realdata-m028.{sh,mjs} = the page-output diff on a real copy; gates 342/0, 32/0, 52/0, real-copy pages identicalmre
  • 54796ff2tracker mission 028 (code order) 4/5 thin faces + last copies: the show page's check/follow faces call lib/watches.hl toggleWatched / toggleSeasonWatched (seasonAllWatched moved there) and lib/follows.hl toggleFollowed; both logins (header selector face, /login/callback) share lib/users.hl userOfCode; todayStr/listOf copies in components and the export readers copied into tools/migrate.hl + tools/old-short-ids.hl now once (lib/util.hl, lib/export.hl); gates 342/0, 32/0, 52/0; old-short-ids output byte-identical, migrate output identicalmre
  • 06b078e3tracker mission 028 (code order) 3/5 project.hl is the map: config, routes, wiring and a feature → file index (914 → 258 lines); the background jobs (daily sync run, backfills, details repair, credits job, merge, short ids, collection seed) moved unchanged into lib/jobs.hl (a class: their state is reassigned every step, a static cannot be; one instance made after the server), the login callback into lib/users.hl, poster/photo serving into lib/images.hl, the /shows/<slug> rule into lib/shows.hl showsMovedPath; route handlers are thin wrappers; gates 342/0, 32/0, 52/0, real-copy pages identicalmre
  • 94716fd2tracker mission 028 (code order) 2/5 util + topics: lib/util.hl holds envOr, storageDir, postersDir, profilesDir, newId, hexDigits, todayStr, dateOr, textOr, hasId, listOr, firstOf, sortDesc once (were copied into up to 5 files); tmdbsync.hl split into tmdb.hl (TMDB/TVmaze requests), sync.hl (one title's sync), sync-helpers.hl, backfill.hl; details.hl split into details.hl, credits.hl, credits-helpers.hl (isIncomplete to shows.hl); search-helpers.hl (words, query, ranking, slugs); collections.hl (the TMDB collection seed, out of franchises.hl); deltasync.hl renamed dailysync.hl; no behaviour change: gates 342/0, 32/0, 52/0, real-copy pages identicalmre
  • 186079b0tracker mission 028 (code order) 1/5 move: every root .hl except project.hl into lib/ (styles.hl into components/), import paths only; gates 342/0, 32/0, 52/0; real-copy pages identicalmre
  • 4f47f181tracker: report 027mre
  • dc1d4be4tracker mission 027: Hybriel master 06617221 vendored (plugin allocator fixes 3a781359 + 413f60e4); real copy RSS through first-start jobs + 400 loads flat ~2.55 GB (190aa11d 2.3 -> 5.6 GB), page times <= 1.1x; gates 342/0, 32/0, 52/0mre
  • 84e1b3e1tracker: reports 025 + 026mre
  • dc40d859tracker#31 (mission 026): duplicate titles merged — the 68 type+tmdbId pairs held by 157 records were the old tracker's (all migrated); merge.hl repair job (own clock, before the TMDB jobs) keeps one keeper per title (follows/watches > old short id > oldest), moves follows, watches, seasons, cast, credits, timelines, tombstones the rest (mergedInto, never deleted), slugs + short ids 301 to the keeper; stray seasons merged into their listed twin (Reacher S3 watches) or linked when watched; search import re-checks before its put; deploy.sh waits up to 90 s for 200; real copy 68 -> 0 dup ids, az5b2 follows/watches equal; gates 342/0, 32/0, 52/0mre
  • 2667da05tracker#30 (mission 025): /my/ pages from slim cached title cards, episode rows and watch sets (after the jobs /my/series 1.8 s -> 0.06 s, /my/unwatched 4.1 -> 0.18 s); timeline page shows its name once; franchise widget under the poster/title; movies with TV leftovers (First Contact) go through the details repair; tools/count-tmdb-ids.hl; gates 327/0, 52/0, 32/0mre
  • 3909810dantcolony#40: mission references in README/STATUS/docs point to the moved missionsmre
  • e63b1d28antcolony#40: history (LOG.md), worker briefs (missions/) and reports moved here from antcolony, numbered per project; old numbers in antcolony docs/mission-map.mdmre
  • 1cda451dtracker: Hybriel master 190aa11d (#127 both shapes, GC correctness fc838894) — conductor adopts despite /my/series 2.4x after jobs (memory 8.0 → 1.7 GB boot); see reports/071mre
  • c1fa2f2etracker (mission 071): Hybriel master 190aa11d measured on the real copy vs the live binary 8590df63 — NOT adopted (after the first-start jobs /my/series 2.4x slower, /series 1.6x, RSS swings 7.4-12.2 GB; fresh it is flat at 1.7-2.2 GB and /my/unwatched faster), vendor stays 8efba065, candidate kept in .scratch/w071/vendor-190aa11d; tests/kinds.mjs: collection seed off (its TMDB request broke check 1 in 1 of 4 runs); tests/realdata-071.sh + realdata-071-bench.mjs + tools/realdata-071-table.py; README + STATUS (numbers, how to repeat); gates 325/0, 32/0, 50/0mre
  • 8081350atracker docs (mission 070): README (summary, Config HL_GC_BYTES — kept at Hybriel's default, the 256 MiB setting is taken out of docker-compose.yml again: the jobs grew to 12+ GB with it too, see STATUS), Test (three gates), Deploy (first start ~50 min: kinds then seed, restart once after collections done, memory numbers), Vendored Hybriel 8efba065 + #48 audit, Files; STATUS mission 070 entry (merges, migrated counts, lambda audit, gates, RSS old vs new, how to repeat, open points); docs/kinds.md + docs/franchises.md job order; tests/realdata-070-*.sh, tools/count-migrated.hl, tools/ref-params.py, tools/lambda-audit.pymre
  • 1ad19c8ctracker: re-vendor Hybriel master 8efba065 (#126 GC by bytes, #48 lambda parameters copy) (mission 070): bin/hybriel sha256 50361e95…, plugins core crypto data fetch fs http http1 mpackdb proc smtp time web; lambda audit: 13 lambdas change a passed record/list (11 through a local alias), no caller relies on it — unchanged; 319 read-only lambda parameters get & (no copy per call: /my/schedule 2.35 → 0.46 s, /my/unwatched 13.7 → 5.7 s on the real copy); /my/unwatched one merge sort instead of n² inserts; docker-compose HL_GC_BYTES=268435456; deploy.sh runs kinds.mjs + franchises.mjs too (default ports 8700–8710); tests/realdata-070.mjs; gates browser 325/0, kinds 32/0, franchises 50/0mre
  • 46b21389tracker (mission 070, conductor): the sync never destroys migrated data — the one-time summary step MOVES a copied summary to migratedSummary (marker summaries-moved.txt) instead of clearing it; a migrated record's first title/genres/homepage/tagline TMDB replaces → migratedTitle/migratedGenres/migratedHomepage/migratedTagline, a migrated season's/episode's title/summary → migratedTitle/migratedSummary (set once); tests/peek-shows.hl prints them; gate 325/0mre
  • 749019b0Merge t19 (tracker#19 franchises + timelines) into main (mission 070): conflicts README/STATUS/show.hl/project.hl/browser.mjs/faketmdb.mjs, both sides kept; franchise/timeline pages get #20's typed heading (Franchise | …, Timeline | …), their title links via titlePath (/movies|/series|/shows); the collection seed waits for repair, kinds and credits too; franchises.mjs URLs + 2 new checks; gates browser 323/0, kinds 32/0, franchises 50/0mre