gitoriaLog in with ident

tracker

All repositories: gitoria

ReadmeCodePull requestsReleasesTicketsSettings
Commit1cda451d1cda451dtracker: Hybriel master 190aa11d (#127 both shapes, GC correctness fc838894) — conductor adopts despite /my/series 2.4x after jobs (memory 8.0 → 1.7 GB boot); see reports/071mre1cda451d/components/unwatched.hl

5.9 KB

  1. // components/unwatched.hl — `/my/unwatched` (tracker.worldapi.org#5, moved from `/unwatched` in #8): every already-released episode of a
  2. // show the signed-in user follows that they have not watched yet, newest release first. Creator's words:
  3. // "/unwatched lists all unwatched episodes of shows followed in release date desc order"; "check icon is
  4. // a disc with a check in it" — the SAME check icon and watch logic as the show page (step 4), reused
  5. // (not copied) from follows.hl/shows.hl/watches.hl: `watchClassOf`, `watchedSet`, `setWatched` come from
  6. // watches.hl, the check icon markup/CSS is the same `button.checkicon` shape/class styles.hl already has.
  7. //
  8. // A ROW ONLY EVER SHOWS AN UNWATCHED EPISODE, so a click always marks it watched (never toggles back,
  9. // unlike the show page's checks) and the row leaves the list — the ticket's own test: "click an
  10. // episode's check: it disappears from the list."
  11. //
  12. // ONE FLAT LIST, rebuilt whole server-side on every click — the same proven-safe shape components/show.hl
  13. // uses for exactly the same Hybriel reasons (hybriel#86, hybriel#115/#116: a plain member function that
  14. // touches an hl:mpackdb-backed import must be `static` and must only ever be called server-side).
  15. parent './main.hl'
  16. import { appTitle } from '../project.hl'
  17. import { userIdOfSession } from '../users.hl'
  18. import { followedShowIds } from '../follows.hl'
  19. import { showById, seasonsOfShow, episodesOfSeason, episodeCode, titleWithYear, titlePath } from '../shows.hl'
  20. import { watchesOfUser, watchedSet, setWatched, watchClassOf } from '../watches.hl'
  21. import { now, timestamp } from 'hl:time'
  22. // ---- pure helpers (static: see the header comment above) ------------------------------------
  23. static todayStr = () => { return timestamp(now()).slice(0, 10) }
  24. // newest release first, `release` a plain 'YYYY-MM-DD' string; equal releases: the row found LATER first (as the old insertion
  25. // sort did). Mission 070: one merge sort over all rows (n log n) instead of inserting each row into a new list (n² list copies:
  26. // 1,287 rows on the creator's data = 0.8 M element copies per page, and since Hybriel 8efba065 every copy also feeds the
  27. // byte-triggered GC — /my/unwatched took 5.7 s). No list sort() (hybriel#1), so hand-written; `&`: no copy of the lists (#48).
  28. static mergeByReleaseDesc = (&a, &b) => {
  29. let out = []
  30. let i = 0
  31. let j = 0
  32. while (i < a.length && j < b.length) {
  33. if (a[i].release >= b[j].release) { out.push(a[i]) i = i + 1 } else { out.push(b[j]) j = j + 1 }
  34. }
  35. while (i < a.length) { out.push(a[i]) i = i + 1 }
  36. while (j < b.length) { out.push(b[j]) j = j + 1 }
  37. return out
  38. }
  39. static sortByReleaseDesc = (&rows) => {
  40. // runs of one, the found order reversed (ties: later first), merged pairwise until one run is left
  41. let runs = []
  42. let k = rows.length - 1
  43. while (k >= 0) { runs.push([rows[k]]) k = k - 1 }
  44. if (runs.length == 0) { return [] }
  45. while (runs.length > 1) {
  46. let next = []
  47. let r = 0
  48. while (r + 1 < runs.length) { next.push(mergeByReleaseDesc(runs[r], runs[r + 1])) r = r + 2 }
  49. if (r < runs.length) { next.push(runs[r]) }
  50. runs = next
  51. }
  52. return runs[0]
  53. }
  54. static unwatchedRowsOf = (&userId) => {
  55. if (userId == null) { return [] }
  56. let today = todayStr()
  57. let watched = watchedSet(watchesOfUser(userId))
  58. let out = []
  59. for (sid of followedShowIds(userId)) {
  60. let show = showById(sid)
  61. if (show != null) {
  62. for (s of seasonsOfShow(show)) {
  63. for (e of episodesOfSeason(s)) {
  64. let released = e.release != null && e.release <= today
  65. if (released && watched['episode:' + e.id] != true) {
  66. let title = e.title != null ? e.title : ''
  67. out.push({
  68. id = e.id showTitle = titleWithYear(show) showHref = titlePath(show)
  69. episodeLabel = episodeCode(e.seasonNumber, e.episodeNumber) + ' · ' + title
  70. release = e.release watchClass = watchClassOf(false)
  71. })
  72. }
  73. }
  74. }
  75. }
  76. }
  77. return sortByReleaseDesc(out)
  78. }
  79. // ---- reactive members -----------------------------------------------------------------------
  80. session = null
  81. userId = userIdOfSession(session)
  82. signedIn = userId != null
  83. // a plain copy of userId for `rows` (mission 047: session sync, see components/show.hl `me`)
  84. me = userId
  85. rows = signedIn ? unwatchedRowsOf(me) : []
  86. hasRows = rows.length > 0
  87. noRows = !hasRows
  88. emptyText = signedIn ? 'No unwatched episodes.' : 'Sign in to see the shows you follow.'
  89. __title = 'Unwatched — ' + appTitle
  90. View {
  91. unwatchedPage {
  92. h1 { "Unwatched" }
  93. if (noRows) { p { class = "muted" emptyText } }
  94. if (hasRows) {
  95. unwatchedRows {
  96. for (row of rows) {
  97. unwatchedRow {
  98. button { type = "button" class = row.watchClass value = row.id "aria-label" = "mark episode watched"
  99. svg { viewBox = "0 0 24 24" width = "22" height = "22" "aria-hidden" = "true"
  100. circle { cx = "12" cy = "12" r = "10" }
  101. path { d = "M7 12.5 L10.5 16 L17 8.5" }
  102. }
  103. on click(e) { emit toggleEpisode(row.id) }
  104. }
  105. a { class = "unwatched-show" href = row.showHref row.showTitle }
  106. unwatchedEpisode { row.episodeLabel }
  107. unwatchedDate { row.release }
  108. }
  109. }
  110. }
  111. }
  112. }
  113. }
  114. // The client only ever ASSIGNS the `rows` the server already rebuilt — never calls the tainted
  115. // local helper itself (components/show.hl's own `on toggleEpisode` follows the same shape, and
  116. // the same reason: `unwatchedRowsOf` touches mpackdb-backed imports, so it compiles to nothing on
  117. // the client, hybriel#115/#116).
  118. on toggleEpisode(episodeId) {
  119. if (!signedIn) { return null }
  120. let r = emit server unwatchedToggle('' + episodeId)
  121. if (r == null || r.error != null) { return null }
  122. rows = r.rows
  123. }
  124. // ---- the face (the trailing `session` is always the server's: hybriel#16) ----
  125. on server unwatchedToggle(episodeId, session) {
  126. let uid = userIdOfSession(session)
  127. if (uid == null) { return { error = 'you are not signed in' } }
  128. let watchRows = watchesOfUser(uid)
  129. let ok = setWatched(uid, 'episode', episodeId, watchRows, true)
  130. if (!ok) { return { error = 'could not save the watch' } }
  131. return { ok = true rows = unwatchedRowsOf(uid) }
  132. }

Branches

Latest commits

  • 1cda451dtracker: Hybriel master 190aa11d (#127 both shapes, GC correctness fc838894) — conductor adopts despite /my/series 2.4x after jobs (memory 8.0 → 1.7 GB boot); see reports/071mre
  • c1fa2f2etracker (mission 071): Hybriel master 190aa11d measured on the real copy vs the live binary 8590df63 — NOT adopted (after the first-start jobs /my/series 2.4x slower, /series 1.6x, RSS swings 7.4-12.2 GB; fresh it is flat at 1.7-2.2 GB and /my/unwatched faster), vendor stays 8efba065, candidate kept in .scratch/w071/vendor-190aa11d; tests/kinds.mjs: collection seed off (its TMDB request broke check 1 in 1 of 4 runs); tests/realdata-071.sh + realdata-071-bench.mjs + tools/realdata-071-table.py; README + STATUS (numbers, how to repeat); gates 325/0, 32/0, 50/0mre
  • 8081350atracker docs (mission 070): README (summary, Config HL_GC_BYTES — kept at Hybriel's default, the 256 MiB setting is taken out of docker-compose.yml again: the jobs grew to 12+ GB with it too, see STATUS), Test (three gates), Deploy (first start ~50 min: kinds then seed, restart once after collections done, memory numbers), Vendored Hybriel 8efba065 + #48 audit, Files; STATUS mission 070 entry (merges, migrated counts, lambda audit, gates, RSS old vs new, how to repeat, open points); docs/kinds.md + docs/franchises.md job order; tests/realdata-070-*.sh, tools/count-migrated.hl, tools/ref-params.py, tools/lambda-audit.pymre
  • 1ad19c8ctracker: re-vendor Hybriel master 8efba065 (#126 GC by bytes, #48 lambda parameters copy) (mission 070): bin/hybriel sha256 50361e95…, plugins core crypto data fetch fs http http1 mpackdb proc smtp time web; lambda audit: 13 lambdas change a passed record/list (11 through a local alias), no caller relies on it — unchanged; 319 read-only lambda parameters get & (no copy per call: /my/schedule 2.35 → 0.46 s, /my/unwatched 13.7 → 5.7 s on the real copy); /my/unwatched one merge sort instead of n² inserts; docker-compose HL_GC_BYTES=268435456; deploy.sh runs kinds.mjs + franchises.mjs too (default ports 8700–8710); tests/realdata-070.mjs; gates browser 325/0, kinds 32/0, franchises 50/0mre
  • 46b21389tracker (mission 070, conductor): the sync never destroys migrated data — the one-time summary step MOVES a copied summary to migratedSummary (marker summaries-moved.txt) instead of clearing it; a migrated record's first title/genres/homepage/tagline TMDB replaces → migratedTitle/migratedGenres/migratedHomepage/migratedTagline, a migrated season's/episode's title/summary → migratedTitle/migratedSummary (set once); tests/peek-shows.hl prints them; gate 325/0mre
  • 749019b0Merge t19 (tracker#19 franchises + timelines) into main (mission 070): conflicts README/STATUS/show.hl/project.hl/browser.mjs/faketmdb.mjs, both sides kept; franchise/timeline pages get #20's typed heading (Franchise | …, Timeline | …), their title links via titlePath (/movies|/series|/shows); the collection seed waits for repair, kinds and credits too; franchises.mjs URLs + 2 new checks; gates browser 323/0, kinds 32/0, franchises 50/0mre
  • daf49feaMerge t20 (tracker#20 typed headings + #21 series/shows split) into main (mission 070): conflicts README/STATUS/show.hl/project.hl/search.hl/components/search.hl/browser.mjs/faketmdb.mjs, both sides kept; clock order backfill → repair → kinds → credits; withDetailsFields stores tmdbType + kind; gates: browser.mjs URLs → /series|/movies, typed h1 selectors; kinds.mjs repair/credits off, fixture name = seed name; browser 323/0, kinds 32/0mre
  • 20e09d89Merge t18 (tracker#18 delta sync) into main (mission 070): conflicts README/STATUS/show.hl/project.hl/browser.mjs, both sides kept; pageShowOf summary = summaryOfmre
  • f83571c3tracker#18 (mission 067): daily sync by change lists — TMDB /tv|movie/changes (since the stored day, paged) + TVmaze /updates/shows → only our changed titles (followed: full step, unfollowed: light step — changed seasons, no TVmaze), full walk on first run / gap > 14 days / failed list; show record refreshed (title, tmdbSummary, tagline, status, genres …; renamed titles re-indexed); summary = the creator's own text (page: summary > tmdbSummary > tvmazeSummary), one-time clear of copied summaries (9,647 on the live copy); gate 261, tests/realdata-018*.mjs, README + STATUSmre
  • 1ed5457etracker#20 + #21 (mission 068): typed headings "<Type> | <name>" in type colours; TV titles split into Series (/series) and Shows (/shows) by TMDB type + Reality/Talk/News genres — kind stored by sync/import/adult backfill + new kind backfill (resumes), /movies/<slug>, /shows/<slug> of a series/movie → 301, /my/series + /my/shows, home 5 tiles + 3 rows, search/filmography labels; gates kinds 32 + browser 266, tests/realdata-068.mjs, tools/count-kinds.hl, docs/kinds.md, README + STATUSmre
  • f2b00674Merge t26 (tracker#26 + #28) into main (mission 062): short ids for every new person (castPersonId, guest route), guest stars stored on the title and created as people only when opened (/person/tmdb/<id>?show=<id> → 302), lean watch/follow clicks (showRow a small object, cast/crew from the slug, watches cached per user, face rows only after a season toggle); gate 311, tests/realdata-062.mjs, README + STATUSmre
  • 0553b51ftracker#19 (mission 066): franchises and timelines — tables, /franchises, /franchises/<slug>, /timelines/<slug> (Timeline | Release sort, series by last episode), the Prequel | Timeline | Sequel widget with the franchise above, the creator's editor, TMDB collection seed in the app (resumes, paced); gate tests/franchises.mjs 48/0 + browser.mjs 266/0, tests/realdata-066.mjs, docs/franchises.md, README + STATUSmre
  • fa1f9dfatracker#29 (mission 063): unwatched check muted grey outline + check (accent only on hover), watched stays solid — no code regression, the accent outline read as ticked; gate checks real checks visibly (computed style + screenshot pixel) on /my/unwatched, show, movie, /my/movies; gate 266, tests/realdata-063.mjs, README + STATUSmre
  • 10bb3f93tracker#28 (mission 061): full cast (all seasons, main cast by episodes, guest stars) + crew (created by, directed by, written by, screenplay, story, music) — stored by the details completion, the daily sync, the search import (one details request) and a background credits job (resumes, RSS limit); show page collapsed after 20 with client-side Show all; showBySlug via a slug map; gate 249, tests/realdata-028.mjs, README + STATUSmre
  • d8b12d67tracker#27 (mission 060): short ids for movies, series and persons — old 702 kept (data/old-short-ids.json), new random [a-z0-9]{5} unique across both, claimed at creation, background backfill (resumes), shown under poster/photo, /<shortId> → 301; gate 259, tests/realdata-060*, README + STATUSmre
  • 25a50bc4tracker#26 (mission 059): titles from a filmography are completed — on open (skeleton, step-wise face showComplete, no reload) and by the in-app details repair (resumes, TMDB-paced, series in parts); cast from TMDB credits; gate 231, tests/realdata-026.mjs, README + STATUSmre
  • f14db671tracker#22-#25 (mission 058): episode air dates, season check = all episodes watched, movie watched check (+ /my/movies count), /genres/<genre> pages (movies + series, newest first, paginated); gate 238, tests/realdata-058.mjs, README + STATUSmre
  • 1704ec45tracker#17 (mission 057): season caret down/up, skeleton rows while a season loads, sessionless showSeasonEpisodes face (no page re-mount), client-only close; gate 214, tests/realdata-057.mjs, README + STATUSmre
  • f2fe3e36mission 056: README + STATUS (merge, fixes, Hybriel 8590df63, real-data check), tests/realdata-056.mjs, tools/check-public-slugs.hlmre
  • f40c250emission 056: re-vendor hybriel master 8590df63 (#121, #122); an adult title's page is Not found for non-followers; gate: leave the page before stopping the servermre