gitoriaLog in with ident

tracker

All repositories: gitoria

ReadmeCodePull requestsReleasesTicketsSettingsCommit03ec792f03ec792ftracker#38 (mission 033): pagination goes exactly to the clicked page — tilelist read the clicked button's text after pagination.hl's own handler had rebuilt the buttons (real clicks only); now li.current, else the button's own text; new gate tests/pager.mjs (5 lists x 11 pages, 390/1280, real + script clicks, Back/Forward) 229/0; browser 365/0, kinds 32/0, franchises 52/0, check-theme 0mre03ec792f/reports/011-tracker-person.md

3.9 KB

  1. # w055 — tracker#16 person pages (mission 011 (old 055))
  3. **Branch** t16-person (worktree loreana:/media/STORAGE/projects/tracker-wt16, from main 47a3cae), not pushed/merged:
  4. - 93be947 tracker#16: person pages /person/<slug> with the filmography fetched from TMDB on the first visit (step by step), gate
  5. - 139fafd tracker#16: short bio (4 lines, click = all), real-data check script, README + STATUS
  7. **Built**: `people.hl` (new), `components/person.hl` (new), `project.hl` (route `/person/:slug`, `/profiles/:name` photo route),
  8. `search.hl` (+`titleIdByTmdb`), `styles.hl` (one block). The page shows the name, a photo (TMDB w185 saved in storage/mpackdb/profiles),
  9. born/died, a short bio (four lines, click shows all) and the filmography: poster, title, year, type and role, newest first, each linking to /shows/<slug>.
  10. Adult titles are hidden (`show.adult === true` or the credit's TMDB flag). If the person is not complete yet, the page shows "Loading filmography…"
  11. and fills in without a reload. An invisible CSS-animation tick (hl:web has no mount hook) starts the client handler, which calls the face
  12. `personFill` until it says done. Step 1 is ONE TMDB request (`/person/<id>?append_to_response=combined_credits`) plus the photo.
  13. Each later step stores 40 titles, so other requests are served between steps. Missing titles get a minimal record (TMDB `adult`, overview,
  14. genres, language; no seasons or poster). They are indexed for search and added to catalog.hl. When the fill is done, the person gets
  15. `filmographyAt` and is never fetched again. No sign-in is needed.
  17. **Gate**: `TRACKER_GATE_SHOTS=/tmp/w055/shots TRACKER_GATE_PORT=8770 TRACKER_GATE_IDENT_PORT=8771 TRACKER_GATE_CHROME=8772-8775 TRACKER_GATE_TMDB_PORT=8776 node tests/browser.mjs`
  18. → `186 passed, 0 failed` (was 167). Covered:
  19. - a complete person renders at once, with no TMDB request
  20. - client-side cast link → loading state → filled without a reload (86 rows of 87 titles, the adult one hidden)
  21. - order and roles are right, and cast + crew of one title are merged into one role
  22. - one person request + the photo; the fill took 4 steps and added 85 titles
  23. - a row opens its show page and Back works; a title the fill added has its own page
  24. - a second visit adds nothing and asks TMDB nothing
  25. - a second person is only linked (added=0); a title marked adult in our records stays hidden even when TMDB's credit says not adult
  26. - search finds an added title once
  27. - 390/1280 layout
  29. **Real data** (copy of live storage/, real TMDB, :8777; copy deleted). Cast click → page shown / filled:
  30. - Tyler Hoechlin: 131 / 643 ms, 36 credits, 7 added
  31. - Grant Gustin: 68 / 593 ms, 33 credits, 21 added
  32. - Jared Harris: 85 / 869 ms, 97 credits, 80 added, 4 steps
  33. - Niamh Algar: 76 / 584 ms, 39 credits, 20 added
  34. - The TMDB request took 242–287 ms. Other requests waited at most 678 ms (median 13–32 ms).
  35. - Stress test with Eric Roberts: 758 credits, 712 added, 20 steps, 3.8 s; other requests waited at most 612 ms.
  36. - Second visit, full load: 41–120 ms. 0 console problems.
  38. **Screenshots** (looked at): gate `/tmp/w055/shots/person{,-complete}-{390,1280}.png`, real data `/tmp/w055/real/*.png` on Loreana.
  40. **Merge notes**: all shared-file changes are additive (details in STATUS #16 "Merge notes"). Fixture changes: Test Actor gets `tmdbId 3002`, genre
  41. Drama gets `tmdbId 18`, plus 2 persons. 54's `adult` field is read and written by people.hl under the same name `adult` (boolean).
  42. If 054 hides adult titles in public lists, the gate's "Hidden Adult Film" disappears from /movies; no check depends on that.
  44. **Open points**:
  45. - The TMDB step blocks the server for that one request (hl:fetch is blocking).
  46. - People are never refreshed after they are complete.
  47. - Adult people are not hidden, only titles.
  48. - Added titles have no poster file and no seasons until they are synced.
  49. - Not caused by #16: the signed-out header at 390 px wraps "choose ident" / "Log in with ident" onto two lines.
  51. **Hybriel**: no new issue. A `while` loop with `emit server` inside a client handler works.

Branches

Latest commits

  • 03ec792ftracker#38 (mission 033): pagination goes exactly to the clicked page — tilelist read the clicked button's text after pagination.hl's own handler had rebuilt the buttons (real clicks only); now li.current, else the button's own text; new gate tests/pager.mjs (5 lists x 11 pages, 390/1280, real + script clicks, Back/Forward) 229/0; browser 365/0, kinds 32/0, franchises 52/0, check-theme 0mre
  • 96ba683adeploy.sh: a gate without a 'passed,' line (check-theme) no longer ends the scriptmre
  • eb3b9205tracker: report 031mre
  • 9b5d2e89tracker mission 031: README (What it does, Test: four gates + the #32 checks, Files: theme/, new pages), STATUS (real copy, A/B load, how to repeat, open points), LOGmre
  • 39950e4ctracker#32 (mission 031): the WorldAPI theme (theme/ vendored verbatim from layouts.worldapi.org 85b5654; styles.hl inherits it: accent green-dark, type colours 1-6; own base/header rules, row lines, genre-pill and inverted-button frames removed, the season foldable keeps its line; check-theme 21 -> 0, 4th deploy gate; main actions class primary) and the #32 header (theme AppHeader/MainMenu/UserMenu/Sidebar/ContentFirst: desktop brand, search, Series|Shows|Movies|Genres|People, user icon with Unwatched..Settings, Logout; signed out the ident selector, phone the iD icon dropdown; phone menu in the sidebar overlay; marked entry by :has); /find -> /search/<q>, /genres, /people(/<letter>), /settings; main { ContentFirst { slot } } works around the hl:web one-line slot bug; gates 365/0, 32/0, 52/0, check-theme 0mre
  • a386dc92tracker: reports 029 + 030mre
  • 71e0fd7dtracker missions 029 + 030: README (What it does, Files, gate count), STATUS (real-copy numbers, how to repeat, open points), LOGmre
  • d36ea6eatracker#34 + #35 (mission 030): Follow directly under the poster, as wide as the poster (show.hl, styles.hl); the status pill next to a series' title — TVmaze's status (new tvmazeStatus, stored by the sync's TVmaze merge) else TMDB's, TVmaze Ended + TMDB Canceled = Canceled, inverted (filled, dark text, no border), green running / yellow pending / red canceled / muted ended (shows.hl statusOf); the daily delta asks TVmaze's status of an unfollowed series TVmaze's change list names (dailysync.hl syncRunStep, sync.hl syncTvmazeStatus); the status backfill after the details repair (backfill.hl, jobs.hl statusTick; resumable, 550 ms per TVmaze request); gates 354/0, 32/0, 52/0mre
  • 7d7d4487tracker#33 (mission 029): reduced titles — every title TMDB's details never went through this app (no detailsAt, no tmdbSync) is incomplete (shows.hl isIncomplete; the old tracker's migrated rows passed #26's test: 5,697 non-adult on the live copy, 691 series without seasons); the repair job does the visibly reduced first (shows.hl missingParts), the page completes one on open; a title TMDB has no poster for (The Remaining) shows the placeholder; tools/count-incomplete.hl; gate fixtures stand for synced titles (tmdbSync), tests/seed-reduced.hl + #33 checks; gates 347/0, 32/0, 52/0mre
  • 661c2592tracker: report 028mre
  • 27c916fatracker mission 028: README ("Code order", the new file map), STATUS (counts before/after, tests, how to repeat, open), LOGmre
  • d924f398tracker mission 028: comments name the new files (sync.hl, dailysync.hl, backfill.hl, credits.hl, jobs.hl, images.hl …); tools/ref-params.py + tools/lambda-audit.py also scan lib/ (they globbed the root only), lambda-audit counts a plain `x = p` alias like `let x = p`mre
  • 2e89b968tracker mission 028 (code order) 5/5 let: `let` only where a variable is reassigned — 667 never-reassigned lets became plain declarations (project.hl, lib/, components/, tools/, tests/); kept: 264 in loop bodies (a plain declaration there is 'Cannot reassign' on the 2nd pass), 234 reassigned, 27 whose name is also a member/outer/free name (a plain write would rebind it); tools/let-audit.py decides and fixes (README 'Code order'); tests/realdata-m028.{sh,mjs} = the page-output diff on a real copy; gates 342/0, 32/0, 52/0, real-copy pages identicalmre
  • 54796ff2tracker mission 028 (code order) 4/5 thin faces + last copies: the show page's check/follow faces call lib/watches.hl toggleWatched / toggleSeasonWatched (seasonAllWatched moved there) and lib/follows.hl toggleFollowed; both logins (header selector face, /login/callback) share lib/users.hl userOfCode; todayStr/listOf copies in components and the export readers copied into tools/migrate.hl + tools/old-short-ids.hl now once (lib/util.hl, lib/export.hl); gates 342/0, 32/0, 52/0; old-short-ids output byte-identical, migrate output identicalmre
  • 06b078e3tracker mission 028 (code order) 3/5 project.hl is the map: config, routes, wiring and a feature → file index (914 → 258 lines); the background jobs (daily sync run, backfills, details repair, credits job, merge, short ids, collection seed) moved unchanged into lib/jobs.hl (a class: their state is reassigned every step, a static cannot be; one instance made after the server), the login callback into lib/users.hl, poster/photo serving into lib/images.hl, the /shows/<slug> rule into lib/shows.hl showsMovedPath; route handlers are thin wrappers; gates 342/0, 32/0, 52/0, real-copy pages identicalmre
  • 94716fd2tracker mission 028 (code order) 2/5 util + topics: lib/util.hl holds envOr, storageDir, postersDir, profilesDir, newId, hexDigits, todayStr, dateOr, textOr, hasId, listOr, firstOf, sortDesc once (were copied into up to 5 files); tmdbsync.hl split into tmdb.hl (TMDB/TVmaze requests), sync.hl (one title's sync), sync-helpers.hl, backfill.hl; details.hl split into details.hl, credits.hl, credits-helpers.hl (isIncomplete to shows.hl); search-helpers.hl (words, query, ranking, slugs); collections.hl (the TMDB collection seed, out of franchises.hl); deltasync.hl renamed dailysync.hl; no behaviour change: gates 342/0, 32/0, 52/0, real-copy pages identicalmre
  • 186079b0tracker mission 028 (code order) 1/5 move: every root .hl except project.hl into lib/ (styles.hl into components/), import paths only; gates 342/0, 32/0, 52/0; real-copy pages identicalmre
  • 4f47f181tracker: report 027mre
  • dc1d4be4tracker mission 027: Hybriel master 06617221 vendored (plugin allocator fixes 3a781359 + 413f60e4); real copy RSS through first-start jobs + 400 loads flat ~2.55 GB (190aa11d 2.3 -> 5.6 GB), page times <= 1.1x; gates 342/0, 32/0, 52/0mre
  • 84e1b3e1tracker: reports 025 + 026mre