gitoriaLog in with ident

tracker

All repositories: gitoria

ReadmeCodePull requestsReleasesTicketsSettings
Branchmain5cb85d75deploy.sh: a backup taken while a background job writes (tar exit 1) is a warning; archive checked with gzip -tmremain/reports/016-tracker-short-ids.md

5.7 KB

  1. # w060: tracker#27, short ids (mission 016 (old 060))
  2. **Commit**: `d8b12d6` on main in loreana:/media/STORAGE/projects/tracker.worldapi.org. Not pushed and not deployed. I did not touch tracker-wt26.
  3. ## What was built
  4. - Every show (movie or series) and every person has a field `shortId`: 5 characters from `[a-z0-9]`.
  5. - Each short id is unique across both tables. One in-memory map in `shortids.hl` covers both tables and is built at start (0.12–0.22 s on real data).
  6. - I did not use an mpackdb index, because an mpackdb index covers only one table.
  7. - **Old ids**: `data/old-short-ids.json` maps the old tracker's 702 ids from oldId to id.
  8. - `tools/old-short-ids.hl` made the file once from `Show.jsonl`. All 702 old ids are already `[a-z0-9]{5}`.
  9. - The file is part of the code, so the deploy sends it along.
  10. - All 702 old ids are reserved: a new random id is never one of them.
  11. - **New records** get a short id when they are created (`claimShortId`): the search import and the titles the person fill adds.
  12. - Those are the only places where the app creates shows.
  13. - Persons are only created by `tools/migrate.hl`, and the sync only creates seasons and episodes.
  14. - **Backfill**: chosen to run in the background, not at start.
  15. - Doing all records at start would block the server for at least 16 s (25k records).
  16. - It runs on its own 0.1 s clock and works in batches of up to 40 ms.
  17. - It saves to disk every 20 batches and at the end.
  18. - After a restart it continues with the records that still have no short id.
  19. - If a stored short id is already held by another record, that record gets a new one (tested in the gate).
  20. - `TRACKER_SHORTIDS=0` switches it off. `TRACKER_SHORTID_BUDGET_MS` and `TRACKER_SHORTID_LOG_EVERY` are its other settings.
  21. - **Shown** as `#shortid` under the poster, and under the person's photo. A person without a photo has it under the name and facts. It is small (.8rem), muted and monospace.
  22. - **Redirect**: `/<shortId>` answers 301 to `/shows/<slug>` or `/person/<slug>`. Upper case works too. Anything else answers 404. This is the last route, so every named route wins over it.
  23. ## Gate
  24. `TRACKER_GATE_SHOTS=/tmp/w060/shots TRACKER_GATE_PORT=8720 TRACKER_GATE_IDENT_PORT=8721 TRACKER_GATE_CHROME=8722-8726 TRACKER_GATE_TMDB_PORT=8727 node tests/browser.mjs`
  25. → **`259 passed, 0 failed`** (was 238; 21 new checks). The gate takes about 1.5 min.
  26. The new checks prove:
  27. - The old id is kept: sh1 → 100jh.
  28. - A movie and a series get new ids.
  29. - A search import has its short id right away.
  30. - The person fill's titles get theirs when they are created.
  31. - The id is under the poster and the photo, and under the facts for a person without a photo. Checked: monospace, muted and smaller, at 390 and 1280 px.
  32. - The 301 redirects and the 404s work, and the browser lands on the right page.
  33. - `tools/count-short-ids.hl`: every record has a short id and there are 0 duplicates.
  34. - Resume: `tests/seed-shortids.hl` adds 60 persons without an id and 2 that share `aaaa1`. A start with a 1 ms budget is stopped part way, and the next start does only the rest. One of the two keeps `aaaa1` and the other gets a new id. A third start has nothing to do.
  35. - I looked at the screenshots in Loreana `/tmp/w060/shots/shortid-*`.
  36. ## Real data
  37. Copy of Byrodin `storage/` (10,010 shows, 15,157 persons), server on :8730.
  38. | | |
  39. |---|---|
  40. | **Backfill duration** | 25,167 records in **297 s** (another run: 307 s) |
  41. | Batches | 1,859; slowest 62 ms |
  42. | Slowest save to disk | 31 ms |
  43. | **Old kept** | **702 / 702** (Raised by Wolves `100jh`, Foundation `100sp`) |
  44. | Lost | 0 |
  45. | New ids that are an old one | 0 |
  46. | **Duplicates across shows + persons** | **0** |
  47. | Duplicate @ids (all tables, `count-duplicate-ids`) | 0 |
  48. **Pages during the backfill** (curl, back to back, about 520 requests each; avg / max / number over 1 s):
  49. | page | during the backfill | without it (baseline, 120 s) |
  50. |---|---|---|
  51. | `/shows/Foundation` | 0.234 / 1.56 / 9 | 0.173 / 1.34 / 5 |
  52. | `/person/Jared-Harris` | 0.170 / 1.37 / 9 | 0.046 / 1.10 / 5 |
  53. | `/` | 0.070 / 1.34 / 2 | 0.022 / 0.99 / 0 |
  54. | `/movies` | 0.073 / 1.18 / 2 | 0.015 / 1.01 / 1 |
  55. - Answers over 1 s happen without the backfill too. Loreana was busy with other workers.
  56. - The backfill's own steps never took more than 62 ms. On average it adds about 0.1 s per page.
  57. **Full page loads** (signed in as the creator, ms, 3 loads each):
  58. | page | 390 px | 1280 px |
  59. |---|---|---|
  60. | Raised by Wolves (opened via `/100jh`) | 1372 / 297 / 310 | 335 / 266 / 301 |
  61. | Foundation | 302 / 306 / 250 | 1246 / 205 / 195 |
  62. | Star Trek: First Contact (`aafif`) | 275 / 287 / 275 | 211 / 235 / 212 |
  63. | Jared Harris (`yg7lk`) | 164 / 138 / 122 | 104 / 119 / 121 |
  64. - Every short id answers 301 in 1–27 ms, and the browser lands on the page. `/zzzzz` answers 404. There were 0 console problems.
  65. - Screenshots on Loreana: `/tmp/w060/real/{old-id,series,movie,person}-{390,1280}.png`. I looked at them. That folder also has older `Grant-Gustin*`/`Jared-Harris*` files that are not mine.
  66. - The copy and its sessions are deleted. Nothing of mine is still running on 8720–8731.
  67. ## Open points
  68. 1. Deploy: the first start runs the backfill (about 5 minutes). Short ids appear page by page while it runs.
  69. 2. Inside the app, one record costs about 3 ms; in a plain script it costs about 0.6 ms. I did not find out why.
  70. - **Hybriel finding**: reading a list kept as a field of a `static` object (`state.queue[i]`) seems to copy the whole list on every access. Batches got about 5× faster after I made the list a plain `static`. I made no minimal repro.
  71. 3. Nothing in the app creates persons today. A later step that does must call `claimShortId('person', id, oldId)`.
  72. 4. `/<shortId>` of an adult title still redirects. That page then says "Not found" to anyone who does not follow it, as before.

Branches

  • mainmain branch

Latest commits

  • 5cb85d75deploy.sh: a backup taken while a background job writes (tar exit 1) is a warning; archive checked with gzip -tmre
  • 9abda75dtracker: report 035mre
  • 12595e47mission 035: theme re-vendored from layouts.worldapi.org 0222f67 (two corner radii: radiusSmall 5px, radiusLarge 10px); the tracker's 18 own radii -> radiusSmall/radiusLarge (--layout-radius is gone); check-theme 0; gates 379/0, 32/0, 53/0, 229/0, 26/0; real copy: every computed radius in {0, 5px, 10px, 50%}mre
  • e7305014tracker: report 032 (art + photos)mre
  • fbb903cctracker#33/#37 (mission 032): a title without a TMDB poster gets its backdrop (w780, posterFromBackdrop, shown 2:3 centre-cropped); movies store runtime, the page shows release date + runtime; art backfill (public titles without poster file / movies without runtime) and person photo backfill (tmdbProfile / photoCheck) as the last start jobs (TRACKER_ART, TRACKER_PHOTOS; off in every gate start); gates 379/0, 32/0, 53/0, 229/0, 26/0, check-theme 0; live copy: art 4977 titles in 42 min (115 posters, 15 backdrops, 4609 runtimes), The Remaining shows its backdrop + 7 minmre
  • 4ecc67b2tracker: STATUS/LOG for the t38 + t40 merge (gates 374/0, 32/0, 53/0, 229/0, 26/0, check-theme 0; live copy checks)mre
  • e5945d2fMerge t40 (tracker#40 curated franchises, Franchises menu, superseded collections) into main: deploy.sh lists all six gates (browser, kinds, franchises, pager, franchiseseed, check-theme); search.hl keeps #37's personPhotoOf + #40's importWithCredits; pager gate runs with TRACKER_FRANCHISE_SEED=0; gates 374/0, 32/0, 53/0, 229/0, 26/0, check-theme 0mre
  • b638e99dMerge t38 (tracker#38 pagination, #35 Returning/Airing label) into main: LOG/STATUS keep both sides; pager gate follows #37's /people (everyone, last updated first: seed updatedAt); gates pager 229/0, browser 374/0mre
  • f8ffa4dbtracker: report 032 + The Remaining + #39mre
  • 7565a863tracker: LOG timemre
  • b10f00c8tracker#39: double episodes — migrated episodes whose TMDB id TMDB replaced are adopted by their number in the sync (old id -> migratedTmdbId); merge.hl step 3 merges each season's doubles at start (keeper: most watches > synced > first; watches moved/parked; tombstones into mergedEpisodes, nothing deleted); tools/count-duplicate-episodes.hl; gate fixture + paths-m039; live copy 850 -> 0 in 64 s; gates 373/0, 32/0, 52/0mre
  • 8f1d4542tracker#40: superseded collections — a TMDB collection timeline whose titles are all in one curated timeline is hidden (supersededBy; kept: own page + editor finder), set by the collection seed when it makes one and by the curated build (lifted when the cover is gone); partly covered ones join that franchise; no second widget (First Contact: only Star Trek — Prime); gate franchiseseed 26/0, browser 365/0, kinds 32/0, franchises 53/0, check-theme 0; real copy 24 supersededmre
  • 9448d643tracker#35 follow-up (mission 033): TVmaze 'Running' is labelled 'Returning', or 'Airing' while a non-special episode of the two newest seasons is released within today +-7 days (data unchanged); gate fixtures Running/Airing/Aired + a special; browser 366/0, kinds 32/0, franchises 52/0, pager 229/0, check-theme 0mre
  • 7d4b293dtracker#40: "Franchises" in the main menu (desktop header after People, phone sidebar) → /franchises, marked on franchise and timeline pages; gates 365/0, 32/0, 53/0, 24/0, check-theme 0mre
  • 8751adb8tracker: report 032mre
  • 9bce1f65tracker mission 032: STATUS gate files + the hour-boundary flakemre
  • 718bfb89tracker#37 (mission 032): /people = everyone, last updated first (updatedAt stamped by the person fill; view built at boot, touched people first at once), photo + name tiles (person colour) with the /movies pagination, /people/<letter> removed; photo = our file, tmdbProfile, a cast/crew entry's profile (in-memory map at boot), else the new 'no photo' placeholder; new cast/crew/created_by people keep tmdbProfile; search people rows with the photo; /settings = the heading only; util.hl sortDesc starts from sorted runs (same result, 105k: 1.6 s -> 0.15 s); gates 369/0, 32/0, 52/0, check-theme 0; README/STATUS/LOGmre
  • 93dfb0batracker#40 (mission 034): the curated franchises — data/franchises.json (17 franchises, 31 timelines, 285 TMDB titles, movies + series, in-universe/release order, 12 TMDB collections attached); lib/franchiseseed.hl + jobs.hl franchiseSeedTick (last start job, imports missing titles via details.hl importWithCredits = the search's Add, one per step paced, then one build; franchiseseed.db: editor changes win, the creator's same-name franchise adopted / timeline left alone, 404 remembered, resumable, idempotent); timeline heads 'N titles · in-universe order' (orderKind) and wrap on a phone; series pages show the widget; new gate tests/franchiseseed.mjs (5th in deploy.sh), the others run with TRACKER_FRANCHISE_SEED=0; gates 365/0, 32/0, 52/0, 24/0, check-theme 0; real copy 196 imported, 0 failed, 7 min, restart unchanged=31mre
  • 03ec792ftracker#38 (mission 033): pagination goes exactly to the clicked page — tilelist read the clicked button's text after pagination.hl's own handler had rebuilt the buttons (real clicks only); now li.current, else the button's own text; new gate tests/pager.mjs (5 lists x 11 pages, 390/1280, real + script clicks, Back/Forward) 229/0; browser 365/0, kinds 32/0, franchises 52/0, check-theme 0mre
  • 96ba683adeploy.sh: a gate without a 'passed,' line (check-theme) no longer ends the scriptmre