tracker

5.0 KB

1. # w056: tracker, #16 merged, 3 fixes, Hybriel master (mission 012 (old 056))
3. The work is in loreana:/media/STORAGE/projects/tracker.worldapi.org, on main. Nothing was pushed and nothing was deployed.
5. **Commits**
6. - `2c53d5e`: merges t16-person into main.
7. - All conflicts only added code on both sides, so both sides were kept.
8. - The filmography now lists only public titles (`isPublicTitle`, which means `adult == false`) whose TMDB credit is not adult either.
9. - The worktree tracker-wt16 and the branch are removed. Their `.scratch/w055` notes were moved to `.scratch/w055-wt16`.
10. - `2b7fdd6`: the header fix and the backfill fix.
11. - Signed out on a phone, the header is now one row. The buttons do not wrap their text, and the phone shows "Log in" ("Log in with ident" from 40rem up). It is 46 px high at 320 and 390 px (it was 73 px).
12. - The backfill no longer downloads the posters of adult titles. Their flag and ids are still stored.
13. - `f40c250`: the new Hybriel and the hidden adult show page.
14. - Hybriel master is re-vendored.
15. - The page of an adult title says "Not found" to everyone who does not follow it.
16. - Two flaky gate checks are fixed.
17. - `f2fe3e3`: README, STATUS, `tests/realdata-056.mjs` and `tools/check-public-slugs.hl`.
19. **Gate**
20. `TRACKER_GATE_SHOTS=/tmp/w056/shots TRACKER_GATE_PORT=8720 TRACKER_GATE_IDENT_PORT=8721 TRACKER_GATE_CHROME=8722-8726 TRACKER_GATE_TMDB_PORT=8727 node tests/browser.mjs`
21. - Last line: **`208 passed, 0 failed`**. That is 203 after the merge plus 5 new checks.
22. - I made two gate fixes:
23. - The backfill's "start" line is written at the first clock tick, which comes after the server's first answer. The check now waits for that line; without the wait it failed every time after the merge.
24. - The tab now goes to about:blank before each server stop. Without that, websocket reconnect errors sometimes failed the console check.
25. - I proved two of the new checks catch the bug they are for:
26. - With the old poster download put back, the poster check fails.
27. - With the old Hybriel binary, the "Unfollow hides the page" check fails.
29. **Hybriel**
30. - Master **8590df63** (it includes 73267707 / #122 and #121 426944c7). Built read-only, ReleaseFast, sha256 `ca830ef8…`.
31. - The old copy is in `.scratch/pre-056/`.
32. - Duplicate @ids in the live copy: 0 in all 8 tables.
33. - No workaround was removed. The SVG check was already in the gate.
35. **Hiding the adult show page: it works now**
36. - Why mission 010 (old 054)'s attempt failed: `collapsed` (which seasons are open, kept in the browser) was derived from the session-dependent `found`.
37. - After every session face, the server re-derived it from the page's starting state. The seasons snapped back and the second click did nothing.
38. - Now `collapsed` comes from the slug only. `showRow` itself is null when the page is hidden, because every member is sent to the browser.
39. - What a user sees:
40. - A follower sees the page.
41. - If the follower unfollows on the page, it changes to "Not found" at once.
42. - No minimal repro for Anton was needed.
44. **Real data** (copy of the live `storage/`, one tar, real TMDB, the backfill run on the copy; the copy was deleted afterwards)
46. | | |
47. |---|---|
48. | Backfill | 78 min: adult 3,450, not adult 5,866, unknown 137 |
49. | Posters | **5,433 downloaded (was 8,740), 269 MB (was 459 MB)** |
51. Full page loads in ms, at 390 / 1280 px:
53. | page | 390 | 1280 |
54. |---|---|---|
55. | `/` | 426 | 91 |
56. | `/movies` | 92 | 90 |
57. | `/movies/page/2` | 93 | 37 |
58. | `/shows` | 287 | 41 |
59. | `/shows/page/2` | 92 | 42 |
60. | `/search/the` | 336 | 126 |
61. | `/search/sex` | 442 | 91 |
62. | `/person/Jared-Harris` | 242 | 102 |
63. | `/shows/Foundation` | 189 | 145 |
64. | `/my/shows` | 650 | 219 |
65. | `/my/movies` | 41 | 38 |
66. | `/my/unwatched` | 1478 | 1655 |
67. | `/my/schedule` | 457 | 322 |
69. - The first visit of the person page loaded the filmography from TMDB: 97 credits, 80 titles added, 487 ms.
70. - `/my/unwatched` took 1.5–2.4 s over repeated loads (the server part is 1.33 s, 1,595 rows). The old Hybriel gives the same times.
71. - The header is one row on every page.
72. - The adult page (`/shows/This-Aint-Star-Trek-XXX`) says "Not found" signed out, and its slug is not in the HTML. It also says "Not found" for az5b2, who follows no adult title.
73. - I collected every link on all 251 list pages, `/`, 6 searches and the person page: 5,914 slugs. All of them are `adult == false`; 0 adult, 0 unknown.
74. - 0 console problems.
75. - Screenshots on Loreana: `/tmp/w056/real/{out,in}-*-{390,1280}.png` and the gate's `header-signed-out-{320,390,1280}.png`. I looked at them.
77. **Open points**
78. 1. Deploy: the backfill runs on the live data for about 80 min and adds about 270 MB of posters.
79. 2. `/my/unwatched` is at the 2 s target (1.5–2.4 s).
80. 3. hl:fetch blocks the whole server while a TMDB answer is slow (the slowest step in this run took 5 s).
81. 4. When someone unfollows an adult title on its page, the page turns into "Not found" at once. That follows from the rule; tell me if a softer behaviour is wanted.
82. 5. Still open from before: 137 TMDB-404 titles stay hidden, adult people are not hidden, and people are never refreshed.